Skip to content

Commit c3a76ab

Browse files
authored
Update to Selenium v.4.34.0 (#130) +semver: feature
* Update to Selenium v.4.34.0 Update other package versions, including update to NLog v.6.0.1 Include ConcurrentFileTarget package and update code references * fix documentation
1 parent 2b0bb97 commit c3a76ab

File tree

5 files changed

+14
-14
lines changed

5 files changed

+14
-14
lines changed

Aquality.Selenium.Core/src/Aquality.Selenium.Core/Aquality.Selenium.Core.csproj

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,13 @@
4848
</ItemGroup>
4949
<ItemGroup>
5050
<PackageReference Include="DotNetSeleniumExtras.PageObjects" Version="3.11.0" />
51-
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="9.0.5" />
52-
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="9.0.5" />
51+
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="9.0.7" />
52+
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="9.0.7" />
5353
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
54-
<PackageReference Include="NLog" Version="5.4.0" />
55-
<PackageReference Include="Selenium.Support" Version="4.33.0" />
56-
<PackageReference Include="Selenium.WebDriver" Version="4.33.0" />
54+
<PackageReference Include="NLog" Version="6.0.1" />
55+
<PackageReference Include="NLog.Targets.ConcurrentFile" Version="6.0.1" />
56+
<PackageReference Include="Selenium.Support" Version="4.34.0" />
57+
<PackageReference Include="Selenium.WebDriver" Version="4.34.0" />
5758
<PackageReference Include="SkiaSharp" Version="3.119.0" />
5859
</ItemGroup>
5960
</Project>

Aquality.Selenium.Core/src/Aquality.Selenium.Core/Aquality.Selenium.Core.xml

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Aquality.Selenium.Core/src/Aquality.Selenium.Core/Logging/Logger.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ private LoggingConfiguration GetConfiguration()
3535
{
3636
Layout = layout
3737
});
38-
config.AddRule(LogLevel.Debug, LogLevel.Fatal, new FileTarget("logfile")
38+
config.AddRule(LogLevel.Debug, LogLevel.Fatal, new ConcurrentFileTarget("logfile")
3939
{
4040
FileName = "../../../Log/log.log",
4141
Layout = layout,
@@ -65,7 +65,7 @@ public Logger AddTarget(Target target)
6565
/// <summary>
6666
/// Removes configuration (target).
6767
/// </summary>
68-
/// <param name="target">Target configuratio to remove.</param>
68+
/// <param name="target">Target configuration to remove.</param>
6969
/// <returns>Logger instance.</returns>
7070
public Logger RemoveTarget(Target target)
7171
{

Aquality.Selenium.Core/tests/Aquality.Selenium.Core.Tests/Aquality.Selenium.Core.Tests.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,14 @@
2525
</ItemGroup>
2626

2727
<ItemGroup>
28-
<PackageReference Include="Appium.WebDriver" Version="7.2.0" />
29-
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="9.0.5" />
28+
<PackageReference Include="Appium.WebDriver" Version="8.0.0" />
29+
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="9.0.7" />
3030
<PackageReference Include="nunit" Version="4.3.2" />
3131
<PackageReference Include="NUnit3TestAdapter" Version="5.0.0">
3232
<PrivateAssets>all</PrivateAssets>
3333
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
3434
</PackageReference>
35-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.0" />
35+
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
3636
</ItemGroup>
3737

3838
<ItemGroup>

Aquality.Selenium.Core/tests/Aquality.Selenium.Core.Tests/Utilities/LoggerTests.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
using Aquality.Selenium.Core.Logging;
22
using Aquality.Selenium.Core.Tests.Applications.Browser;
33
using Aquality.Selenium.Core.Tests.Applications.Browser.Elements;
4-
using Aquality.Selenium.Core.Tests.Applications.WindowsApp.Elements;
54
using NLog.Targets;
65
using NUnit.Framework;
76
using OpenQA.Selenium;
@@ -81,9 +80,9 @@ public void Should_BePossibleTo_RemoveTarget()
8180
$"Target wasn't removed. File '{RemoveTargetLogFile}' exists.");
8281
}
8382

84-
private static FileTarget GetTarget(string filePath)
83+
private static ConcurrentFileTarget GetTarget(string filePath)
8584
{
86-
return new FileTarget
85+
return new ConcurrentFileTarget
8786
{
8887
Name = Guid.NewGuid().ToString(),
8988
FileName = filePath,

0 commit comments

Comments
 (0)