fix #120 (possible StaleElementReference exception in FindElements due to second filteration) (#121)

Author: mialeska

Aquality.Selenium/src/Aquality.Selenium/Elements/ElementFinder.cs

@@ -65,31 +65,31 @@ public ReadOnlyCollection<IWebElement> FindElements(By locator, Func<IWebElement
         }
 
         internal ReadOnlyCollection<IWebElement> FindElements(By locator, DesiredState desiredState, TimeSpan? timeout = null)
-        {            
+        {
+            var foundElements = new List<IWebElement>();
             var resultElements = new List<IWebElement>();
             try
             {
                 ConditionalWait.WaitFor(driver =>
                 {
-                    var elements = driver.FindElements(locator);
-                    resultElements.Clear();
-                    resultElements.AddRange(elements);
-                    return elements.Any(desiredState.ElementStateCondition);
+                    foundElements = driver.FindElements(locator).ToList();
+                    resultElements = foundElements.Where(desiredState.ElementStateCondition).ToList();
+                    return resultElements.Any();
                 }, timeout);
             }
             catch (WebDriverTimeoutException ex)
             {
-                HandleTimeoutException(ex, desiredState, locator, resultElements);
+                HandleTimeoutException(ex, desiredState, locator, foundElements);
             }
-            return resultElements.Where(desiredState.ElementStateCondition).ToList().AsReadOnly();
+            return resultElements.AsReadOnly();
         }
 
-        private void HandleTimeoutException(WebDriverTimeoutException ex, DesiredState desiredState, By locator, List<IWebElement> resultElements)
+        private void HandleTimeoutException(WebDriverTimeoutException ex, DesiredState desiredState, By locator, List<IWebElement> foundElements)
         {
             var message = LocalizationManager.Instance.GetLocalizedMessage("loc.no.elements.found.in.state", locator.ToString(), desiredState.StateName);
             if (desiredState.IsCatchingTimeoutException)
             {
-                if (!resultElements.Any())
+                if (!foundElements.Any())
                 {
                     if (desiredState.IsThrowingNoSuchElementException)
                     {
@@ -105,7 +105,7 @@ private void HandleTimeoutException(WebDriverTimeoutException ex, DesiredState d
             else
             {
                 var combinedMessage = $"{ex.Message}: {message}";
-                if (desiredState.IsThrowingNoSuchElementException && !resultElements.Any())
+                if (desiredState.IsThrowingNoSuchElementException && !foundElements.Any())
                 {
                     throw new NoSuchElementException(combinedMessage);                    
                 }

Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/TestApp/TheInternet/Forms/TheInternetForm.cs

@@ -19,6 +19,7 @@ protected TheInternetForm(By locator, string name) : base(locator, name)
         public void Open()
         {
             BrowserManager.Browser.GoTo(Url);
+            BrowserManager.Browser.WaitForPageToLoad();
         }
     }
 }