Skip to content

Commit deb7725

Browse files
authored
Update Selenium packages to version 4.8.1 (#230)
Make JavaScriptHandling disposable Closes #228
1 parent 80513d8 commit deb7725

File tree

4 files changed

+26
-2
lines changed

4 files changed

+26
-2
lines changed

Aquality.Selenium/src/Aquality.Selenium/Aquality.Selenium.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@
7676
</ItemGroup>
7777

7878
<ItemGroup>
79-
<PackageReference Include="Aquality.Selenium.Core" Version="2.1.0" />
79+
<PackageReference Include="Aquality.Selenium.Core" Version="2.1.2" />
8080
<PackageReference Include="WebDriverManager" Version="2.16.2" />
8181
</ItemGroup>
8282

Aquality.Selenium/src/Aquality.Selenium/Aquality.Selenium.xml

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Aquality.Selenium/src/Aquality.Selenium/Browsers/JavaScriptHandling.cs

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -276,5 +276,23 @@ public async Task Reset()
276276
await javaScriptEngine.Reset();
277277
bindings.Clear();
278278
}
279+
280+
/// <summary>
281+
/// Performs application-defined tasks associated with freeing, releasing,
282+
/// or resetting unmanaged resources.
283+
/// </summary>
284+
public void Dispose()
285+
{
286+
Dispose(disposing: true);
287+
GC.SuppressFinalize(this);
288+
}
289+
290+
protected virtual void Dispose(bool disposing)
291+
{
292+
if (disposing)
293+
{
294+
javaScriptEngine.Dispose();
295+
}
296+
}
279297
}
280298
}

Aquality.Selenium/tests/Aquality.Selenium.Tests/Aquality.Selenium.Tests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
<PrivateAssets>all</PrivateAssets>
3535
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
3636
</PackageReference>
37-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.4.1" />
37+
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.5.0" />
3838
</ItemGroup>
3939

4040
<ItemGroup>

0 commit comments

Comments
 (0)