Skip to content

Commit 3616258

Browse files
committed
devtools v85-> v137, hotfix of compatibility issues
1 parent 72306c3 commit 3616258

File tree

7 files changed

+28
-24
lines changed

7 files changed

+28
-24
lines changed

src/main/java/aquality/selenium/browser/devtools/DevToolsHandling.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
import org.openqa.selenium.devtools.DevTools;
1010
import org.openqa.selenium.devtools.Event;
1111
import org.openqa.selenium.devtools.HasDevTools;
12-
import org.openqa.selenium.devtools.v85.performance.Performance;
13-
import org.openqa.selenium.devtools.v85.performance.model.Metric;
12+
import org.openqa.selenium.devtools.v137.performance.Performance;
13+
import org.openqa.selenium.devtools.v137.performance.model.Metric;
1414

1515
import java.util.List;
1616
import java.util.Map;

src/main/java/aquality/selenium/browser/devtools/EmulationHandling.java

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22

33
import org.apache.commons.lang3.StringUtils;
44
import org.openqa.selenium.devtools.Command;
5-
import org.openqa.selenium.devtools.v85.dom.model.RGBA;
6-
import org.openqa.selenium.devtools.v85.emulation.Emulation;
7-
import org.openqa.selenium.devtools.v85.emulation.model.MediaFeature;
8-
import org.openqa.selenium.devtools.v85.emulation.model.ScreenOrientation;
5+
import org.openqa.selenium.devtools.v137.dom.model.RGBA;
6+
import org.openqa.selenium.devtools.v137.emulation.Emulation;
7+
import org.openqa.selenium.devtools.v137.emulation.model.MediaFeature;
8+
import org.openqa.selenium.devtools.v137.emulation.model.ScreenOrientation;
99

1010
import java.util.Collections;
1111
import java.util.List;
@@ -45,7 +45,8 @@ public boolean canEmulate() {
4545
* @param accuracy Accuracy of the location
4646
*/
4747
public void setGeolocationOverride(double latitude, double longitude, double accuracy) {
48-
setGeolocationOverride(Optional.of(latitude), Optional.of(longitude), Optional.of(accuracy));
48+
setGeolocationOverride(Optional.of(latitude), Optional.of(longitude), Optional.of(accuracy), Optional.empty(),
49+
Optional.empty(), Optional.empty(), Optional.empty());
4950
}
5051

5152
/**
@@ -64,8 +65,10 @@ public void setGeolocationOverride(double latitude, double longitude) {
6465
* @param longitude Longitude of location
6566
* @param accuracy Accuracy of the location
6667
*/
67-
public void setGeolocationOverride(Optional<Number> latitude, Optional<Number> longitude, Optional<Number> accuracy) {
68-
tools.sendCommand(Emulation.setGeolocationOverride(latitude, longitude, accuracy));
68+
public void setGeolocationOverride(Optional<Number> latitude, Optional<Number> longitude, Optional<Number> accuracy,
69+
Optional<Number> altitude, Optional<Number> altitudeAccuracy, Optional<Number> heading,
70+
Optional<Number> speed) {
71+
tools.sendCommand(Emulation.setGeolocationOverride(latitude, longitude, accuracy, altitude, altitudeAccuracy, heading, speed));
6972
}
7073

7174
/**
@@ -115,7 +118,7 @@ public void setDeviceMetricsOverride(Integer width, Integer height, Number devic
115118
screenOrientation = Optional.of(new ScreenOrientation(ScreenOrientation.Type.fromString(screenOrientationType.get()), angle));
116119
}
117120
tools.sendCommand(Emulation.setDeviceMetricsOverride(width, height, deviceScaleFactor, mobile, Optional.empty(), Optional.empty(), Optional.empty(),
118-
Optional.empty(), Optional.empty(), Optional.empty(), screenOrientation, Optional.empty()));
121+
Optional.empty(), Optional.empty(), Optional.empty(), screenOrientation, Optional.empty(), Optional.empty(), Optional.empty()));
119122
}
120123

121124
/**

src/main/java/aquality/selenium/browser/devtools/JavaScriptHandling.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@
1212
import org.openqa.selenium.devtools.idealized.Javascript;
1313
import org.openqa.selenium.devtools.idealized.ScriptId;
1414
import org.openqa.selenium.devtools.idealized.target.model.SessionID;
15-
import org.openqa.selenium.devtools.v85.page.Page;
16-
import org.openqa.selenium.devtools.v85.page.model.ScriptIdentifier;
17-
import org.openqa.selenium.devtools.v85.runtime.Runtime;
15+
import org.openqa.selenium.devtools.v137.page.Page;
16+
import org.openqa.selenium.devtools.v137.page.model.ScriptIdentifier;
17+
import org.openqa.selenium.devtools.v137.runtime.Runtime;
1818
import org.openqa.selenium.logging.EventType;
1919
import org.openqa.selenium.logging.HasLogEvents;
2020
import org.openqa.selenium.remote.Augmenter;
@@ -55,7 +55,7 @@ public JavaScriptHandling(DevToolsHandling tools) {
5555
public void addScriptCallbackBinding(String scriptName) {
5656
logger.info("loc.browser.javascript.scriptcallbackbinding.add", scriptName);
5757
bindings.add(scriptName);
58-
tools.sendCommand(Runtime.addBinding(scriptName, Optional.empty()));
58+
tools.sendCommand(Runtime.addBinding(scriptName, Optional.empty(), Optional.empty()));
5959
}
6060

6161
/**

src/main/java/aquality/selenium/browser/devtools/NetworkHandling.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import org.openqa.selenium.UsernameAndPassword;
99
import org.openqa.selenium.devtools.NetworkInterceptor;
1010
import org.openqa.selenium.devtools.idealized.Network;
11-
import org.openqa.selenium.devtools.v85.network.model.*;
11+
import org.openqa.selenium.devtools.v137.network.model.*;
1212
import org.openqa.selenium.remote.http.*;
1313

1414
import java.net.URI;
@@ -22,11 +22,11 @@
2222

2323
import static aquality.selenium.browser.AqualityServices.getBrowser;
2424
import static aquality.selenium.logging.LocalizedLoggerUtility.logByLevel;
25-
import static org.openqa.selenium.devtools.v85.network.Network.*;
25+
import static org.openqa.selenium.devtools.v137.network.Network.*;
2626

2727
/**
2828
* DevTools commands for version-independent network interception.
29-
* For more information, see {@link org.openqa.selenium.devtools.v85.network.Network} and {@link Network}.
29+
* For more information, see {@link org.openqa.selenium.devtools.v137.network.Network} and {@link Network}.
3030
*/
3131
public class NetworkHandling {
3232
public static final String LOC_NETWORK_INTERCEPTOR_START = "loc.browser.network.interceptor.start";
@@ -199,7 +199,7 @@ private Consumer<ResponseReceived> getResponseLogger(HttpExchangeLoggingOptions
199199
formatHeaders(response.getHeaders()));
200200
}
201201
if (loggingOptions.getResponseBody().isEnabled()) {
202-
String responseBody = tools.sendCommand(org.openqa.selenium.devtools.v85.network.Network.getResponseBody(requestId)).getBody();
202+
String responseBody = tools.sendCommand(org.openqa.selenium.devtools.v137.network.Network.getResponseBody(requestId)).getBody();
203203
if (StringUtils.isNotEmpty(responseBody)) {
204204
logByLevel(loggingOptions.getResponseBody().getLogLevel(),
205205
"loc.browser.network.event.responsereceived.log.body",
@@ -323,7 +323,8 @@ public void clearNetworkInterceptor() {
323323
*/
324324
public void emulateConditions(Boolean offline, Number latency, Number downloadThroughput, Number uploadThroughput) {
325325
tools.sendCommand(enable(Optional.empty(), Optional.empty(), Optional.empty()));
326-
tools.sendCommand(emulateNetworkConditions(offline, latency, downloadThroughput, uploadThroughput, Optional.empty()));
326+
tools.sendCommand(emulateNetworkConditions(offline, latency, downloadThroughput, uploadThroughput, Optional.empty(),
327+
Optional.empty(), Optional.empty(), Optional.empty()));
327328
}
328329

329330
/**
@@ -339,6 +340,6 @@ public void emulateConditions(Boolean offline, Number latency, Number downloadTh
339340
public void emulateConditions(Boolean offline, Number latency, Number downloadThroughput, Number uploadThroughput, String connectionType) {
340341
tools.sendCommand(enable(Optional.empty(), Optional.empty(), Optional.empty()));
341342
tools.sendCommand(emulateNetworkConditions(offline, latency, downloadThroughput, uploadThroughput,
342-
Optional.of(ConnectionType.fromString(connectionType))));
343+
Optional.of(ConnectionType.fromString(connectionType)), Optional.empty(), Optional.empty(), Optional.empty()));
343344
}
344345
}

src/test/java/tests/usecases/devtools/DeviceEmulationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
import aquality.selenium.browser.AqualityServices;
44
import aquality.selenium.browser.devtools.EmulationHandling;
55
import com.google.common.collect.ImmutableMap;
6-
import org.openqa.selenium.devtools.v132.emulation.Emulation;
7-
import org.openqa.selenium.devtools.v132.emulation.model.DisplayFeature;
6+
import org.openqa.selenium.devtools.v137.emulation.Emulation;
7+
import org.openqa.selenium.devtools.v137.emulation.model.DisplayFeature;
88
import org.testng.Assert;
99
import org.testng.annotations.BeforeMethod;
1010
import org.testng.annotations.Test;

src/test/java/tests/usecases/devtools/NetworkSpeedEmulationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import aquality.selenium.browser.AqualityServices;
44
import org.openqa.selenium.TimeoutException;
5-
import org.openqa.selenium.devtools.v132.network.model.ConnectionType;
5+
import org.openqa.selenium.devtools.v137.network.model.ConnectionType;
66
import org.testng.Assert;
77
import org.testng.annotations.Test;
88
import tests.BaseTest;

src/test/java/tests/usecases/devtools/OverrideUserAgentTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import manytools.BrowserLanguageForm;
99
import manytools.UserAgentForm;
1010
import org.openqa.selenium.devtools.idealized.Network;
11-
import org.openqa.selenium.devtools.v132.emulation.Emulation;
11+
import org.openqa.selenium.devtools.v137.emulation.Emulation;
1212
import org.testng.Assert;
1313
import org.testng.annotations.BeforeMethod;
1414
import org.testng.annotations.Test;

0 commit comments

Comments
 (0)