Update package version and make code fixes

Author: mialeska

README.md

@@ -22,7 +22,7 @@ Alternatively, you can follow the steps below:
 <dependency>
     <groupId>com.github.aquality-automation</groupId>
     <artifactId>aquality-selenium</artifactId>
-    <version>3.x.x</version>
+    <version>4.x.x</version>
 </dependency>
 ```
 

pom.xml

@@ -6,7 +6,7 @@
 
     <groupId>com.github.aquality-automation</groupId>
     <artifactId>aquality-selenium</artifactId>
-    <version>3.2.1</version>
+    <version>4.0.0</version>
     <packaging>jar</packaging>
     <name>Aquality Selenium</name>
     <description>Library around Selenium WebDriver</description>
@@ -87,13 +87,13 @@
         <dependency>
             <groupId>io.github.bonigarcia</groupId>
             <artifactId>webdrivermanager</artifactId>
-            <version>5.3.1</version>
+            <version>5.3.2</version>
         </dependency>
 
         <dependency>
             <groupId>com.fasterxml.jackson.core</groupId>
             <artifactId>jackson-databind</artifactId>
-            <version>2.14.1</version>
+            <version>2.14.2</version>
         </dependency>
 
         <dependency>

src/main/java/aquality/selenium/configuration/TimeoutConfiguration.java

@@ -37,7 +37,7 @@ private enum TIMEOUT {
         SCRIPT("timeoutScript"),
         PAGE_LOAD("timeoutPageLoad");
 
-        private String key;
+        private final String key;
 
         TIMEOUT(String key) {
             this.key = key;

src/main/java/aquality/selenium/elements/ElementType.java

@@ -11,13 +11,14 @@ public enum ElementType {
     RADIOBUTTON(IRadioButton.class),
     TEXTBOX(ITextBox.class);
 
-    private Class<? extends IElement> clazz;
+    private final Class<? extends IElement> clazz;
 
     <T extends IElement> ElementType(Class<T> clazz){
         this.clazz = clazz;
     }
 
     public <T extends IElement> Class<T> getClazz() {
+        //noinspection unchecked
         return (Class<T>) clazz;
     }
 }

src/test/java/aquality/selenium/logger/LoggerTests.java

@@ -33,7 +33,7 @@ public class LoggerTests {
     private File appenderFile;
 
     @BeforeMethod
-    private void addMessagesAppender() throws IOException {
+    private void addMessagesAppender() {
         appenderFile = getRandomAppenderFile();
         appender = getFileAppender(appenderFile);
         appender.start();
@@ -160,14 +160,13 @@ public void testErrorMessageShouldBeDisplayedAccordingToLogLevel() throws IOExce
         assertTrue(isFileContainsText(appenderFile, testMessage));
     }
 
-    private Appender getFileAppender(File file) throws IOException {
-        Layout layout = PatternLayout.newBuilder().withPattern("%m%n").build();
-        FileAppender fileAppender = FileAppender.newBuilder().setName("test")
+    private Appender getFileAppender(File file) {
+        Layout<String> layout = PatternLayout.newBuilder().withPattern("%m%n").build();
+        return FileAppender.newBuilder().setName("test")
                 .setLayout(layout)
                 .withFileName(file.getPath())
                 .withAppend(true)
                 .build();
-        return fileAppender;
     }
 
     private boolean isFileContainsText(File file, String line) throws IOException {

src/test/java/tests/usecases/BrowserFactoryTests.java

@@ -30,6 +30,7 @@
 import java.time.Duration;
 import java.util.Arrays;
 import java.util.Comparator;
+import java.util.List;
 import java.util.stream.Stream;
 
 public class BrowserFactoryTests {
@@ -53,14 +54,14 @@ private IBrowserFactory getCustomFactory() {
         return () -> {
             FirefoxSettings firefoxSettings = new FirefoxSettings(AqualityServices.get(ISettingsFile.class));
             WebDriverManager.firefoxdriver().setup();
-            FirefoxDriver driver = AqualityServices.get(IActionRetrier.class).doWithRetry(
-                    () -> new FirefoxDriver(((FirefoxOptions) firefoxSettings.getDriverOptions()).setHeadless(true)),
-                    Arrays.asList(
-                            SessionNotCreatedException.class,
-                            UnreachableBrowserException.class,
-                            WebDriverException.class,
-                            TimeoutException.class));
-
+            FirefoxOptions options = ((FirefoxOptions) firefoxSettings.getDriverOptions()).addArguments("--headless");
+            final List<Class<? extends Throwable>> handledExceptions = Arrays.asList(
+                    SessionNotCreatedException.class,
+                    UnreachableBrowserException.class,
+                    WebDriverException.class,
+                    TimeoutException.class);
+            FirefoxDriver driver = AqualityServices.get(IActionRetrier.class)
+                    .doWithRetry(() -> new FirefoxDriver(options), handledExceptions);
             return new Browser(driver);
         };
     }