Skip to content

Commit be2e188

Browse files
Merge pull request #24 from aquality-automation/feature/Local_Manager_can_see_Local_Permissions_page
Fix Permissions for CRUD Local Permissions
2 parents 5a24d66 + 6e74e2e commit be2e188

File tree

2 files changed

+14
-3
lines changed

2 files changed

+14
-3
lines changed

CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
# CHANGELOG
22

3-
## 0.3.2 (unreleased)
3+
## 0.3.3 (unreleased)
4+
5+
Bugfixes:
6+
- Local Manager can see Local Permissions page -> [View Issue](https://github.com/aquality-automation/aquality-tracking-ui/issues/22)
7+
8+
## 0.3.2 (2019-09-10)
49

510
Features:
611

src/main/java/main/controllers/Project/ProjectUserController.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public ProjectUserController(UserDto user) {
2222

2323
@Override
2424
public ProjectUserDto create(ProjectUserDto template) throws AqualityException {
25-
if(baseUser.isAdmin() || baseUser.getProjectUser(template.getProject_id()).isAdmin()){
25+
if(isEditorSession(template)){
2626
return projectUserDao.create(template);
2727
}else{
2828
throw new AqualityPermissionsException("Account is not allowed to create Project User", baseUser);
@@ -40,7 +40,7 @@ public List<ProjectUserDto> get(ProjectUserDto template) throws AqualityExceptio
4040

4141
@Override
4242
public boolean delete(ProjectUserDto template) throws AqualityException {
43-
if(baseUser.isAdmin() || baseUser.getProjectUser(template.getProject_id()).isAdmin()){
43+
if(isEditorSession(template)){
4444
return projectUserDao.delete(template);
4545
}else{
4646
throw new AqualityPermissionsException("Account is not allowed to delete Project User", baseUser);
@@ -59,4 +59,10 @@ private List<ProjectUserDto> fillProjectUsers(List<ProjectUserDto> projectUsers)
5959
}
6060
return projectUsers;
6161
}
62+
63+
private boolean isEditorSession(ProjectUserDto template){
64+
return baseUser.isAdmin() || baseUser.isManager()
65+
|| baseUser.getProjectUser(template.getProject_id()).isAdmin()
66+
|| baseUser.getProjectUser(template.getProject_id()).isManager();
67+
}
6268
}

0 commit comments

Comments
 (0)