Skip to content

Commit cf33a0b

Browse files
Fixes for Get test by issue Id Controller Permissions and for Test Issue servlet query params reader
1 parent e9335e2 commit cf33a0b

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/main/java/main/controllers/Project/ResultResolutionController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public List<ResultResolutionDto> get(ResultResolutionDto template) throws Aquali
3333

3434
@Override
3535
public boolean delete(ResultResolutionDto template) throws AqualityException {
36-
if (baseUser.isAdmin()) {
36+
if (baseUser.isAdmin() || baseUser.isManager() || baseUser.getProjectUser(template.getProject_id()).isAdmin() || baseUser.getProjectUser(template.getProject_id()).isManager()) {
3737
return resultResolutionDao.delete(template);
3838
} else {
3939
throw new AqualityPermissionsException("Account is not allowed to delete Result Resolution", baseUser);

src/main/java/main/view/Project/TestIssueServlet.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public void doGet(HttpServletRequest req, HttpServletResponse resp) {
2424

2525
Session session = createSession(req);
2626
Integer issueId = getIntegerQueryParameter(req, "issueId");
27-
Integer projectId = getIntegerQueryParameter(req, "issueId");
27+
Integer projectId = getIntegerQueryParameter(req, "projectId");
2828
validateGet(issueId, projectId);
2929
List<TestDto> tests = session.controllerFactory.getHandler(new TestDto()).get(issueId, projectId);
3030
setResponseBody(resp, tests);

0 commit comments

Comments
 (0)