Fix pages related to resolutions

Author: VladislavKostyukevich

src/app/elements/charts/resultResolutions/resultResolutions.charts.component.ts

@@ -112,15 +112,19 @@ export class ResultResolutionsChartsComponent implements OnChanges, OnInit, OnDe
     for (const resultResolution of this.listOfResultResolutions) {
       this.doughnutChartData.push(
         this.shownTestResults.filter(
-          x => x.issue.resolution.name === resultResolution.name
+          x => resultResolution.id === 1
+            ? !x.issue
+            : x.issue ? x.issue.resolution.id === resultResolution.id : false
         ).length
       );
     }
   }
 
-  calculatePrecentageAndCount(resultResolution: String): String {
+  calculatePrecentageAndCount(resultResolutionName: String): String {
     const num = this.shownTestResults.filter(
-      x => x.issue.resolution.name === resultResolution
+      x => resultResolutionName === 'Not Assigned'
+        ? !x.issue
+        : x.issue ? x.issue.resolution.name === resultResolutionName : false
     ).length;
     const percentage = (num / this.shownTestResults.length) * 100;
     return ` | ${percentage.toFixed(1)}% | ${num}`;

src/app/elements/lookup/autocomplete/lookupAutocomplete.component.html

@@ -17,6 +17,15 @@
     <div [hidden]="hidden" class="selector-suggestions cut-long-text"
         *ngIf="filteredArray && filteredArray.length > 20">
         <ul>
+            <li tabindex="0" [title]="placeholder" *ngIf="allowEmptyValue"
+                class="selector-button btn-default default-option" (keyup.enter)="select(emptyValue)"
+                (mousedown)="select(emptyValue)">{{placeholder}}</li>
+            <li tabindex="0" title="Add" *ngIf="allowCreation && !inList() "
+                class="selector-button btn-default default-option" (keyup.enter)="sendSearchText()"
+                (mousedown)="sendSearchText()">Add</li>
+            <li tabindex="0" title="Not Assigned" *ngIf="emptyForFilter"
+                class="selector-button btn-default default-option" (keyup.enter)="select(emptyValueForFilter)"
+                (mousedown)="select(emptyValueForFilter)">Not Assigned</li>
             <li tabindex="0" class="selector-button btn-default default-option wrap-text"
                 title="To many items. Type something to search.">To many items. Type something to search.</li>
         </ul>

src/app/pages/project/milestone/view-milestone/view-milestone.component.ts

@@ -21,6 +21,8 @@ import { TFColumn, TFColumnType, TFOrder } from '../../../../elements/table/tfCo
 import { Subscription } from 'rxjs/Subscription';
 import { PermissionsService, ELocalPermissions, EGlobalPermissions } from '../../../../services/current-permissions.service';
 import { faExclamationTriangle } from '@fortawesome/free-solid-svg-icons';
+import { Issue } from '../../../../shared/models/issue';
+import { IssueService } from '../../../../services/issue.service';
 
 @Component({
   templateUrl: './view-milestone.component.html',
@@ -39,7 +41,8 @@ export class ViewMilestoneComponent implements OnInit, OnDestroy {
     private suitesService: TestSuiteService,
     private testRunService: TestRunService,
     private transformationsService: TransformationsService,
-    private permissions: PermissionsService
+    private permissions: PermissionsService,
+    private issueService: IssueService
   ) { }
 
   @ViewChild(ResultResolutionsChartsComponent) resultResolutionsChart: ResultResolutionsChartsComponent;
@@ -49,6 +52,7 @@ export class ViewMilestoneComponent implements OnInit, OnDestroy {
   resolutions: ResultResolution[];
   finalResults: FinalResult[];
   testRuns: TestRun[];
+  issues: Issue[];
   resultsToShow: TestResult[];
   latestResults: TestResult[];
   suites: TestSuite[];
@@ -91,7 +95,8 @@ export class ViewMilestoneComponent implements OnInit, OnDestroy {
       this.resolutions,
       this.finalResults,
       this.latestResults,
-      this.tests
+      this.tests,
+      this.issues
     ] = await this.getInitialInfo();
 
     this.columns = this.getColumns();
@@ -119,7 +124,8 @@ export class ViewMilestoneComponent implements OnInit, OnDestroy {
       this.resultResolutionService.getResolution(this.milestone.project_id).toPromise(),
       this.finalResultService.getFinalResult({}),
       this.milestoneService.getMilestoneResults(this.milestone),
-      this.testService.getTest({ project_id: this.milestone.project_id })
+      this.testService.getTest({ project_id: this.milestone.project_id }),
+      this.issueService.getIssues({ project_id: this.milestone.project_id })
     ]);
   }
 
@@ -172,10 +178,13 @@ export class ViewMilestoneComponent implements OnInit, OnDestroy {
   }
 
   resolutionChartClick(resolution: ResultResolution) {
+    const queryParams = resolution.id === 1
+      ? { 'f_result.issue_opt': 'null' }
+      : { 'f_result.issue.resolution_opt': resolution.id };
+
     this.router.navigate(
       [`/project/${this.milestone.project_id}/milestone/${this.milestone.id}`],
-      { queryParams: { 'f_result.test_resolution_opt': resolution.id } }
-    );
+      { queryParams });
   }
 
   async updateMilestone() {
@@ -233,7 +242,6 @@ export class ViewMilestoneComponent implements OnInit, OnDestroy {
   private getNotExecutedResult(): TestResult {
     return {
       final_result: this.finalResults.find(x => x.id === 3),
-      issue: { resolution: this.resolutions.find(x => x.id === 1) },
       start_date: undefined
     };
   }
@@ -286,7 +294,18 @@ export class ViewMilestoneComponent implements OnInit, OnDestroy {
         },
         class: 'fit'
       },
-      { name: 'Issue', property: 'result.issue.title', filter: true, type: TFColumnType.text, class: 'ft-width-150' },
+      {
+        name: 'Issue',
+        property: 'result.issue.title',
+        filter: true,
+        type: TFColumnType.autocomplete,
+        lookup: {
+          entity: 'result.issue',
+          values: this.issues,
+          propToShow: ['title']
+        },
+        class: 'ft-width-150'
+      },
       { name: 'Finished', property: 'result.finish_date', filter: true, sorting: true, type: TFColumnType.date, class: 'fit' }
     ];
   }

src/app/pages/project/results/results-grid/results.grid.component.ts

@@ -273,6 +273,7 @@ export class ResultGridComponent implements OnInit {
         sorting: false,
         type: TFColumnType.autocomplete,
         editable: this.canEdit,
+        nullFilter: true,
         lookup: {
           allowCreation: true,
           allowEmpty: true,

src/app/pages/project/results/results-searcher/results.searcher.component.ts

@@ -103,7 +103,7 @@ export class ResultSearcherComponent {
         },
         class: 'fit'
       },
-      { name: 'Comment', property: 'comment', filter: true, type: TFColumnType.text, class: 'ft-width-250' }
+      { name: 'Issue', property: 'issue.title', filter: true, type: TFColumnType.text, class: 'ft-width-250' }
     ];
     if (this.failReasonSearch.length > 150) {
       this.failReasonSearch = this.failReasonSearch.slice(0, 150);

src/app/pages/project/testrun/testrun-list/testruns.component.ts

@@ -160,7 +160,7 @@ export class TestRunsComponent implements OnInit {
       },
       { name: 'Total', property: 'totalTests', sorting: true, type: TFColumnType.text, class: 'fit' },
       {
-        name: 'No Resolution',
+        name: 'No Issue',
         property: 'not_assigned',
         filter: true,
         sorting: true,
@@ -169,7 +169,7 @@ export class TestRunsComponent implements OnInit {
         link: {
           template: `/project/${this.route.snapshot.params.projectId}/testrun/{id}`,
           properties: ['id'],
-          params: { f_test_resolution_opt: 1 }
+          params: { f_issue_opt: 'null' }
         },
         class: 'ft-width-250'
       },

src/app/pages/project/testrun/testrun-view/testrun.view.component.ts

@@ -168,9 +168,13 @@ export class TestRunViewComponent implements OnInit {
   }
 
   resolutionChartClick(resolution: ResultResolution) {
+    const queryParams = resolution.id === 1
+      ? { 'f_issue_opt': 'null' }
+      : { 'f_issue.resolution_opt': resolution.id };
+
     this.router.navigate(
       [`/project/${this.projectId}/testrun/${this.testRun.id}`],
-      { queryParams: { f_test_resolution_opt: resolution.id } });
+      { queryParams });
   }
 
   canFinish() {