Skip to content

Commit 1ce7bc7

Browse files
Merge branch 'feature/refactor_permissions_service' into bugfix/date_filter_on_testrun_view
2 parents 0c569c5 + f37402a commit 1ce7bc7

File tree

4 files changed

+3
-4
lines changed

4 files changed

+3
-4
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949
command: |
5050
export NVM_DIR="/opt/circleci/.nvm"
5151
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
52-
export TESTRUNID="$(npm run aquality:start -- ${TOKEN} All Docker_Chrome build_${CIRCLE_BUILD_NUM})"
52+
export TESTRUNID="$(npm run aquality:start -- ${TOKEN} All Docker_Chrome build_${CIRCLE_BUILD_NUM}_${CIRCLE_BRANCH})"
5353
export TESTRUNID=${TESTRUNID##*$'\n'}
5454
echo $TESTRUNID
5555
echo "export TESTRUNID=$TESTRUNID" >> $BASH_ENV

src/app/pages/audit/audit-view/audit.info.component.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ export class AuditInfoComponent implements OnInit {
9696

9797
async updateCanEdit() {
9898
this.canEdit = this.isAuditAdmin || this.isAuditorOfAudit() && this.audit.status.id !== 4;
99-
console.log(this.canEdit)
10099
}
101100

102101
isAuditorOfAudit() {

src/app/pages/project/results/results-grid/results.grid.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ export class ResultGridComponent implements OnInit {
210210
const queryParam = {};
211211
queryParam['selectedResult'] = testResultId;
212212
this.router.navigate([], { queryParams: queryParam, queryParamsHandling: 'merge' }).then(() => {
213-
this.router.navigate(['/project/' + this.projectId + '/testresult/' + testResultId]);
213+
this.router.navigate([`/project/${this.projectId}/testresult/${testResultId}`]);
214214
});
215215
}
216216

src/app/pages/project/testrun/testrun-view/testrun.view.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export class TestRunViewComponent implements OnInit {
6060
&& await this.permissions.hasProjectPermissions(this.projectId,
6161
[EGlobalPermissions.manager], [ELocalPermissions.manager, ELocalPermissions.admin, ELocalPermissions.engineer]);
6262
this.canEdit = await this.permissions.hasProjectPermissions(this.projectId,
63-
[EGlobalPermissions.manager], [ELocalPermissions.manager, ELocalPermissions.engineer]);
63+
[EGlobalPermissions.manager], [ELocalPermissions.manager, ELocalPermissions.admin, ELocalPermissions.engineer]);
6464

6565
this.testRun = (await this.testRunService.getTestRunWithChilds({ id: this.route.snapshot.params.testRunId }))[0];
6666
this.milestones = await this.milestoneService.getMilestone({ project_id: this.projectId });

0 commit comments

Comments
 (0)