Merge pull request #168 from aquality-automation/hotfixes

Hotfixes

Author: aPavar

CHANGELOG.md

@@ -1,5 +1,18 @@
 # CHANGELOG
 
+## 1.4.5
+ - onlyWithIssues parameter is added for testrunstatistic for issues page
+
+## 1.4.4 (2024-10-04)
+  fixed issues:
+  aquality-automation/aquality-tracking#145
+  aquality-automation/aquality-tracking#144
+  aquality-automation/aquality-tracking#143
+  aquality-automation/aquality-tracking#142
+  aquality-automation/aquality-tracking#140
+  aquality-automation/aquality-tracking#136
+  aquality-automation/aquality-tracking#102
+
 ## 1.4.3 (2023-07-10)
  - Changed the logic of the Affected Tests Amount column on the Issues List page, so it is adaptive to the filtering in the Test Runs column now
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "aquality-tracking-ui",
-  "version": "1.4.3",
+  "version": "1.4.5",
   "scripts": {
     "ng": "ng",
     "start": "ng serve",

src/app/elements/lookup/attachment-modal/attachment-modal.component.html

@@ -21,7 +21,7 @@ <h6 class="modal-sub-title col-sm-8">{{subTitle}}</h6>
                     </div>
                     <div class="col-sm-4 line-margin">
                         <div class="col-sm-12 btnGroup">
-                            <button *ngFor="let attach of testResultAttachments" (click)="showAttachment(attach)"
+                            <button *ngFor="let attach of sortedTestResultAttachmentsById" (click)="showAttachment(attach)"
                                 [class.selected]="attach === selectedTestResultAttachment"
                                 class="btn btn-group-item bg-light">{{attach['name']}}</button>
                         </div>

src/app/elements/lookup/attachment-modal/attachment-modal.component.ts

@@ -24,6 +24,8 @@ export class AttachmentModalComponent implements OnChanges {
   selectedTestResultAttachment: TestResultAttachment;
   supportedPreviewTypes = ['text', 'image', 'message'];
   icon = faFile;
+  private readonly maxFileSizeBytes = 10 * 1024 * 1024;
+  private readonly base64SizeMultiplier = 4 / 3;
 
   constructor(private sanitizer: DomSanitizer, private testResultService: TestResultService) {
   }
@@ -35,6 +37,10 @@ export class AttachmentModalComponent implements OnChanges {
     }
   }
 
+  get sortedTestResultAttachmentsById(): TestResultAttachment[] {
+    return this.testResultAttachments?.sort((a, b) => a.id - b.id) || [];
+  }
+
   isSupportedPreviewFileType(): boolean {
     let isSupported = false;
     this.supportedPreviewTypes.forEach(type => {
@@ -48,7 +54,16 @@ export class AttachmentModalComponent implements OnChanges {
   }
 
   isSupportedPreviewFileSize(): boolean {
-    return this.testResultAttachment.attachment.toString().length / 1024 / 1024 < 5;
+    let attachmentSize = 0;
+  
+    if (typeof this.testResultAttachment?.attachment === 'string') {
+      const base64Length = this.testResultAttachment.attachment.length;
+      attachmentSize = base64Length / this.base64SizeMultiplier;
+    } else if (this.testResultAttachment?.attachment instanceof ArrayBuffer) {
+      attachmentSize = this.testResultAttachment.attachment.byteLength;
+    }
+  
+    return attachmentSize <= this.maxFileSizeBytes;
   }
 
   getNotSupportedMessage(): string {
@@ -57,7 +72,7 @@ export class AttachmentModalComponent implements OnChanges {
       message = 'Preview is not available for this file type.';
     }
     if (!this.isSupportedPreviewFileSize()) {
-      message = 'Preview is not available, the file size should be less than 5Mb.';
+      message = 'Preview is not available, the file size should be less than 10MB.';
     } else { message = 'Preview is not available for the file.'; }
     return `${message} You can download the file.`;
   }

src/app/elements/table-filter/table-filter.component.ts

@@ -61,6 +61,7 @@ export class TableFilterComponent implements OnInit, AfterViewInit, OnDestroy, O
   @Input() allowBulkUpdate = false;
   @Input() allowBulkDelete = false;
   @Input() withSelector = false;
+  @Input() urlGenerator!: (entity: any) => string;
 
   @Output() createEntity = new EventEmitter();
   @Output() dataChange = new EventEmitter();
@@ -727,13 +728,19 @@ export class TableFilterComponent implements OnInit, AfterViewInit, OnDestroy, O
       col.type !== TFColumnType.externalLink &&
       col.type !== TFColumnType.longtext &&
       col.type !== TFColumnType.autocomplete &&
+      col.type !== TFColumnType.attachmentModals &&
       !col.link;
     const notEditable = !col.editable || this.notEditableByProperty(entity, col) || el.classList.contains('ft-cell');
 
     const canClick = notInlineEditorButton || (notClickableElement && notEditable);
 
     if (canClick) {
-      this.rowClick.emit(entity);
+      if (typeof this.urlGenerator == 'function' && ($event.ctrlKey || $event.metaKey)) {
+        const url = this.urlGenerator(entity);
+        window.open(`/#${url}`, '_blank');
+      } else {
+        this.rowClick.emit(entity);
+      }
     }
   }
 

src/app/pages/administration/global/users/administration.users.component.html

@@ -1,5 +1,7 @@
 <app-modal *ngIf="tbCols && !hideModal" [title]="removeModalTitle" [message]="removeModalMessage" [type]="'warning'" [buttons]="[{name:'yes', execute:true }, {name:'no', execute:false}]"
     (execute)="execute($event)" (closed)="wasClosed()">
 </app-modal>
-<table-filter id="users-table" *ngIf="tbCols" [data]="users" [queryParams]="true" [columns]="tbCols" [hide]="hideVal" (rowClick)="rowClicked($event)" (customEvent)="resetPassword()" [allowCreate]="true" [allowDelete]="true" (dataChange)="updateUser($event)"
-    (action)="handleAction($event)" (createEntity)="createEntityChange($event)"></table-filter>
+<table-filter id="users-table" *ngIf="tbCols" [data]="users" [queryParams]="true" [columns]="tbCols" [hide]="hideVal"
+    (rowClick)="rowClicked($event)" (customEvent)="resetPassword()" [allowCreate]="true"
+    [allowDelete]="true" (dataChange)="updateUser($event)" (action)="handleAction($event)"
+    (createEntity)="createEntityChange($event)"></table-filter>

src/app/pages/audit/audit-list/audit.component.html

@@ -22,5 +22,5 @@ <h2>Audits Dashboard</h2>
 </div>
 <div *ngIf="stats && auditors && columns && services" class="col-sm-12 no-padding">
   <table-filter [data]="stats" [rowColors]="rowColors" [columns]="columns" [defaultSortBy]="defSort"
-    [queryParams]="true" (rowClick)="rowClicked($event)" rowsOnPage="20"></table-filter>
+    [queryParams]="true" [urlGenerator]="generateAuditUrl" (rowClick)="rowClicked($event)" rowsOnPage="20"></table-filter>
 </div>

src/app/pages/audit/audit-list/audit.component.ts

@@ -98,8 +98,12 @@ export class AuditComponent implements OnInit {
     BlobUtils.download(result.blob, filename);
   }
 
-  rowClicked($event) {
-    this.router.navigate([`/audit/${$event.id}`]);
+  generateAuditUrl(entity: AuditStat) {
+    return`/audit/${entity.id}`;
+  }
+
+  rowClicked($event: AuditStat) {
+    this.router.navigate([this.generateAuditUrl($event)]);
   }
 
   createColumns() {

src/app/pages/customer/customer-list/customer.component.html

@@ -13,6 +13,6 @@ <h2>Customers Dashboard</h2>
 
 <div class="col-sm-12 no-padding">
   <table-filter *ngIf="customers && columns" [data]="customers" [columns]="columns" [defaultSortBy]="defSort"
-    (action)="handleAction($event)" [allowDelete]="allowCreate" [queryParams]="true" (rowClick)="rowClicked($event)"
-    rowsOnPage="20"></table-filter>
+    (action)="handleAction($event)" [allowDelete]="allowCreate" [queryParams]="true" [urlGenerator]="generateCustomerUrl"
+    (rowClick)="rowClicked($event)" rowsOnPage="20"></table-filter>
 </div>

src/app/pages/customer/customer-list/customer.component.ts

@@ -62,8 +62,12 @@ export class CustomerComponent implements OnInit {
         ];
     }
 
-    rowClicked($event) {
-        this.router.navigate([`/customer/${$event.id}`]);
+    generateCustomerUrl(entity: Customer) {
+        return`/customer/${entity.id}`;
+    }
+
+    rowClicked($event: Customer) {
+        this.router.navigate([this.generateCustomerUrl($event)]);
     }
 
     handleAction($event) {