Skip to content

Commit 8c5efbc

Browse files
added ctrl+click to open in new tab to table filter and test run list
1 parent 7fe7d0b commit 8c5efbc

File tree

4 files changed

+15
-4
lines changed

4 files changed

+15
-4
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "aquality-tracking-ui",
3-
"version": "1.4.3",
3+
"version": "1.4.4",
44
"scripts": {
55
"ng": "ng",
66
"start": "ng serve",

src/app/elements/table-filter/table-filter.component.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ export class TableFilterComponent implements OnInit, AfterViewInit, OnDestroy, O
6161
@Input() allowBulkUpdate = false;
6262
@Input() allowBulkDelete = false;
6363
@Input() withSelector = false;
64+
@Input() urlGenerator!: (entity: any) => string;
6465

6566
@Output() createEntity = new EventEmitter();
6667
@Output() dataChange = new EventEmitter();
@@ -733,7 +734,12 @@ export class TableFilterComponent implements OnInit, AfterViewInit, OnDestroy, O
733734
const canClick = notInlineEditorButton || (notClickableElement && notEditable);
734735

735736
if (canClick) {
736-
this.rowClick.emit(entity);
737+
if ($event.ctrlKey || $event.metaKey) {
738+
const url = this.urlGenerator(entity);
739+
window.open(`/#${url}`, '_blank');
740+
} else {
741+
this.rowClick.emit(entity);
742+
}
737743
}
738744
}
739745

src/app/pages/project/testrun/testrun-list/testrun-list.component.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@
1515
<div class="col-sm-12">
1616
<table-filter #testrunsTable *ngIf="tbCols && labels" [allowDelete]="allowDelete" [allowBulkDelete]="allowDelete" (bulkDelete)="bulkDelete($event)"
1717
[allowExport]="true" [data]="testruns" (shownData)="tableDataUpdate($event)" [columns]="tbCols" [hiddenColumns]="hiddenCols" [defaultSortBy]="sortBy"
18-
[queryParams]="true" (rowClick)="rowClicked($event)" (dataChange)="testrunUpdate($event)" (action)="handleAction($event)"></table-filter>
18+
[queryParams]="true" [urlGenerator]="generateRowUrl" (rowClick)="rowClicked($event)" (dataChange)="testrunUpdate($event)"
19+
(action)="handleAction($event)"></table-filter>
1920
</div>
2021
</div>
2122
</div>

src/app/pages/project/testrun/testrun-list/testrun-list.component.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,12 @@ export class TestRunsComponent implements OnInit {
8787
this.testrunStatsFiltered = this.testrunStats.filter(stat => $event.find(testrun => testrun.id === stat.id));
8888
}
8989

90+
generateRowUrl(entity: TestRun): string {
91+
return `/project/${entity.project_id}/testrun/${entity.id}`
92+
}
93+
9094
rowClicked($event: TestRun) {
91-
this.router.navigate([`/project/${$event.project_id}/testrun/${$event.id}`]);
95+
this.router.navigate([this.generateRowUrl($event)]);
9296
}
9397

9498
bulkDelete(testruns: TestRun[]) {

0 commit comments

Comments
 (0)