Do not require debug-cluster for showing logs on quickly failing servers

ewoutp · ewoutp · commit 4eebe22b2f64 · 2018-04-20T15:05:43.000+02:00
diff --git a/service/runtime_server_manager.go b/service/runtime_server_manager.go
@@ -339,7 +339,7 @@ func (s *runtimeServerManager) runServer(ctx context.Context, log *logging.Logge
 			if isRecentFailure && !s.stopping {
 				if !portInUse {
 					log.Infof("%s has terminated quickly, in %s (recent failures: %d)", serverType, uptime, recentFailures)
-					if recentFailures >= minRecentFailuresForLog && config.DebugCluster {
+					if recentFailures >= minRecentFailuresForLog {
 						// Show logs of the server
 						s.showRecentLogs(log, runtimeContext, serverType)
 					}

Original file line number	Diff line number	Diff line change
`@@ -339,7 +339,7 @@ func (s runtimeServerManager) runServer(ctx context.Context, log logging.Logge`
`339`	`339`	`if isRecentFailure && !s.stopping {`
`340`	`340`	`if !portInUse {`
`341`	`341`	`log.Infof("%s has terminated quickly, in %s (recent failures: %d)", serverType, uptime, recentFailures)`
`342`		`- if recentFailures >= minRecentFailuresForLog && config.DebugCluster {`
	`342`	`+ if recentFailures >= minRecentFailuresForLog {`
`343`	`343`	`// Show logs of the server`
`344`	`344`	`s.showRecentLogs(log, runtimeContext, serverType)`
`345`	`345`	`}`