Added arangodb upgrade command

Author: ewoutp

main.go

@@ -462,7 +462,8 @@ func cmdShowVersionRun(cmd *cobra.Command, args []string) {
 
 func cmdMainRun(cmd *cobra.Command, args []string) {
 	// Setup log level
-	configureLogging()
+	consoleOnly := false
+	configureLogging(consoleOnly)
 
 	log.Info().Msgf("Starting %s version %s, build %s", projectName, projectVersion, projectBuild)
 
@@ -495,12 +496,12 @@ func cmdMainRun(cmd *cobra.Command, args []string) {
 }
 
 // configureLogging configures the log object according to command line arguments.
-func configureLogging() {
+func configureLogging(consoleOnly bool) {
 	logOpts := logging.LoggerOutputOptions{
 		Stderr: logOutput.Console,
 		Color:  logOutput.Color,
 	}
-	if logOutput.File {
+	if logOutput.File && !consoleOnly {
 		if logDir != "" {
 			logOpts.LogFile = filepath.Join(logDir, logFileName)
 		} else {

start.go

@@ -56,7 +56,8 @@ func init() {
 
 func cmdStartRun(cmd *cobra.Command, args []string) {
 	// Setup logging
-	configureLogging()
+	consoleOnly := true
+	configureLogging(consoleOnly)
 
 	log.Info().Msgf("Starting %s version %s, build %s in the background", projectName, projectVersion, projectBuild)
 

stop.go

@@ -46,7 +46,8 @@ func init() {
 
 func cmdStopRun(cmd *cobra.Command, args []string) {
 	// Setup logging
-	configureLogging()
+	consoleOnly := true
+	configureLogging(consoleOnly)
 
 	// Create starter client
 	scheme := "http"

upgrade.go

@@ -0,0 +1,131 @@
+//
+// DISCLAIMER
+//
+// Copyright 2018 ArangoDB GmbH, Cologne, Germany
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+// Copyright holder is ArangoDB GmbH, Cologne, Germany
+//
+// Author Ewout Prangsma
+//
+
+package main
+
+import (
+	"context"
+	"fmt"
+	"net/url"
+	"sort"
+	"strings"
+	"time"
+
+	"github.com/spf13/cobra"
+
+	"github.com/arangodb-helper/arangodb/client"
+)
+
+var (
+	cmdUpgrade = &cobra.Command{
+		Use:   "upgrade",
+		Short: "Start the ArangoDB starter in the background",
+		Run:   cmdUpgradeRun,
+	}
+	upgradeOptions struct {
+		starterEndpoint string
+	}
+)
+
+func init() {
+	f := cmdUpgrade.Flags()
+	f.StringVar(&upgradeOptions.starterEndpoint, "starter.endpoint", "", "The endpoint of the starter to connect to. E.g. http://localhost:8528")
+
+	cmdMain.AddCommand(cmdUpgrade)
+}
+
+func cmdUpgradeRun(cmd *cobra.Command, args []string) {
+	// Setup logging
+	consoleOnly := true
+	configureLogging(consoleOnly)
+
+	// Check options
+	if upgradeOptions.starterEndpoint == "" {
+		log.Fatal().Msg("--starter.endpoint must be set")
+	}
+	ep, err := url.Parse(upgradeOptions.starterEndpoint)
+	if err != nil {
+		log.Fatal().Err(err).Msg("--starter.endpoint is invalid")
+	}
+
+	// Create starter client
+	c, err := client.NewArangoStarterClient(*ep)
+	if err != nil {
+		log.Fatal().Err(err).Msg("Failed to create Starter client")
+	}
+	ctx := context.Background()
+	force := false
+	if err := c.StartDatabaseUpgrade(ctx, force); err != nil {
+		log.Fatal().Err(err).Msg("Failed to starter database automatic upgrade")
+	}
+	log.Info().Msg("Database automatic upgrade has been started")
+
+	// Wait for the upgrade to finish
+	remaining := ""
+	finished := ""
+	for {
+		status, err := c.UpgradeStatus(ctx)
+		if err != nil {
+			log.Error().Err(err).Msg("Failed to fetch upgrade status")
+		}
+		if status.Failed {
+			log.Error().Str("reason", status.Reason).Msg("Database upgrade has failed")
+			return
+		}
+		if status.Ready {
+			log.Info().Msg("Database upgrade has finished")
+			return
+		}
+		r, f := formatServerStatusList(status.ServersRemaining), formatServerStatusList(status.ServersUpgraded)
+		if remaining != r || finished != f {
+			remaining, finished = r, f
+			log.Info().Msgf("Servers upgraded: %s, remaining servers: %s", finished, remaining)
+		}
+		time.Sleep(time.Second)
+	}
+}
+
+// formatServerStatusList formats the given server status list in a human readable format.
+func formatServerStatusList(list []client.UpgradeStatusServer) string {
+	counts := make(map[client.ServerType]int)
+	for _, e := range list {
+		counts[e.Type] = counts[e.Type] + 1
+	}
+	if len(counts) == 0 {
+		return "none"
+	}
+	strList := make([]string, 0, len(counts))
+	for t, c := range counts {
+		name := string(t)
+		if c > 1 {
+			name = name + "s"
+		}
+		strList = append(strList, fmt.Sprintf("%d %s", c, name))
+	}
+	sort.Slice(strList, func(i, j int) bool {
+		// Sort past the number
+		a := strings.Split(strList[i], " ")[1]
+		b := strings.Split(strList[j], " ")[1]
+		return a < b
+	})
+	return strings.Join(strList, ", ")
+}