skip getLogsOffset tests in 3.9 (#436)

Author: rashtao

src/test/java/com/arangodb/ArangoDBTest.java

@@ -456,7 +456,8 @@ void getLogsSize(ArangoDB arangoDB) {
     @ParameterizedTest(name = "{index}")
     @MethodSource("arangos")
     void getLogsOffset(ArangoDB arangoDB) {
-        assumeTrue(isAtLeastVersion(3, 7)); // it fails in 3.6 active-failover (BTS-362)
+        assumeTrue(isAtLeastVersion(3, 7));  // it fails in 3.6 active-failover (BTS-362)
+        assumeTrue(isLessThanVersion(3, 9)); // deprecated
         final LogEntity logs = arangoDB.getLogs(null);
         assertThat(logs.getTotalAmount()).isPositive();
         final LogEntity logsOffset = arangoDB.getLogs(new LogOptions().offset(1));

src/test/java/com/arangodb/BaseJunit5.java

@@ -101,6 +101,14 @@ boolean isAtLeastVersion(final int major, final int minor, final int patch) {
         return TestUtils.isAtLeastVersion(adbs.get(0).getVersion().getVersion(), major, minor, patch);
     }
 
+    boolean isLessThanVersion(final int major, final int minor) {
+        return isLessThanVersion(major, minor, 0);
+    }
+
+    boolean isLessThanVersion(final int major, final int minor, final int patch) {
+        return TestUtils.isLessThanVersion(adbs.get(0).getVersion().getVersion(), major, minor, patch);
+    }
+
     boolean isStorageEngine(ArangoDBEngine.StorageEngineName name) {
         return name.equals(adbs.get(0).getEngine().getName());
     }

src/test/java/com/arangodb/async/ArangoDBTest.java

@@ -71,6 +71,10 @@ private boolean isAtLeastVersion(final int major, final int minor) {
         return com.arangodb.util.TestUtils.isAtLeastVersion(arangoDBSync.getVersion().getVersion(), major, minor, 0);
     }
 
+    private boolean isLessThanVersion(final int major, final int minor) {
+        return com.arangodb.util.TestUtils.isLessThanVersion(arangoDBSync.getVersion().getVersion(), major, minor, 0);
+    }
+
     private boolean supportsExtendedNames() {
         final ArangoDB arangoDB = new ArangoDB.Builder().serializer(new ArangoJack()).build();
         if (extendedNames == null) {
@@ -525,7 +529,8 @@ void getLogsSize() throws InterruptedException, ExecutionException {
 
     @Test
     void getLogsOffset() throws InterruptedException, ExecutionException {
-        assumeTrue(isAtLeastVersion(3, 7)); // it fails in 3.6 active-failover (BTS-362)
+        assumeTrue(isAtLeastVersion(3, 7));  // it fails in 3.6 active-failover (BTS-362)
+        assumeTrue(isLessThanVersion(3, 9)); // deprecated
         final LogEntity logs = arangoDB.getLogs(null).get();
         assertThat(logs.getTotalAmount()).isPositive();
         arangoDB.getLogs(new LogOptions().offset((int) (logs.getTotalAmount() - 1)))

src/test/java/com/arangodb/util/TestUtils.java

@@ -42,13 +42,21 @@ private TestUtils() {
      * Parses {@param version} and checks whether it is greater or equal to
      * <{@param otherMajor}, {@param otherMinor}, {@param otherPatch}>
      * comparing the corresponding version components in lexicographical order.
-     *
-     * @param version
-     * @param otherMajor
-     * @param otherMinor
-     * @param otherPatch
      */
     public static boolean isAtLeastVersion(final String version, final int otherMajor, final int otherMinor, final int otherPatch) {
+        return compareVersion(version, otherMajor, otherMinor, otherPatch) >= 0;
+    }
+
+    /**
+     * Parses {@param version} and checks whether it is less than
+     * <{@param otherMajor}, {@param otherMinor}, {@param otherPatch}>
+     * comparing the corresponding version components in lexicographical order.
+     */
+    public static boolean isLessThanVersion(final String version, final int otherMajor, final int otherMinor, final int otherPatch) {
+        return compareVersion(version, otherMajor, otherMinor, otherPatch) < 0;
+    }
+
+    private static int compareVersion(final String version, final int otherMajor, final int otherMinor, final int otherPatch) {
         String[] parts = version.split("-")[0].split("\\.");
 
         int major = Integer.parseInt(parts[0]);
@@ -57,20 +65,15 @@ public static boolean isAtLeastVersion(final String version, final int otherMajo
 
         int majorComparison = Integer.compare(major, otherMajor);
         if (majorComparison != 0) {
-            return majorComparison > 0;
+            return majorComparison;
         }
 
         int minorComparison = Integer.compare(minor, otherMinor);
         if (minorComparison != 0) {
-            return minorComparison > 0;
-        }
-
-        int patchComparison = Integer.compare(patch, otherPatch);
-        if (patchComparison != 0) {
-            return patchComparison > 0;
+            return minorComparison;
         }
 
-        return true;
+        return Integer.compare(patch, otherPatch);
     }
 
     private static String[] generateAllInputChars() {
@@ -90,7 +93,7 @@ private static String[] generateAllInputChars() {
     }
 
     public static String generateRandomDbName(int length, boolean extendedNames) {
-        if(extendedNames){
+        if (extendedNames) {
             int max = allChars.length;
             StringBuilder sb = new StringBuilder();
             for (int i = 0; i < length; i++) {