bugfix allowImplicit in streaming transactions

Author: rashtao

ChangeLog.md

@@ -6,6 +6,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) a
 
 ## [Unreleased]
 
+- bugfix `allowImplicit` parameter in stream transactions
+- added `peakMemoryUsage` to aql statistics
+
 ## [6.6.1] - 2020-03-18
 
 - GraalVM Native Image support

src/main/java/com/arangodb/model/StreamTransactionOptions.java

@@ -32,6 +32,7 @@ public class StreamTransactionOptions {
     private Integer lockTimeout;
     private Boolean waitForSync;
     private Long maxTransactionSize;
+    private Boolean allowImplicit;
 
     public StreamTransactionOptions() {
         super();
@@ -94,16 +95,16 @@ public StreamTransactionOptions exclusiveCollections(final String... exclusive)
         return this;
     }
 
+    public Boolean getAllowImplicit() {
+        return allowImplicit;
+    }
+
     /**
-     * @param allowImplicit Collections that will be written to in the transaction must be declared with the write attribute or it
-     *                      will fail, whereas non-declared collections from which is solely read will be added lazily. The
-     *                      optional attribute allowImplicit can be set to false to let transactions fail in case of undeclared
-     *                      collections for reading. Collections for reading should be fully declared if possible, to avoid
-     *                      deadlocks.
+     * @param allowImplicit Allow reading from undeclared collections.
      * @return options
      */
     public StreamTransactionOptions allowImplicit(final Boolean allowImplicit) {
-        collections.allowImplicit(allowImplicit);
+        this.allowImplicit = allowImplicit;
         return this;
     }
 

src/test/java/com/arangodb/StreamTransactionTest.java

@@ -34,7 +34,7 @@
 import static org.hamcrest.CoreMatchers.notNullValue;
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.*;
-
+import static org.junit.Assert.fail;
 import static org.junit.Assume.assumeTrue;
 
 /**
@@ -717,4 +717,30 @@ public void getStreamTransactions() {
         db.abortStreamTransaction(tx2.getId());
     }
 
+    @Test
+    public void transactionAllowImplicitFalse() {
+        assumeTrue(isSingleServer());
+        assumeTrue(isAtLeastVersion(3, 5));
+        assumeTrue(isStorageEngine(ArangoDBEngine.StorageEngineName.rocksdb));
+
+        StreamTransactionEntity tx = db
+                .beginStreamTransaction(new StreamTransactionOptions().allowImplicit(false));
+
+        // insert a document from outside the tx
+        DocumentCreateEntity<BaseDocument> externalDoc = collection
+                .insertDocument(new BaseDocument(), null);
+
+        // assert that we cannot read from collection
+        try {
+            collection.getDocument(externalDoc.getKey(), BaseDocument.class,
+                    new DocumentReadOptions().streamTransactionId(tx.getId()));
+            fail();
+        } catch (ArangoDBException e) {
+            assertThat(e.getResponseCode(), is(400));
+            assertThat(e.getErrorNum(), is(1652));
+            assertThat(e.getMessage(), containsString("unregistered collection used in transaction"));
+        }
+
+        db.abortStreamTransaction(tx.getId());
+    }
 }