rm automatic type inference in:

- ArangoCollection.insertDocuments(),
- ArangoCollection.replaceDocuments(),
- ArangoCollection.updateDocuments(),
- ArangoCollection.deleteDocuments()

Author: rashtao

core/src/main/java/com/arangodb/ArangoCollection.java

@@ -134,8 +134,8 @@ MultiDocumentEntity<DocumentCreateEntity<RawData>> insertDocuments(
      * @see <a href="https://www.arangodb.com/docs/stable/http/document-working-with-documents.html#create-document">API
      * Documentation</a>
      */
-    <T> MultiDocumentEntity<DocumentCreateEntity<T>> insertDocuments(
-            Collection<T> values, DocumentCreateOptions options);
+    MultiDocumentEntity<DocumentCreateEntity<Void>> insertDocuments(
+            Collection<?> values, DocumentCreateOptions options);
 
     /**
      * Creates new documents from the given documents, unless there is already a document with the _key given. If no
@@ -318,8 +318,8 @@ MultiDocumentEntity<DocumentUpdateEntity<RawData>> replaceDocuments(
      * <a href="https://www.arangodb.com/docs/stable/http/document-working-with-documents.html#replace-documents">API
      * Documentation</a>
      */
-    <T> MultiDocumentEntity<DocumentUpdateEntity<T>> replaceDocuments(
-            Collection<T> values, DocumentReplaceOptions options);
+    MultiDocumentEntity<DocumentUpdateEntity<Void>> replaceDocuments(
+            Collection<?> values, DocumentReplaceOptions options);
 
     /**
      * Replaces multiple documents in the specified collection with the ones in the values, the replaced documents are
@@ -436,8 +436,8 @@ MultiDocumentEntity<DocumentUpdateEntity<RawData>> updateDocuments(
      * <a href="https://www.arangodb.com/docs/stable/http/document-working-with-documents.html#update-documents">API
      * Documentation</a>
      */
-    <T> MultiDocumentEntity<DocumentUpdateEntity<T>> updateDocuments(
-            Collection<T> values, DocumentUpdateOptions options);
+    MultiDocumentEntity<DocumentUpdateEntity<Void>> updateDocuments(
+            Collection<?> values, DocumentUpdateOptions options);
 
     /**
      * Partially updates documents, the documents to update are specified by the _key attributes in the objects on
@@ -537,7 +537,7 @@ MultiDocumentEntity<DocumentDeleteEntity<RawData>> deleteDocuments(
      * "https://www.arangodb.com/docs/stable/http/document-working-with-documents.html#removes-multiple-documents">API
      * Documentation</a>
      */
-    <T> MultiDocumentEntity<DocumentDeleteEntity<T>> deleteDocuments(
+    MultiDocumentEntity<DocumentDeleteEntity<Void>> deleteDocuments(
             Collection<?> values, DocumentDeleteOptions options);
 
     /**

core/src/main/java/com/arangodb/internal/ArangoCollectionImpl.java

@@ -83,16 +83,15 @@ public MultiDocumentEntity<DocumentCreateEntity<RawData>> insertDocuments(RawDat
 
     @Override
     public MultiDocumentEntity<DocumentCreateEntity<Void>> insertDocuments(final Collection<?> values) {
-        return executor
-                .execute(insertDocumentsRequest(values, new DocumentCreateOptions()),
-                        insertDocumentsResponseDeserializer(Void.class));
+        return insertDocuments(values, new DocumentCreateOptions());
     }
 
     @Override
-    @SuppressWarnings("unchecked")
-    public <T> MultiDocumentEntity<DocumentCreateEntity<T>> insertDocuments(
-            final Collection<T> values, final DocumentCreateOptions options) {
-        return insertDocuments(values, options, (Class<T>) getCollectionContentClass(values));
+    public MultiDocumentEntity<DocumentCreateEntity<Void>> insertDocuments(
+            final Collection<?> values, final DocumentCreateOptions options) {
+        return executor
+                .execute(insertDocumentsRequest(values, options),
+                        insertDocumentsResponseDeserializer(Void.class));
     }
 
     @Override
@@ -198,15 +197,14 @@ public MultiDocumentEntity<DocumentUpdateEntity<RawData>> replaceDocuments(RawDa
 
     @Override
     public MultiDocumentEntity<DocumentUpdateEntity<Void>> replaceDocuments(final Collection<?> values) {
-        return executor.execute(replaceDocumentsRequest(values, new DocumentReplaceOptions()),
-                replaceDocumentsResponseDeserializer(Void.class));
+        return replaceDocuments(values, new DocumentReplaceOptions());
     }
 
     @Override
-    @SuppressWarnings("unchecked")
-    public <T> MultiDocumentEntity<DocumentUpdateEntity<T>> replaceDocuments(
-            final Collection<T> values, final DocumentReplaceOptions options) {
-        return replaceDocuments(values, options, (Class<T>) getCollectionContentClass(values));
+    public MultiDocumentEntity<DocumentUpdateEntity<Void>> replaceDocuments(
+            final Collection<?> values, final DocumentReplaceOptions options) {
+        return executor.execute(replaceDocumentsRequest(values, options),
+                replaceDocumentsResponseDeserializer(Void.class));
     }
 
     @Override
@@ -253,14 +251,13 @@ public MultiDocumentEntity<DocumentUpdateEntity<RawData>> updateDocuments(RawDat
 
     @Override
     public MultiDocumentEntity<DocumentUpdateEntity<Void>> updateDocuments(final Collection<?> values) {
-        return updateDocuments(values, new DocumentUpdateOptions(), Void.class);
+        return updateDocuments(values, new DocumentUpdateOptions());
     }
 
     @Override
-    @SuppressWarnings("unchecked")
-    public <T> MultiDocumentEntity<DocumentUpdateEntity<T>> updateDocuments(
-            final Collection<T> values, final DocumentUpdateOptions options) {
-        return updateDocuments(values, options, (Class<T>) getCollectionContentClass(values));
+    public MultiDocumentEntity<DocumentUpdateEntity<Void>> updateDocuments(
+            final Collection<?> values, final DocumentUpdateOptions options) {
+        return updateDocuments(values, options, Void.class);
     }
 
     @Override
@@ -303,14 +300,13 @@ public MultiDocumentEntity<DocumentDeleteEntity<RawData>> deleteDocuments(RawDat
 
     @Override
     public MultiDocumentEntity<DocumentDeleteEntity<Void>> deleteDocuments(final Collection<?> values) {
-        return deleteDocuments(values, new DocumentDeleteOptions(), Void.class);
+        return deleteDocuments(values, new DocumentDeleteOptions());
     }
 
     @Override
-    @SuppressWarnings("unchecked")
-    public <T> MultiDocumentEntity<DocumentDeleteEntity<T>> deleteDocuments(
+    public MultiDocumentEntity<DocumentDeleteEntity<Void>> deleteDocuments(
             final Collection<?> values, final DocumentDeleteOptions options) {
-        return deleteDocuments(values, options, (Class<T>) getCollectionContentClass(values));
+        return deleteDocuments(values, options, Void.class);
     }
 
     @Override

core/src/main/java/com/arangodb/internal/InternalArangoCollection.java

@@ -575,15 +575,4 @@ protected ResponseDeserializer<Permissions> getPermissionsResponseDeserialzer()
                 Permissions.class);
     }
 
-    protected Class<?> getCollectionContentClass(Collection<?> c) {
-        if (c == null || c.isEmpty()) {
-            return null;
-        }
-        Object v = c.iterator().next();
-        if (v == null) {
-            return null;
-        }
-        return v.getClass();
-    }
-
 }

driver/src/test/java/com/arangodb/ArangoCollectionTest.java

@@ -389,7 +389,7 @@ void insertDocumentsSilent(ArangoCollection collection) {
         assumeTrue(isSingleServer());
         final MultiDocumentEntity<DocumentCreateEntity<BaseDocument>> info =
     collection.insertDocuments(Arrays.asList(new BaseDocument(), new BaseDocument()),
-new DocumentCreateOptions().silent(true));
+new DocumentCreateOptions().silent(true), BaseDocument.class);
         assertThat(info).isNotNull();
         assertThat(info.getDocuments()).isEmpty();
         assertThat(info.getDocumentsAndErrors()).isEmpty();
@@ -899,7 +899,7 @@ void updateDocumentsSilent(ArangoCollection collection) {
         final DocumentCreateEntity<?> createResult = collection.insertDocument(new BaseDocument());
         final MultiDocumentEntity<DocumentUpdateEntity<BaseDocument>> info =
 collection.updateDocuments(Collections.singletonList(new BaseDocument(createResult.getKey())),
-          new DocumentUpdateOptions().silent(true));
+          new DocumentUpdateOptions().silent(true), BaseDocument.class);
         assertThat(info).isNotNull();
         assertThat(info.getDocuments()).isEmpty();
         assertThat(info.getDocumentsAndErrors()).isEmpty();
@@ -1111,7 +1111,7 @@ void replaceDocumentsSilent(ArangoCollection collection) {
         final DocumentCreateEntity<?> createResult = collection.insertDocument(new BaseDocument());
         final MultiDocumentEntity<DocumentUpdateEntity<BaseDocument>> info =
  collection.replaceDocuments(Collections.singletonList(new BaseDocument(createResult.getKey())),
-    new DocumentReplaceOptions().silent(true));
+    new DocumentReplaceOptions().silent(true), BaseDocument.class);
         assertThat(info).isNotNull();
         assertThat(info.getDocuments()).isEmpty();
         assertThat(info.getDocumentsAndErrors()).isEmpty();
@@ -1827,7 +1827,7 @@ void insertDocumentsOverwriteModeUpdate(ArangoCollection collection) {
 
         final MultiDocumentEntity<DocumentCreateEntity<BaseDocument>> repsert =
          collection.insertDocuments(Arrays.asList(doc1, doc2),
-          new DocumentCreateOptions().overwriteMode(OverwriteMode.update).returnNew(true));
+          new DocumentCreateOptions().overwriteMode(OverwriteMode.update).returnNew(true), BaseDocument.class);
         assertThat(repsert).isNotNull();
         assertThat(repsert.getDocuments()).hasSize(2);
         assertThat(repsert.getErrors()).isEmpty();
@@ -1924,7 +1924,7 @@ void insertDocumentsReturnNew(ArangoCollection collection) {
         values.add(new BaseDocument());
         final DocumentCreateOptions options = new DocumentCreateOptions().returnNew(true);
         final MultiDocumentEntity<DocumentCreateEntity<BaseDocument>> docs = collection.insertDocuments(values,
- options);
+ options, BaseDocument.class);
         assertThat(docs).isNotNull();
         assertThat(docs.getDocuments()).isNotNull();
         assertThat(docs.getDocuments()).hasSize(3);

driver/src/test/java/com/arangodb/StreamTransactionTest.java

@@ -351,7 +351,7 @@ void insertDocuments(ArangoDatabase db) {
         // insert documents from within the tx
         MultiDocumentEntity<DocumentCreateEntity<BaseDocument>> txDocs = collection
                 .insertDocuments(Arrays.asList(new BaseDocument(), new BaseDocument(), new BaseDocument()),
-                        new DocumentCreateOptions().streamTransactionId(tx.getId()));
+                        new DocumentCreateOptions().streamTransactionId(tx.getId()), BaseDocument.class);
 
         List<String> keys = txDocs.getDocuments().stream().map(DocumentEntity::getKey).collect(Collectors.toList());
 
@@ -418,7 +418,7 @@ void replaceDocuments(ArangoDatabase db) {
 
         ArangoCollection collection = db.collection(COLLECTION_NAME);
         List<BaseDocument> createdDocs = collection
-                .insertDocuments(docs, new DocumentCreateOptions().returnNew(true)).getDocuments().stream()
+                .insertDocuments(docs, new DocumentCreateOptions().returnNew(true), BaseDocument.class).getDocuments().stream()
                 .map(DocumentCreateEntity::getNew).collect(Collectors.toList());
 
         List<String> keys = createdDocs.stream().map(BaseDocument::getKey).collect(Collectors.toList());
@@ -503,7 +503,7 @@ void updateDocuments(ArangoDatabase db) {
 
         ArangoCollection collection = db.collection(COLLECTION_NAME);
         List<BaseDocument> createdDocs = collection
-                .insertDocuments(docs, new DocumentCreateOptions().returnNew(true)).getDocuments().stream()
+                .insertDocuments(docs, new DocumentCreateOptions().returnNew(true), BaseDocument.class).getDocuments().stream()
                 .map(DocumentCreateEntity::getNew).collect(Collectors.toList());
 
         List<String> keys = createdDocs.stream().map(BaseDocument::getKey).collect(Collectors.toList());