fixed ArangoView.rename() thread safety

Author: rashtao

core/src/main/java/com/arangodb/internal/ArangoCollectionImpl.java

@@ -465,7 +465,7 @@ public CollectionPropertiesEntity changeProperties(final CollectionPropertiesOpt
     }
 
     @Override
-    public synchronized CollectionEntity rename(final String newName) {
+    public CollectionEntity rename(final String newName) {
         return executor.execute(renameRequest(newName), CollectionEntity.class);
     }
 

core/src/main/java/com/arangodb/internal/ArangoSearchImpl.java

@@ -56,10 +56,8 @@ public void drop() {
     }
 
     @Override
-    public synchronized ViewEntity rename(final String newName) {
-        final ViewEntity result = executor.execute(renameRequest(newName), ViewEntity.class);
-        name = result.getName();
-        return result;
+    public ViewEntity rename(final String newName) {
+        return executor.execute(renameRequest(newName), ViewEntity.class);
     }
 
     @Override

core/src/main/java/com/arangodb/internal/ArangoViewImpl.java

@@ -53,10 +53,8 @@ public void drop() {
     }
 
     @Override
-    public synchronized ViewEntity rename(final String newName) {
-        final ViewEntity result = executor.execute(renameRequest(newName), ViewEntity.class);
-        name = result.getName();
-        return result;
+    public ViewEntity rename(final String newName) {
+        return executor.execute(renameRequest(newName), ViewEntity.class);
     }
 
     @Override

core/src/main/java/com/arangodb/internal/InternalArangoView.java

@@ -35,7 +35,7 @@ public abstract class InternalArangoView<A extends InternalArangoDB<E>, D extend
     protected static final String PATH_API_ANALYZER = "/_api/analyzer";
 
     protected final D db;
-    protected volatile String name;
+    protected final String name;
 
     protected InternalArangoView(final D db, final String name) {
         super(db.executor, db.serde);

core/src/main/java/com/arangodb/internal/SearchAliasImpl.java

@@ -56,10 +56,8 @@ public void drop() {
     }
 
     @Override
-    public synchronized ViewEntity rename(final String newName) {
-        final ViewEntity result = executor.execute(renameRequest(newName), ViewEntity.class);
-        name = result.getName();
-        return result;
+    public ViewEntity rename(final String newName) {
+        return executor.execute(renameRequest(newName), ViewEntity.class);
     }
 
     @Override

docs/v7_detailed_changes.md

@@ -342,9 +342,11 @@ The class `com.arangodb.DbName` has been removed. The database names can now be
 Support to unicode characters in data definition names (databases, collections, views, indexes) has been added, see
 [Support to unicode data definition names](v7_java.md#unicode-characters-in-data-definition-names).
 
-`com.arangodb.ArangoCollection.rename(String)` does not change anymore the collection name of the instance
-of `ArangoCollection` on which it is invoked. To interact with the renamed collection, a new instance
-of `ArangoCollection` with the new name must be created.
+The name of `ArangoCollection` and `ArangoView` API classes are now final. The related rename methods:
+- `com.arangodb.ArangoCollection.rename(String)`
+- `com.arangodb.ArangoView.rename(String)`
+do not change anymore the collection or view name of the instance of the related API class on which it is invoked. 
+To interact with the renamed collection, a new instance of `ArangoCollection` with the new name must be created.
 
 ## API entities