Use URLSearchParams

Author: pluma

CHANGELOG.md

@@ -26,6 +26,12 @@ This driver uses semantic versioning:
   Any names used when creating/ensuring indexes or passed to any methods that
   expect an `IndexSelector` will automatically be NFC normalized.
 
+- Internal querystring handling logic now uses `URLSearchParams` instead of
+  node `querystring` module
+
+  This change should be backwards compatible but may produce different results
+  when relying on undefined behavior in custom (e.g. Foxx) routes.
+
 ## [8.1.0] - 2022-12-19
 
 ### Added

src/lib/querystringify.ts

@@ -1,16 +1,14 @@
-import { ParsedUrlQueryInput, stringify } from "querystring";
-
-// eslint-disable-next-line @typescript-eslint/ban-types
-function clean<T extends {}>(obj: T) {
-  const result = {} as typeof obj;
-  for (const key of Object.keys(obj)) {
-    const value = (obj as any)[key];
+export function querystringify(obj: Record<string, any>) {
+  const params = new URLSearchParams();
+  for (const [key, value] of Object.entries(obj)) {
     if (value === undefined) continue;
-    (result as any)[key] = value;
+    if (!Array.isArray(value)) {
+      params.append(key, value);
+    } else {
+      for (const item of value) {
+        params.append(key, item);
+      }
+    }
   }
-  return result;
-}
-
-export function querystringify(obj: ParsedUrlQueryInput) {
-  return stringify(clean(obj));
+  return String(params);
 }