Skip to content

Commit 3a21d5a

Browse files
author
mpv1989
committed
Fix collection functions missing return values
* Fixed `collection.removeByKeys(keys, options)` missing return value * Fixed `collection.replaceByExample(example, newValue, opts)` missing return value * Fixed `collection.updateByExample(example, newValue, opts)` missing return value
1 parent 91ec3f5 commit 3a21d5a

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
1010
### Fixed
1111

1212
* Fixed `collection.update(documentHandle, newValue, opts)` missing return value
13+
* Fixed `collection.removeByKeys(keys, options)` missing return value
14+
* Fixed `collection.replaceByExample(example, newValue, opts)` missing return value
15+
* Fixed `collection.updateByExample(example, newValue, opts)` missing return value
1316

1417
## [6.2.2] - 2018-03-21
1518

src/collection.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -392,7 +392,7 @@ export abstract class BaseCollection implements ArangoCollection {
392392
}
393393

394394
replaceByExample(example: any, newValue: any, opts?: any) {
395-
this._connection.request(
395+
return this._connection.request(
396396
{
397397
method: "PUT",
398398
path: "/_api/simple/replace-by-example",
@@ -408,7 +408,7 @@ export abstract class BaseCollection implements ArangoCollection {
408408
}
409409

410410
updateByExample(example: any, newValue: any, opts?: any) {
411-
this._connection.request(
411+
return this._connection.request(
412412
{
413413
method: "PUT",
414414
path: "/_api/simple/update-by-example",
@@ -438,7 +438,7 @@ export abstract class BaseCollection implements ArangoCollection {
438438
}
439439

440440
removeByKeys(keys: string[], options: any) {
441-
this._connection.request(
441+
return this._connection.request(
442442
{
443443
method: "PUT",
444444
path: "/_api/simple/remove-by-keys",

0 commit comments

Comments
 (0)