Replace Object.values with Object.keys

Author: pluma

CHANGELOG.md

@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+### Fixed
+
+* Replaced `Object.values` use to improve Node version compatibility
+
+  This allows using arangojs in Node.js 6 LTS without a polyfill.
+
 ## [6.2.1] - 2018-03-21
 
 ### Changed

package.json

@@ -47,15 +47,19 @@
     "lib/cjs/util/*.*"
   ],
   "scripts": {
-    "test": "mocha --growl --reporter spec --require source-map-support/register --require core-js/shim --timeout 10000 lib/cjs/test",
+    "test":
+      "mocha --growl --reporter spec --require source-map-support/register --timeout 10000 lib/cjs/test",
     "pretest": "yarn dist",
-    "ci": "mocha --reporter spec --require source-map-support/register --require core-js/shim --timeout 10000 lib/cjs/test",
+    "ci":
+      "mocha --reporter spec --require source-map-support/register --timeout 10000 lib/cjs/test",
     "preci": "yarn install",
     "jenkins": "yarn ci -- --timeout 0 --reporter xunit-file",
     "dist:cjs": "tsc -p . --outDir ./lib/cjs/ && cpy src/index.js lib/cjs/",
-    "dist:async": "tsc -p . --outDir ./lib/async/ --target es2017 && cpy src/index.js lib/async/",
+    "dist:async":
+      "tsc -p . --outDir ./lib/async/ --target es2017 && cpy src/index.js lib/async/",
     "dist:web": "webpack",
-    "dist": "rimraf lib && npm-run-all --parallel dist:* && cpy src/index.all.js --rename index.js lib/",
+    "dist":
+      "rimraf lib && npm-run-all --parallel dist:* && cpy src/index.all.js --rename index.js lib/",
     "prepublish": "yarn dist && node -e 'require(\".\");'"
   },
   "dependencies": {
@@ -76,7 +80,6 @@
     "babel-plugin-transform-object-rest-spread": "^6.26.0",
     "babel-preset-env": "^1.6.1",
     "chai": "^4.0.2",
-    "core-js": "^2.4.1",
     "cpy-cli": "^1.0.1",
     "eslint": "^4.13.0",
     "eslint-config-prettier": "^2.9.0",
@@ -92,4 +95,4 @@
     "webpack": "^3.0.0",
     "xunit-file": "1.0.0"
   }
-}
+}

src/database.ts

@@ -422,7 +422,10 @@ export class Database {
       },
       res => res.body
     );
-    if (!minimal || !Object.values(result).every((value: any) => value.title))
+    if (
+      !minimal ||
+      !Object.keys(result).every((key: string) => result[key].title)
+    )
       return result;
     const values: any = {};
     for (const key of Object.keys(result)) {
@@ -448,7 +451,9 @@ export class Database {
     if (
       minimal ||
       !result.values ||
-      !Object.values(result.values).every((value: any) => value.title)
+      !Object.keys(result.values).every(
+        (key: string) => result.values[key].title
+      )
     ) {
       return result;
     }
@@ -478,7 +483,9 @@ export class Database {
     if (
       minimal ||
       !result.values ||
-      !Object.values(result.values).every((value: any) => value.title)
+      !Object.keys(result.values).every(
+        (key: string) => result.values[key].title
+      )
     ) {
       return result;
     }
@@ -499,7 +506,10 @@ export class Database {
       },
       res => res.body
     );
-    if (!minimal || !Object.values(result).every((value: any) => value.title))
+    if (
+      !minimal ||
+      !Object.keys(result).every((key: string) => result[key].title)
+    )
       return result;
     const values: any = {};
     for (const key of Object.keys(result)) {
@@ -525,7 +535,9 @@ export class Database {
     if (
       minimal ||
       !result.values ||
-      !Object.values(result.values).every((value: any) => value.title)
+      !Object.keys(result.values).every(
+        (key: string) => result.values[key].title
+      )
     ) {
       return result;
     }
@@ -555,7 +567,9 @@ export class Database {
     if (
       minimal ||
       !result.values ||
-      !Object.values(result.values).every((value: any) => value.title)
+      !Object.keys(result.values).every(
+        (key: string) => result.values[key].title
+      )
     ) {
       return result;
     }

yarn.lock

@@ -1105,7 +1105,7 @@ convert-source-map@^1.5.0:
   version "1.5.1"
   resolved "https://registry.yarnpkg.com/convert-source-map/-/convert-source-map-1.5.1.tgz#b8278097b9bc229365de5c62cf5fcaed8b5599e5"
 
-core-js@^2.4.0, core-js@^2.4.1, core-js@^2.5.0:
+core-js@^2.4.0, core-js@^2.5.0:
   version "2.5.3"
   resolved "https://registry.yarnpkg.com/core-js/-/core-js-2.5.3.tgz#8acc38345824f16d8365b7c9b4259168e8ed603e"