Fix #704

Author: pluma

CHANGELOG.md

@@ -18,7 +18,7 @@ This driver uses semantic versioning:
 
 ### Added
 
-- Implemented `toJSON` methods for `ArangoError` and `HttpError`
+- Implemented `toJSON` methods for `ArangoError` and `HttpError` ([#632](https://github.com/arangodb/arangojs/issues/632))
 
   This prevents an error where `JSON.stringify` would reliably throw if passed
   an instance of either of these error types generated by arangojs. Note that
@@ -27,7 +27,7 @@ This driver uses semantic versioning:
 
 ### Fixed
 
-- Stack traces are now improved for most errors when using `precaptureStackTraces`
+- Stack traces are now improved for most errors when using `precaptureStackTraces` ([#722](https://github.com/arangodb/arangojs/issues/722))
 
   Previously this option would only affect network errors, making it far less
   useful than intended. Now parsing errors, `ArangoError` instances and HTTP
@@ -40,6 +40,12 @@ This driver uses semantic versioning:
   be accessed prior to the request being sent, causing a noticeable delay even
   when no error occurs.
 
+- Fixed document selector validation in `collection.edges` and its variants ([#704](https://github.com/arangodb/arangojs/issues/704))
+
+  These methods previously only permitted start vertices that are documents
+  within the edge collection itself. This behavior has now been corrected to
+  permit start vertices outside the collection, as expected.
+
 ## [7.3.0] - 2021-03-08
 
 ### Changed

src/collection.ts

@@ -3629,7 +3629,7 @@ export class Collection<T extends object = any>
         path: `/_api/edges/${this._name}`,
         qs: {
           direction,
-          vertex: _documentHandle(selector, this._name),
+          vertex: _documentHandle(selector, this._name, false),
         },
       },
       (res) => res.body

src/documents.ts

@@ -112,7 +112,8 @@ export type DocumentSelector = ObjectWithId | ObjectWithKey | string;
  */
 export function _documentHandle(
   selector: DocumentSelector,
-  collectionName: string
+  collectionName: string,
+  strict: boolean = true
 ): string {
   if (typeof selector !== "string") {
     if (selector._id) {
@@ -126,7 +127,7 @@ export function _documentHandle(
     );
   }
   if (selector.includes("/")) {
-    if (!selector.startsWith(`${collectionName}/`)) {
+    if (strict && !selector.startsWith(`${collectionName}/`)) {
       throw new Error(
         `Document ID "${selector}" does not match collection name "${collectionName}"`
       );