Fix TypeError in res.host

Fixes #604.

Author: pluma

CHANGELOG.md

@@ -11,6 +11,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 - Fixed view properties not being passed correctly when creating views ([#621](https://github.com/arangodb/arangojs/issues/621))
 
+- Renamed internal `response.host` attribute to `response.arangojsHostId` ([#604](https://github.com/arangodb/arangojs/pull/604))
+
+  In some environments the `host` attribute is already present and read-only.
+  This should avoid a `TypeError` being thrown when a value is assigned by
+  arangojs.
+
 ## [6.11.0] - 2019-08-16
 
 ### Changed

src/collection.ts

@@ -435,7 +435,7 @@ export abstract class BaseCollection<T extends object = any>
           collection: this.name
         }
       },
-      res => new ArrayCursor(this._connection, res.body, res.host)
+      res => new ArrayCursor(this._connection, res.body, res.arangojsHostId)
     );
   }
 
@@ -495,7 +495,7 @@ export abstract class BaseCollection<T extends object = any>
           collection: this.name
         }
       },
-      res => new ArrayCursor(this._connection, res.body, res.host)
+      res => new ArrayCursor(this._connection, res.body, res.arangojsHostId)
     );
   }
 
@@ -767,7 +767,7 @@ export abstract class BaseCollection<T extends object = any>
           collection: this.name
         }
       },
-      res => new ArrayCursor(this._connection, res.body, res.host)
+      res => new ArrayCursor(this._connection, res.body, res.arangojsHostId)
     );
   }
 }

src/connection.ts

@@ -207,7 +207,7 @@ export class Connection {
           }
           this._queue.push(task);
         } else {
-          response.host = host;
+          response.arangojsHostId = host;
           task.resolve(response);
         }
       }

src/database.ts

@@ -1,6 +1,12 @@
 import { AnalyzerDescription, ArangoAnalyzer } from "./analyzer";
 import { AqlLiteral, AqlQuery, isAqlLiteral, isAqlQuery } from "./aql-query";
-import { ArangoCollection, constructCollection, DocumentCollection, EdgeCollection, isArangoCollection } from "./collection";
+import {
+  ArangoCollection,
+  constructCollection,
+  DocumentCollection,
+  EdgeCollection,
+  isArangoCollection
+} from "./collection";
 import { Config, Connection } from "./connection";
 import { ArrayCursor } from "./cursor";
 import { isArangoError } from "./error";
@@ -503,7 +509,12 @@ export class Database {
         timeout
       },
       res =>
-        new ArrayCursor(this._connection, res.body, res.host, allowDirtyRead)
+        new ArrayCursor(
+          this._connection,
+          res.body,
+          res.arangojsHostId,
+          allowDirtyRead
+        )
     );
   }
 

src/test/99-load-balancing.ts

@@ -123,24 +123,24 @@ describeIm("Single-server with follower", function() {
   it("supports dirty reads", async () => {
     expect((conn as any)._urls).to.have.lengthOf(2);
     const res1 = await getResponse(true);
-    expect(res1.host).to.be.a("number");
+    expect(res1.arangojsHostId).to.be.a("number");
     const headers1 = res1.request.getHeaders();
     expect(headers1).to.include.keys("x-arango-allow-dirty-read");
     const res2 = await getResponse(true);
-    expect(res2.host).to.be.a("number");
-    expect(res2.host).not.to.equal(res1.host);
+    expect(res2.arangojsHostId).to.be.a("number");
+    expect(res2.arangojsHostId).not.to.equal(res1.arangojsHostId);
     const headers2 = res2.request.getHeaders();
     expect(headers2).to.include.keys("x-arango-allow-dirty-read");
   });
   it("supports non-dirty reads", async () => {
     expect((conn as any)._urls).to.have.lengthOf(2);
     const res1 = await getResponse();
-    expect(res1.host).to.be.a("number");
+    expect(res1.arangojsHostId).to.be.a("number");
     const headers1 = res1.request.getHeaders();
     expect(headers1).not.to.include.keys("x-arango-allow-dirty-read");
     const res2 = await getResponse();
-    expect(res2.host).to.be.a("number");
-    expect(res2.host).to.equal(res1.host);
+    expect(res2.arangojsHostId).to.be.a("number");
+    expect(res2.arangojsHostId).to.equal(res1.arangojsHostId);
     const headers2 = res2.request.getHeaders();
     expect(headers2).not.to.include.keys("x-arango-allow-dirty-read");
   });

src/util/request.node.ts

@@ -14,7 +14,7 @@ import { Errback } from "./types";
 export type ArangojsResponse = IncomingMessage & {
   request: ClientRequest;
   body?: any;
-  host?: number;
+  arangojsHostId?: number;
 };
 
 export type ArangojsError = Error & {