Skip to content

Commit 3652706

Browse files
authored
GT-187 Pregel test improvement (#437)
1 parent 2ee041d commit 3652706

File tree

1 file changed

+26
-12
lines changed

1 file changed

+26
-12
lines changed

test/pregel_test.go

Lines changed: 26 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,15 @@ func TestCreatePregelJob(t *testing.T) {
4242
ensureCollection(nil, db, nameVertex, &driver.CreateCollectionOptions{
4343
NumberOfShards: 4,
4444
}, t)
45-
ensureVertexCollection(ctx, g, nameVertex, t)
45+
46+
colVertex := ensureVertexCollection(ctx, g, nameVertex, t)
47+
48+
doc := UserDoc{
49+
Name: "Jan",
50+
Age: 12,
51+
}
52+
meta, err := colVertex.CreateDocument(ctx, doc)
53+
require.NoError(t, err)
4654

4755
nameEdge := "test_pregel_edge"
4856
ensureCollection(ctx, db, nameEdge, &driver.CreateCollectionOptions{
@@ -57,22 +65,28 @@ func TestCreatePregelJob(t *testing.T) {
5765
jobId, err := db.StartJob(ctx, driver.PregelJobOptions{
5866
Algorithm: driver.PregelAlgorithmPageRank,
5967
GraphName: g.Name(),
68+
Params: map[string]interface{}{
69+
"store": true,
70+
"resultField": "resultField",
71+
},
6072
})
6173
require.Nilf(t, err, "Failed to start Pregel job: %s", describe(err))
6274
require.NotEmpty(t, jobId, "JobId is empty")
6375

64-
// TOOD change me to test if job work has been done by checking changes in the collection
65-
/*waitForDataPropagation()
76+
waitForDataPropagation()
6677

67-
job, err := db.GetJob(ctx, jobId)
68-
require.Nilf(t, err, "Failed to get job: %s", describe(err))
69-
require.Equal(t, jobId, job.ID, "JobId mismatch")
70-
require.NotEmpty(t, job.Detail, "Detail is empty")
78+
type UserDocPregelResult struct {
79+
UserDoc
80+
ResultField float64 `json:"resultField"`
81+
}
7182

72-
jobs, err := db.GetJobs(ctx)
73-
require.Nilf(t, err, "Failed to get running jobs: %s", describe(err))
74-
require.Len(t, jobs, 1, "Expected 1 job, got %d", len(jobs))
83+
docResult := UserDocPregelResult{}
84+
_, err = colVertex.ReadDocument(ctx, meta.Key, &docResult)
85+
require.NoError(t, err)
86+
require.Equal(t, doc.Name, docResult.Name)
87+
require.Equal(t, doc.Age, docResult.Age)
88+
require.NotEmpty(t, docResult.ResultField)
89+
require.Greater(t, docResult.ResultField, 0.0)
7590

76-
err = db.CancelJob(ctx, jobId)
77-
require.Nilf(t, err, "Failed to cancel job: %s", describe(err))*/
91+
t.Logf("resultField value: %f", docResult.ResultField)
7892
}

0 commit comments

Comments
 (0)