Skip to content

Commit 55a2210

Browse files
committed
Fixed ConsolidationTier unit tests
1 parent 058c2a8 commit 55a2210

File tree

1 file changed

+24
-1
lines changed

1 file changed

+24
-1
lines changed

tests/index/consolidation_policy_tests.cpp

Lines changed: 24 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
/// @author Vasiliy Nabatchikov
2222
////////////////////////////////////////////////////////////////////////////////
2323

24+
#include <iostream>
2425
#include "index/composite_reader_impl.hpp"
2526
#include "index/index_meta.hpp"
2627
#include "index/index_writer.hpp"
@@ -890,7 +891,29 @@ TEST(ConsolidationTierTest, NoCandidates) {
890891

891892
irs::Consolidation candidates;
892893
policy(candidates, reader, consolidating_segments);
893-
ASSERT_TRUE(candidates.empty()); // candidates too large
894+
ASSERT_FALSE(candidates.empty());
895+
896+
// Verify that the consolidation candidate mergeScore <= 1.5
897+
898+
// Accessor function to fetch the relevant segment attributes
899+
// from the segment struct.
900+
auto getSegmentDims = [](
901+
tier::ConsolidationCandidate<irs::Consolidation::value_type>::iterator_t reader_itr,
902+
uint64_t& byte_size,
903+
uint64_t& docs_count,
904+
uint64_t& live_docs_count) {
905+
906+
auto reader = *reader_itr;
907+
auto meta = reader->Meta();
908+
909+
byte_size = meta.byte_size;
910+
docs_count = meta.docs_count;
911+
live_docs_count = meta.live_docs_count;
912+
};
913+
914+
tier::ConsolidationCandidate<irs::Consolidation::value_type> consolidation_candidate(
915+
candidates.cbegin(), candidates.cend() - 1, getSegmentDims);
916+
ASSERT_LE(consolidation_candidate.mergeScore, 1.5);
894917
}
895918

896919
TEST(ConsolidationTierTest, SkewedSegments) {

0 commit comments

Comments
 (0)