Skip to content

Commit d91b909

Browse files
committed
Fixed ConsolidationTier unit tests
1 parent 48cecc3 commit d91b909

File tree

1 file changed

+24
-1
lines changed

1 file changed

+24
-1
lines changed

tests/index/consolidation_policy_tests.cpp

Lines changed: 24 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
/// @author Vasiliy Nabatchikov
2222
////////////////////////////////////////////////////////////////////////////////
2323

24+
#include <iostream>
2425
#include "index/composite_reader_impl.hpp"
2526
#include "index/index_meta.hpp"
2627
#include "index/index_writer.hpp"
@@ -912,7 +913,29 @@ TEST(ConsolidationTierTest, NoCandidates) {
912913

913914
irs::Consolidation candidates;
914915
policy(candidates, reader, consolidating_segments);
915-
ASSERT_TRUE(candidates.empty()); // candidates too large
916+
ASSERT_FALSE(candidates.empty());
917+
918+
// Verify that the consolidation candidate mergeScore <= 1.5
919+
920+
// Accessor function to fetch the relevant segment attributes
921+
// from the segment struct.
922+
auto getSegmentDims = [](
923+
tier::ConsolidationCandidate<irs::Consolidation::value_type>::iterator_t reader_itr,
924+
uint64_t& byte_size,
925+
uint64_t& docs_count,
926+
uint64_t& live_docs_count) {
927+
928+
auto reader = *reader_itr;
929+
auto meta = reader->Meta();
930+
931+
byte_size = meta.byte_size;
932+
docs_count = meta.docs_count;
933+
live_docs_count = meta.live_docs_count;
934+
};
935+
936+
tier::ConsolidationCandidate<irs::Consolidation::value_type> consolidation_candidate(
937+
candidates.cbegin(), candidates.cend() - 1, getSegmentDims);
938+
ASSERT_LE(consolidation_candidate.mergeScore, 1.5);
916939
}
917940

918941
TEST(ConsolidationTierTest, SkewedSegments) {

0 commit comments

Comments
 (0)