Fix warnings (iresearch-toolkit#551)

* Fix unused/unreachable code

* Fix other warnings

Author: MBkkt

.clang-tidy

@@ -7,6 +7,7 @@ Checks: '*,
          -mpi-*,
          -objc-*,
          -openmp-*,
+         -fuchsia-trailing-return,
          -fuchsia-default-arguments-*,
          -fuchsia-overloaded-operator,
          -readability-identifier-length,

core/CMakeLists.txt

@@ -290,11 +290,7 @@ set(IRESEARCH_EXTERNAL_INCLUDES
   ${Fasttext_INCLUDE_DIR}
   ${FROZEN_INCLUDE_DIR})
 
-if (SUPPRESS_EXTERNAL_WARNINGS)
-  include_directories(SYSTEM ${IRESEARCH_EXTERNAL_INCLUDES})
-else ()
-  include_directories(${IRESEARCH_EXTERNAL_INCLUDES})
-endif ()
+include_directories(SYSTEM ${IRESEARCH_EXTERNAL_INCLUDES})
 
 add_library(iresearch-static
   STATIC

core/analysis/delimited_token_stream.cpp

@@ -125,8 +125,9 @@ bool parse_vpack_options(const VPackSlice slice, std::string& delimiter) {
         delimiter = delim_type_slice.stringView();
         return true;
       }
-    default: {
-    }  // fall through
+      break;
+    default:
+      break;
   }
 
   IRS_LOG_ERROR(absl::StrCat(

core/analysis/minhash_token_stream.cpp

@@ -103,7 +103,7 @@ static uint64_t HashLen0to16(const char* s, size_t len) {
     uint8_t b = s[len >> 1];
     uint8_t c = s[len - 1];
     uint32_t y = static_cast<uint32_t>(a) + (static_cast<uint32_t>(b) << 8);
-    uint32_t z = len + (static_cast<uint32_t>(c) << 2);
+    uint32_t z = static_cast<uint32_t>(len) + (static_cast<uint32_t>(c) << 2);
     return ShiftMix(y * k2 ^ z * k0) * k2;
   }
   return k2;

core/analysis/nearest_neighbors_stream.cpp

@@ -265,7 +265,7 @@ bool nearest_neighbors_stream::reset(std::string_view data) {
   std::istream ss{&buf};
 
   model_dict_->getLine(ss, line_token_ids_, line_token_label_ids_);
-  n_tokens_ = line_token_ids_.size();
+  n_tokens_ = static_cast<int32_t>(line_token_ids_.size());
   current_token_ind_ = 0;
 
   neighbors_.clear();

core/analysis/ngram_token_stream.cpp

@@ -399,8 +399,8 @@ void ngram_token_stream_base::emit_original() noexcept {
                          : EmitOriginal::WithEndMarker;
       inc.value = next_inc_val_;
       break;
-    default:
-      IRS_ASSERT(false);  // should not be called when None
+    case EmitOriginal::None:
+      IRS_ASSERT(false);
       break;
   }
   next_inc_val_ = 0;

core/analysis/segmentation_token_stream.cpp

@@ -275,9 +275,6 @@ bool accept_token(Iterator begin, Iterator end, word_break_t wb) {
       return std::find_if_not(begin, end, utf8_utils::CharIsWhiteSpace) != end;
     case word_break_t::ALPHA:
       return std::find_if(begin, end, utf8_utils::CharIsAlphanumeric) != end;
-    default:
-      IRS_ASSERT(false);
-      return false;
   }
 }
 

core/analysis/text_token_normalizing_stream.cpp

@@ -401,9 +401,9 @@ bool normalizing_token_stream::reset(std::string_view data) {
     case UPPER:
       state_->token.toUpper(state_->options.locale);  // inplace case-conversion
       break;
-    default: {
-    }  // NOOP
-  };
+    case NONE:
+      break;
+  }
 
   // collate value, e.g. remove accents
   if (state_->transliterator) {

core/analysis/text_token_stream.cpp

@@ -374,9 +374,9 @@ bool process_term(analysis::text_token_stream::state_t& state,
     case analysis::text_token_stream::UPPER:
       state.token.toUpper(state.options.locale);  // inplace case-conversion
       break;
-    default: {
-    }  // NOOP
-  };
+    case analysis::text_token_stream::NONE:
+      break;
+  }
 
   // collate value, e.g. remove accents
   if (state.transliterator) {
@@ -399,7 +399,8 @@ bool process_term(analysis::text_token_stream::state_t& state,
     const sb_symbol* value =
       reinterpret_cast<const sb_symbol*>(word_utf8.c_str());
 
-    value = sb_stemmer_stem(state.stemmer.get(), value, (int)word_utf8.size());
+    value = sb_stemmer_stem(state.stemmer.get(), value,
+                            static_cast<int>(word_utf8.size()));
 
     if (value) {
       static_assert(sizeof(byte_type) == sizeof(sb_symbol));

core/analysis/token_stream.hpp

@@ -33,7 +33,6 @@ class token_stream : public attribute_provider {
  public:
   using ptr = std::unique_ptr<token_stream>;
 
-  virtual ~token_stream() = default;
   virtual bool next() = 0;
 };