[Bugfix] Disable VersionCheck V2 by default (#1352)

Author: ajanikow

CHANGELOG.md

@@ -9,6 +9,7 @@
 - (Feature) Rebalancer V2
 - (Bugfix) Fix for ContextExceeded error during backup upload
 - (Feature) Version Check V2
+- (Bugfix) Disable VersionCheck V2 by default
 
 ## [1.2.30](https://github.com/arangodb/kube-arangodb/tree/1.2.30) (2023-06-16)
 - (Feature) AgencyCache Interface

cmd/init_container_version_check.go

@@ -58,7 +58,7 @@ func init() {
 	f.IntVar(&cmdVersionCheckInitContainersInput.minor, "minor", 0, "Minor version of the ArangoDB. 0 if check is disabled")
 }
 
-func (c cmdVersionCheckInitContainersInputStruct) Run(cmd *cobra.Command, args []string) error {
+func (c *cmdVersionCheckInitContainersInputStruct) Run(cmd *cobra.Command, args []string) error {
 	if c.versionPath == "" {
 		return errors.Errorf("Path cannot be empty")
 	}
@@ -83,6 +83,8 @@ func (c cmdVersionCheckInitContainersInputStruct) Run(cmd *cobra.Command, args [
 			}
 		}
 
+		log.Info().Msg("Version check complete")
+
 		return nil
 	}
 }

pkg/deployment/features/upgrade.go

@@ -38,7 +38,7 @@ var upgradeVersionCheckV2 Feature = &feature{
 	description:        "Enable initContainer with pre version check based by Operator",
 	version:            "3.6.0",
 	enterpriseRequired: false,
-	enabledByDefault:   true,
+	enabledByDefault:   false,
 }
 
 func UpgradeVersionCheck() Feature {