[Cleanup] Add gosimple linter (#729)

Author: informalict

Makefile

@@ -140,7 +140,7 @@ allall: all
 # Tip: Run `eval $(minikube docker-env)` before calling make if you're developing on minikube.
 #
 
-GOLANGCI_ENABLED=deadcode govet ineffassign staticcheck structcheck typecheck unconvert unparam unused varcheck
+GOLANGCI_ENABLED=deadcode gosimple govet ineffassign staticcheck structcheck typecheck unconvert unparam unused varcheck
 #GOLANGCI_ENABLED=gocyclo goconst golint maligned errcheck interfacer megacheck
 #GOLANGCI_ENABLED+=dupl - disable dupl check
 

pkg/apis/shared/errors.go

@@ -126,9 +126,7 @@ func WithErrors(errs ...error) error {
 
 		switch errType := err.(type) {
 		case MergedErrors:
-			for _, subError := range errType.errors {
-				filteredErrs = append(filteredErrs, subError)
-			}
+			filteredErrs = append(filteredErrs, errType.errors...)
 		default:
 			filteredErrs = append(filteredErrs, err)
 		}

pkg/deployment/pod/affinity.go

@@ -92,37 +92,32 @@ func MergePodAntiAffinity(a, b *core.PodAntiAffinity) {
 		return
 	}
 
-	for _, rule := range b.PreferredDuringSchedulingIgnoredDuringExecution {
-		a.PreferredDuringSchedulingIgnoredDuringExecution = append(a.PreferredDuringSchedulingIgnoredDuringExecution, rule)
-	}
+	a.PreferredDuringSchedulingIgnoredDuringExecution = append(a.PreferredDuringSchedulingIgnoredDuringExecution,
+		b.PreferredDuringSchedulingIgnoredDuringExecution...)
 
-	for _, rule := range b.RequiredDuringSchedulingIgnoredDuringExecution {
-		a.RequiredDuringSchedulingIgnoredDuringExecution = append(a.RequiredDuringSchedulingIgnoredDuringExecution, rule)
-	}
+	a.RequiredDuringSchedulingIgnoredDuringExecution = append(a.RequiredDuringSchedulingIgnoredDuringExecution,
+		b.RequiredDuringSchedulingIgnoredDuringExecution...)
 }
 
 func MergePodAffinity(a, b *core.PodAffinity) {
 	if a == nil || b == nil {
 		return
 	}
 
-	for _, rule := range b.PreferredDuringSchedulingIgnoredDuringExecution {
-		a.PreferredDuringSchedulingIgnoredDuringExecution = append(a.PreferredDuringSchedulingIgnoredDuringExecution, rule)
-	}
+	a.PreferredDuringSchedulingIgnoredDuringExecution = append(a.PreferredDuringSchedulingIgnoredDuringExecution,
+		b.PreferredDuringSchedulingIgnoredDuringExecution...)
 
-	for _, rule := range b.RequiredDuringSchedulingIgnoredDuringExecution {
-		a.RequiredDuringSchedulingIgnoredDuringExecution = append(a.RequiredDuringSchedulingIgnoredDuringExecution, rule)
-	}
+	a.RequiredDuringSchedulingIgnoredDuringExecution = append(a.RequiredDuringSchedulingIgnoredDuringExecution,
+		b.RequiredDuringSchedulingIgnoredDuringExecution...)
 }
 
 func MergeNodeAffinity(a, b *core.NodeAffinity) {
 	if a == nil || b == nil {
 		return
 	}
 
-	for _, rule := range b.PreferredDuringSchedulingIgnoredDuringExecution {
-		a.PreferredDuringSchedulingIgnoredDuringExecution = append(a.PreferredDuringSchedulingIgnoredDuringExecution, rule)
-	}
+	a.PreferredDuringSchedulingIgnoredDuringExecution = append(a.PreferredDuringSchedulingIgnoredDuringExecution,
+		b.PreferredDuringSchedulingIgnoredDuringExecution...)
 
 	var newSelectorTerms []core.NodeSelectorTerm
 

pkg/deployment/reconcile/action_bootstrap_update.go

@@ -24,7 +24,6 @@ package reconcile
 
 import (
 	"context"
-	"fmt"
 
 	api "github.com/arangodb/kube-arangodb/pkg/apis/deployment/v1"
 	"github.com/rs/zerolog"
@@ -53,8 +52,8 @@ type actionBootstrapUpdate struct {
 func (a actionBootstrapUpdate) Start(ctx context.Context) (bool, error) {
 	if err := a.actionCtx.WithStatusUpdate(ctx, func(status *api.DeploymentStatus) bool {
 		if errMessage, ok := a.action.GetParam("error"); ok {
-			status.Conditions.Update(api.ConditionTypeBootstrapCompleted, true, "Bootstrap failed", fmt.Sprintf("%s", errMessage))
-			status.Conditions.Update(api.ConditionTypeBootstrapSucceded, false, "Bootstrap failed", fmt.Sprintf("%s", errMessage))
+			status.Conditions.Update(api.ConditionTypeBootstrapCompleted, true, "Bootstrap failed", errMessage)
+			status.Conditions.Update(api.ConditionTypeBootstrapSucceded, false, "Bootstrap failed", errMessage)
 		} else {
 			status.Conditions.Update(api.ConditionTypeBootstrapCompleted, true, "Bootstrap successful", "The bootstrap process has been completed successfully")
 			status.Conditions.Update(api.ConditionTypeBootstrapSucceded, true, "Bootstrap successful", "The bootstrap process has been completed successfully")

pkg/deployment/reconcile/plan_builder_encryption.go

@@ -176,11 +176,7 @@ func createEncryptionKeyStatusUpdateRequired(log zerolog.Logger, spec api.Deploy
 
 	keyHashes := secretKeysToListWithPrefix(keyfolder)
 
-	if !util.CompareStringArray(keyHashes, status.Hashes.Encryption.Keys) {
-		return true
-	}
-
-	return false
+	return !util.CompareStringArray(keyHashes, status.Hashes.Encryption.Keys)
 }
 
 func createEncryptionKeyCleanPlan(ctx context.Context,

pkg/deployment/reconcile/plan_builder_jwt.go

@@ -183,10 +183,7 @@ func createJWTStatusUpdateRequired(log zerolog.Logger, apiObject k8sutil.APIObje
 	}
 
 	if len(f.Data) == 0 {
-		if status.Hashes.JWT.Passive != nil {
-			return true
-		}
-		return false
+		return status.Hashes.JWT.Passive != nil
 	}
 
 	var keys []string
@@ -200,20 +197,13 @@ func createJWTStatusUpdateRequired(log zerolog.Logger, apiObject k8sutil.APIObje
 	}
 
 	if len(keys) == 0 {
-		if status.Hashes.JWT.Passive != nil {
-			return true
-		}
-		return false
+		return status.Hashes.JWT.Passive != nil
 	}
 
 	sort.Strings(keys)
 	keys = util.PrefixStringArray(keys, "sha256:")
 
-	if !util.CompareStringArray(keys, status.Hashes.JWT.Passive) {
-		return true
-	}
-
-	return false
+	return !util.CompareStringArray(keys, status.Hashes.JWT.Passive)
 }
 
 func areJWTTokensUpToDate(ctx context.Context, log zerolog.Logger, status api.DeploymentStatus,

pkg/util/k8sutil/pair.go

@@ -115,10 +115,7 @@ func (o OptionPairs) Unique() OptionPairs {
 
 func (o OptionPairs) Copy() OptionPairs {
 	r := make(OptionPairs, len(o))
-
-	for id, option := range o {
-		r[id] = option
-	}
+	copy(r, o)
 
 	return r
 }