[Maintenance] Lint Protos (#1748)

Author: ajanikow

CHANGELOG.md

@@ -5,6 +5,7 @@
 - (Feature) Helm Client Support
 - (Feature) Helm Client Extension
 - (Feature) (Integration) SchedulerV2 Definition
+- (Maintenance) Proto Lint
 
 ## [1.2.43](https://github.com/arangodb/kube-arangodb/tree/1.2.43) (2024-10-14)
 - (Feature) ArangoRoute CRD

Makefile

@@ -939,6 +939,6 @@ sync-charts:
 sync: sync-charts
 
 ci-check:
-	@$(MAKE) tidy vendor generate update-generated synchronize-v2alpha1-with-v1 sync fmt yamlfmt license
+	@$(MAKE) tidy vendor generate update-generated synchronize-v2alpha1-with-v1 sync fmt yamlfmt license protolint
 	@git checkout -- go.sum # ignore changes in go.sum
 	@if [ ! -z "$(git status --porcelain)" ]; then echo "There are uncommited changes!"; git status; exit 1; fi

integrations/config/v1/definition/config.pb.go

@@ -30,8 +30,11 @@ option go_package = "github.com/arangodb/kube-arangodb/integrations/config/v1/de
 
 // ConfigV1 Service implementation
 service ConfigV1 {
+  // Returns list of registered modules
   rpc Modules(shared.Empty) returns (ConfigV1ModulesResponse);
+  // Returns details of the module
   rpc ModuleDetails(ConfigV1ModuleDetailsRequest) returns (ConfigV1ModuleDetailsResponse);
+  // Returns file details
   rpc FileDetails(ConfigV1FileDetailsRequest) returns (ConfigV1FileDetailsResponse);
 }
 
@@ -99,8 +102,8 @@ message ConfigV1File {
   optional string checksum = 3;
 
   // Timestamp of the file creation
-  google.protobuf.Timestamp created_at = 4;
+  google.protobuf.Timestamp created = 4;
 
   // Timestamp of the file update
-  google.protobuf.Timestamp updated_at = 5;
+  google.protobuf.Timestamp updated = 5;
 }

integrations/config/v1/definition/config.proto

@@ -64,8 +64,8 @@ func (i *impl) fileDetails(module ModuleDefinition, file string, checksum bool)
 
 	f.Path = strings.TrimPrefix(expectedPath, fmt.Sprintf("%s/", module.Path))
 	f.Size = finfo.Size
-	f.CreatedAt = timestamppb.New(time.Unix(finfo.Ctimespec.Sec, finfo.Ctimespec.Nsec))
-	f.UpdatedAt = timestamppb.New(time.Unix(finfo.Mtimespec.Sec, finfo.Mtimespec.Nsec))
+	f.Created = timestamppb.New(time.Unix(finfo.Ctimespec.Sec, finfo.Ctimespec.Nsec))
+	f.Updated = timestamppb.New(time.Unix(finfo.Mtimespec.Sec, finfo.Mtimespec.Nsec))
 
 	if checksum {
 		c, err := util.SHA256FromFile(expectedPath)

integrations/config/v1/definition/config_grpc.pb.go

@@ -64,8 +64,8 @@ func (i *impl) fileDetails(module ModuleDefinition, file string, checksum bool)
 
 	f.Path = strings.TrimPrefix(expectedPath, fmt.Sprintf("%s/", module.Path))
 	f.Size = finfo.Size
-	f.CreatedAt = timestamppb.New(time.Unix(finfo.Ctim.Sec, finfo.Ctim.Nsec))
-	f.UpdatedAt = timestamppb.New(time.Unix(finfo.Mtim.Sec, finfo.Mtim.Nsec))
+	f.Created = timestamppb.New(time.Unix(finfo.Ctim.Sec, finfo.Ctim.Nsec))
+	f.Updated = timestamppb.New(time.Unix(finfo.Mtim.Sec, finfo.Mtim.Nsec))
 
 	if checksum {
 		c, err := util.SHA256FromFile(expectedPath)

integrations/config/v1/impl_darwin.go

@@ -30,6 +30,7 @@ option go_package = "github.com/arangodb/kube-arangodb/integrations/pong/v1/defi
 
 // PongV1 Service implementation
 service PongV1 {
+  // Sends ping to the server
   rpc Ping(shared.Empty) returns (PongV1PingResponse);
 }
 

integrations/config/v1/impl_linux.go

@@ -72,10 +72,10 @@ message StatusMetadata {
   bool created = 1;
 
   // Defines checksum
-  optional string checksum =2;
+  optional string checksum = 2;
 
   // Defines uid
-  optional string uid =3;
+  optional string uid = 3;
 
   // Defiles list of applied profiles
   repeated string profiles = 4;