[Bugfix] Remove CleanOut Action (#691)

Author: ajanikow

CHANGELOG.md

@@ -5,6 +5,7 @@
 - Use cached status in member client creation
 - Remove failed DBServers
 - Remove deadlock in internal cache
+- Replace CleanOut action with ResignLeadership on rotate PVC resize mode
 
 ## [1.1.4](https://github.com/arangodb/kube-arangodb/tree/1.1.4) (2021-02-15)
 - Add support for spec.ClusterDomain to be able to use FQDN in ArangoDB cluster communication

pkg/deployment/reconcile/plan_builder_storage.go

@@ -141,23 +141,14 @@ func pvcResizePlan(log zerolog.Logger, group api.ServerGroup, groupSpec api.Serv
 			api.NewAction(api.ActionTypePVCResize, group, memberID),
 		}
 	case api.PVCResizeModeRotate:
-		var plan api.Plan
-
-		if group == api.ServerGroupDBServers {
-			plan = append(plan,
-				api.NewAction(api.ActionTypeCleanOutMember, group, memberID),
-			)
-		}
-
-		plan = append(plan,
+		return api.Plan{
+			api.NewAction(api.ActionTypeResignLeadership, group, memberID),
 			api.NewAction(api.ActionTypeRotateStartMember, group, memberID),
 			api.NewAction(api.ActionTypePVCResize, group, memberID),
 			api.NewAction(api.ActionTypePVCResized, group, memberID),
 			api.NewAction(api.ActionTypeRotateStopMember, group, memberID),
 			api.NewAction(api.ActionTypeWaitForMemberUp, group, memberID),
-		)
-
-		return plan
+		}
 	default:
 		log.Error().Str("server-group", group.AsRole()).Str("mode", mode.String()).
 			Msg("Requested mode is not supported")