Rename LocallyAttachedVolumes to NetworkAttachedVolumes. (#447)

Author: neunhoef

docs/Manual/Deployment/Kubernetes/DeploymentResource.md

@@ -143,6 +143,20 @@ The encryption key cannot be changed after the cluster has been created.
 The secret specified by this setting, must have a data field named 'key' containing
 an encryption key that is exactly 32 bytes long.
 
+### `spec.networkAttachedVolumes: bool`
+
+The default of this option is `false`. If set to `true`, and the
+deployed ArangoDB version is new enough (>= 3.4.8 for 3.4 and >= 3.5.1
+for 3.5), a `ResignLeaderShip` operation
+will be triggered when a dbserver pod is evicted (rather than a
+`CleanOutServer` operation). Furthermore, the pod will simply be
+redeployed on a different node, rather than cleaned and retired and
+replaced by a new member. You must only set this option to `true` if
+your persistent volumes are "movable" in the sense that they can be
+mounted from a different k8s node, like in the case of network attached
+volumes. If your persistent volumes are tied to a specific pod, you
+must leave this option on `false`.
+
 ### `spec.externalAccess.type: string`
 
 This setting specifies the type of `Service` that will be created to provide

pkg/apis/deployment/v1alpha/deployment_spec.go

@@ -56,7 +56,7 @@ type DeploymentSpec struct {
 	DowntimeAllowed  *bool           `json:"downtimeAllowed,omitempty"`
 	DisableIPv6      *bool           `json:"disableIPv6,omitempty"`
 
-	LocallyAttachedVolumes *bool 	`json:"locallyAttachedVolumes,omitempty"`
+	NetworkAttachedVolumes *bool     `json:"networkAttachedVolumes,omitempty"`
 
 	ExternalAccess ExternalAccessSpec `json:"externalAccess"`
 	RocksDB        RocksDBSpec        `json:"rocksdb"`
@@ -126,9 +126,9 @@ func (s DeploymentSpec) IsDisableIPv6() bool {
 	return util.BoolOrDefault(s.DisableIPv6)
 }
 
-// IsLocallyAttachedVolumes returns the value of locallyAttachedVolumes, default true
-func (s DeploymentSpec) IsLocallyAttachedVolumes() bool {
-	return util.BoolOrDefault(s.LocallyAttachedVolumes, true)
+// IsNetworkAttachedVolumes returns the value of networkAttachedVolumes, default false
+func (s DeploymentSpec) IsNetworkAttachedVolumes() bool {
+	return util.BoolOrDefault(s.NetworkAttachedVolumes, false)
 }
 
 // GetListenAddr returns "[::]" or "0.0.0.0" depending on IsDisableIPv6

pkg/apis/deployment/v1alpha/zz_generated.deepcopy.go

@@ -157,7 +157,7 @@ func (r *Resources) prepareDBServerPodTermination(ctx context.Context, log zerol
 			log.Warn().Err(err).Msg("Failed to get node for member")
 			return maskAny(err)
 		} else if node.Spec.Unschedulable {
-			if r.context.GetSpec().IsLocallyAttachedVolumes() || !resignJobAvailable {
+			if !r.context.GetSpec().IsNetworkAttachedVolumes() || !resignJobAvailable {
 				dbserverDataWillBeGone = true
 			}
 		}