Feature/download rclone (#627)

* Initial commit

* Add Windows implementation

* Fix leftovers

* fix typo

---------

Co-authored-by: Vitaly Pryakhin <[email protected]>

Author: KVS85

helper.fish

@@ -444,9 +444,23 @@ if test ! -d work ; mkdir work ; end
 if test -z "$ARANGODB_DOCS_BRANCH" ; set -gx ARANGODB_DOCS_BRANCH "main"
 else ; set -gx ARANGODB_DOCS_BRANCH $ARANGODB_DOCS_BRANCH ; end
 
+function findRcloneGoVersion
+  set -l f "$WORKDIR/work/ArangoDB/VERSIONS"
+  set -xg RCLONE_GO_VERSION "1.22.12"
+
+  test -f $f
+  and begin
+    set -l v (fgrep RCLONE_GO_VERSION $f | awk '{print $2}' | tr -d '"' | tr -d "'")
+
+    if test "$v" != ""
+      set -xg RCLONE_GO_VERSION "$v"
+    end
+  end
+end
+
 function findRcloneVersion
   set -l f "$WORKDIR/work/ArangoDB/VERSIONS"
-  set -xg RCLONE_VERSION "1.59.0"
+  set -xg RCLONE_VERSION "1.65.2"
 
   test -f $f
   and begin
@@ -455,11 +469,17 @@ function findRcloneVersion
     if test "$v" != ""
       set -xg RCLONE_VERSION "$v"
     end
-
-    setupSourceInfo "Rclone" "$RCLONE_VERSION"
   end
 end
 
+function findRcloneRelease
+  findRcloneGoVersion
+  and findRcloneVersion
+
+  set -xg RCLONE_RELEASE "golang-"$RCLONE_GO_VERSION"_"$RCLONE_VERSION
+  setupSourceInfo "Rclone" "$RCLONE_RELEASE"
+end
+
 function findUseRclone
   set -l f "$WORKDIR/work/ArangoDB/VERSIONS"
 
@@ -475,15 +495,17 @@ function findUseRclone
   if test "$v" = ""
     #echo "$f: no USE_RCLONE specified, using false"
     set -gx USE_RCLONE "false"
+    return 1
   else
     #echo "Using rclone '$v' from '$f'"
     set -gx USE_RCLONE "$v"
+    return 0
   end
 end
 
 if test -z "$USE_RCLONE" ; findUseRclone ; end
 
-function copyRclone
+function prepareDownloadRclone
   findUseRclone
 
   if test "$USE_RCLONE" = "false"
@@ -512,7 +534,7 @@ function copyRclone
       end
   end
 
-  findRcloneVersion
+  findRcloneRelease
 
   echo Copying rclone from rclone/v$RCLONE_VERSION/rclone-arangodb-$os-$arch to $WORKDIR/work/$THIRDPARTY_SBIN/rclone-arangodb ...
   mkdir -p $WORKDIR/work/$THIRDPARTY_SBIN

helper.linux.fish

@@ -682,7 +682,7 @@ function buildEnterprisePackage
   and buildStaticArangoDB
   and downloadStarter
   and downloadSyncer
-  and copyRclone "linux"
+  and downloadRclone
   and buildPackage $packages
 
   if test $status -ne 0
@@ -871,7 +871,7 @@ function makeTestPackageLinux
   and set -xg NOSTRIP 1
   and buildStaticArangoDB
   and downloadStarter
-  and if test "$ENTERPRISEEDITION" = "On"; downloadSyncer; and copyRclone "linux"; end
+  and if test "$ENTERPRISEEDITION" = "On"; downloadSyncer; and downloadRclone; end
   and buildTarGzServerLinuxTestPackage
 
   if test $status -ne 0
@@ -1241,7 +1241,7 @@ function buildDockerAny
   and downloadStarter
   and if test "$ENTERPRISEEDITION" = "On"
     downloadSyncer
-    copyRclone "linux"
+    downloadRclone
   end
   and buildDockerImage $IMAGE_NAME1
   and if test "$IMAGE_NAME1" != "$IMAGE_NAME2"
@@ -1579,7 +1579,7 @@ function pullUbuntuPackagingImage2 ; docker pull $UBUNTUPACKAGINGIMAGE2 ; end
 
 function buildAlpineUtilsImage
   pushd $WORKDIR
-  and cp -a scripts/{checkoutArangoDB,checkoutEnterprise,clearWorkDir,downloadStarter,downloadSyncer,runTests,runFullTests,switchBranches,recursiveChown}.fish containers/buildUtils.docker/scripts
+  and cp -a scripts/{checkoutArangoDB,checkoutEnterprise,clearWorkDir,downloadStarter,downloadSyncer,downloadRclone,runTests,runFullTests,switchBranches,recursiveChown}.fish containers/buildUtils.docker/scripts
   and cd $WORKDIR/containers/buildUtils.docker
   and eval "docker build $IMAGE_ARGS --pull -t $ALPINEUTILSIMAGE ."
   or begin ; popd ; return 1 ; end
@@ -2081,9 +2081,16 @@ function downloadSyncer
   end
 end
 
+function downloadRclone
+  findUseRclone
+  and mkdir -p $WORKDIR/work/$THIRDPARTY_SBIN
+  and runInContainer $ALPINEUTILSIMAGE $SCRIPTSDIR/downloadRclone.fish $INNERWORKDIR/$THIRDPARTY_SBIN $argv
+  and convertSItoJSON
+end
+
 function downloadAuxBinariesToBuildBin
   if test "$ENTERPRISEEDITION" = "On"
-     copyRclone linux
+     downloadRclone
      and cp work/ArangoDB/build/install/usr/sbin/rclone-arangodb work/ArangoDB/build/bin/
      and downloadSyncer
      and if test "$ARANGODB_VERSION_MAJOR" -eq 3; and test "$ARANGODB_VERSION_MINOR" -lt 12

helper.mac.fish

@@ -494,6 +494,13 @@ function downloadSyncer
   and convertSItoJSON
 end
 
+function downloadRclone
+  findUseRclone
+  and mkdir -p $WORKDIR/work/$THIRDPARTY_SBIN
+  and runLocal $SCRIPTSDIR/downloadRclone.fish $INNERWORKDIR/$THIRDPARTY_SBIN $argv
+  and convertSItoJSON
+end
+
 function setupComponents
   cleanupThirdParty
   if test "$ARANGODB_VERSION_MAJOR" -eq 3; and test "$ARANGODB_VERSION_MINOR" -le 10
@@ -504,7 +511,7 @@ function setupComponents
       end
       and downloadSyncer
       if test "$USE_RCLONE" = "true"
-        copyRclone "macos"
+        downloadRclone
       end
     end
   else