Removing collection parameter

Author: apetenchea

arangoasync/database.py

@@ -835,7 +835,6 @@ async def insert_document(
 
     async def update_document(
         self,
-        collection: str,
         document: Json,
         ignore_revs: Optional[bool] = None,
         wait_for_sync: Optional[bool] = None,
@@ -851,7 +850,6 @@ async def update_document(
         """Update a document.
 
         Args:
-            collection (str): Collection name.
             document (dict): Partial or full document with the updated values.
                 It must contain the "_key" or "_id" field.
             ignore_revs (bool | None): If set to `True`, the `_rev` attribute in the
@@ -891,7 +889,9 @@ async def update_document(
         References:
             - `update-a-document <https://docs.arangodb.com/stable/develop/http-api/documents/#update-a-document>`__
         """  # noqa: E501
-        col: StandardCollection[Json, Json, Jsons] = self.collection(collection)
+        col: StandardCollection[Json, Json, Jsons] = self.collection(
+            Collection.get_col_name(document)
+        )
         return await col.update(
             document,
             ignore_revs=ignore_revs,
@@ -908,7 +908,6 @@ async def update_document(
 
     async def replace_document(
         self,
-        collection: str,
         document: Json,
         ignore_revs: Optional[bool] = None,
         wait_for_sync: Optional[bool] = None,
@@ -922,7 +921,6 @@ async def replace_document(
         """Replace a document.
 
         Args:
-            collection (str): Collection name.
             document (dict): New document. It must contain the "_key" or "_id" field.
                 Edge document must also have "_from" and "_to" fields.
             ignore_revs (bool | None): If set to `True`, the `_rev` attribute in the
@@ -956,7 +954,9 @@ async def replace_document(
         References:
             - `replace-a-document <https://docs.arangodb.com/stable/develop/http-api/documents/#replace-a-document>`__
         """  # noqa: E501
-        col: StandardCollection[Json, Json, Jsons] = self.collection(collection)
+        col: StandardCollection[Json, Json, Jsons] = self.collection(
+            Collection.get_col_name(document)
+        )
         return await col.replace(
             document,
             ignore_revs=ignore_revs,
@@ -971,7 +971,6 @@ async def replace_document(
 
     async def delete_document(
         self,
-        collection: str,
         document: str | Json,
         ignore_revs: Optional[bool] = None,
         ignore_missing: bool = False,
@@ -984,7 +983,6 @@ async def delete_document(
         """Delete a document.
 
         Args:
-            collection (str): Collection name.
             document (str | dict): Document ID, key or body. The body must contain the
                 "_key" or "_id" field.
             ignore_revs (bool | None): If set to `True`, the `_rev` attribute in the
@@ -1017,7 +1015,9 @@ async def delete_document(
         References:
             - `remove-a-document <https://docs.arangodb.com/stable/develop/http-api/documents/#remove-a-document>`__
         """  # noqa: E501
-        col: StandardCollection[Json, Json, Jsons] = self.collection(collection)
+        col: StandardCollection[Json, Json, Jsons] = self.collection(
+            Collection.get_col_name(document)
+        )
         return await col.delete(
             document,
             ignore_revs=ignore_revs,

tests/test_document.py

@@ -594,23 +594,23 @@ async def test_document_db_operations(db, bad_db, doc_col, docs):
 
     # Update the document
     doc["val"] = 100
-    updated_doc = await db.update_document(doc_col.name, doc, return_new=True)
+    updated_doc = await db.update_document(doc, return_new=True)
     assert updated_doc["_id"] == doc["_id"]
     assert updated_doc["new"]["val"] == 100
     with pytest.raises(DocumentUpdateError):
-        await bad_db.update_document(doc_col.name, doc)
+        await bad_db.update_document(doc)
 
     # Replace the document
     doc["val"] = 200
-    replaced_doc = await db.replace_document(doc_col.name, doc, return_new=True)
+    replaced_doc = await db.replace_document(doc, return_new=True)
     assert replaced_doc["_id"] == doc["_id"]
     assert replaced_doc["new"]["val"] == 200
     with pytest.raises(DocumentReplaceError):
-        await bad_db.replace_document(doc_col.name, doc)
+        await bad_db.replace_document(doc)
 
     # Delete the document
-    deleted_doc = await db.delete_document(doc_col.name, doc["_id"], return_old=True)
+    deleted_doc = await db.delete_document(doc["_id"], return_old=True)
     assert deleted_doc["_id"] == doc["_id"]
     assert deleted_doc["old"]["val"] == 200
     with pytest.raises(DocumentDeleteError):
-        await bad_db.delete_document(doc_col.name, doc)
+        await bad_db.delete_document(doc)