Add system parameters to delete_collection method

Author: joowani

arango/client.py

@@ -411,6 +411,10 @@ def read_log(self,
     def log_levels(self):
         """Return the current logging levels.
 
+        .. note::
+
+            This method is only compatible with ArangoDB version 3.1+ only.
+
         :return: the current logging levels
         :rtype: dict
         """
@@ -435,7 +439,11 @@ def set_log_levels(self, **kwargs):
 
         .. note::
 
-        Keys that are not valid logger names are simply ignored.
+            Keys that are not valid logger names are simply ignored.
+
+        .. note::
+
+            This method is only compatible with ArangoDB version 3.1+ only.
 
         :return: the new logging levels
         :rtype: dict

arango/database.py

@@ -206,6 +206,11 @@ def create_collection(self,
                           index_bucket_count=None):
         """Create a new collection.
 
+        .. note::
+
+            Starting from ArangoDB version 3.1+, system collections must have
+            a name with a leading underscore ``_`` character.
+
         :param name: the name of the collection
         :type name: str | unicode
         :param sync: wait for the operation to sync to disk
@@ -275,19 +280,27 @@ def create_collection(self,
             raise CollectionCreateError(res)
         return self.collection(name)
 
-    def delete_collection(self, name, ignore_missing=False):
+    def delete_collection(self, name, ignore_missing=False, system=None):
         """Delete a collection.
 
         :param name: the name of the collection to delete
         :type name: str | unicode
         :param ignore_missing: do not raise if the collection is missing
         :type ignore_missing: bool
+        :param system: whether the collection is a system collection (this
+            option is only available with ArangoDB 3.1+, lower versions do
+            distinguish between system or non-system collections)
+        :type system: bool
         :returns: whether the deletion was successful
         :rtype: bool
         :raises arango.exceptions.CollectionDeleteError: if the collection
             cannot be deleted from the database
         """
-        res = self._conn.delete('/_api/collection/{}'.format(name))
+        res = self._conn.delete(
+            '/_api/collection/{}'.format(name),
+            params={'isSystem': system}
+            if system is not None else None  # pragma: no cover
+        )
         if res.status_code not in HTTP_OK:
             if not (res.status_code == 404 and ignore_missing):
                 raise CollectionDeleteError(res)

tests/test_database.py

@@ -10,7 +10,8 @@
 from .utils import (
     generate_db_name,
     generate_col_name,
-    generate_graph_name
+    generate_graph_name,
+    arango_version
 )
 
 arango_client = ArangoClient()
@@ -105,6 +106,29 @@ def test_create_collection():
 
 
 @pytest.mark.order5
+def test_create_system_collection():
+    major, minor = arango_version(arango_client)
+    if major == 3 and minor >= 1:
+
+        system_col_name = '_' + col_name_1
+        col = db.create_collection(
+            name=system_col_name,
+            system=True,
+        )
+        properties = col.properties()
+        assert properties['system'] is True
+        assert system_col_name in [c['name'] for c in db.collections()]
+        assert db.collection(system_col_name).properties()['system'] is True
+
+        with pytest.raises(CollectionDeleteError):
+            db.delete_collection(system_col_name)
+        assert system_col_name in [c['name'] for c in db.collections()]
+
+        db.delete_collection(system_col_name, system=True)
+        assert system_col_name not in [c['name'] for c in db.collections()]
+
+
+@pytest.mark.order6
 def test_drop_collection():
     # Test drop collection
     result = db.delete_collection(col_name_2)
@@ -120,7 +144,7 @@ def test_drop_collection():
     assert result is False
 
 
-@pytest.mark.order6
+@pytest.mark.order7
 def test_list_graphs():
     graphs = db.graphs()
     assert len(graphs) == 1
@@ -135,14 +159,14 @@ def test_list_graphs():
         bad_db.graphs()
 
 
-@pytest.mark.order7
+@pytest.mark.order8
 def test_get_graph():
     graph = db.graph(graph_name)
     assert isinstance(graph, Graph)
     assert graph.name == graph_name
 
 
-@pytest.mark.order8
+@pytest.mark.order9
 def test_create_graph():
     # Test create duplicate graph
     with pytest.raises(GraphCreateError):
@@ -153,7 +177,7 @@ def test_create_graph():
     assert new_graph_name in [g['name'] for g in db.graphs()]
 
 
-@pytest.mark.order9
+@pytest.mark.order10
 def test_drop_graph():
     # Test drop graph
     result = db.delete_graph(graph_name)