Skip to content

Commit 4d867af

Browse files
authored
build: generate_config_gypi.py generates valid JSON
PR-URL: nodejs#61791 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 4f13746 commit 4d867af

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

tools/generate_config_gypi.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def translate_config(out_dir, config, v8_config):
5858
'llvm_version': 13,
5959
'napi_build_version': config['napi_build_version'],
6060
'node_builtin_shareable_builtins':
61-
eval(config['node_builtin_shareable_builtins']),
61+
json.loads(config['node_builtin_shareable_builtins']),
6262
'node_module_version': int(config['node_module_version']),
6363
'node_use_openssl': config['node_use_openssl'],
6464
'node_use_amaro': config['node_use_amaro'],
@@ -102,7 +102,8 @@ def main():
102102

103103
# Write output.
104104
with open(args.target, 'w') as f:
105-
f.write(repr(translate_config(args.out_dir, config, v8_config)))
105+
f.write(json.dumps(translate_config(args.out_dir, config, v8_config),
106+
sort_keys=True))
106107

107108
# Write depfile. Force regenerating config.gypi when GN configs change.
108109
if args.dep_file:

0 commit comments

Comments
 (0)