Merge pull request rstudio#1962 from olivroy/use-seps

Add workaround for removing the trailing dec mark when sep_mark = ""

Author: rich-iannone

NEWS.md

@@ -1,5 +1,7 @@
 # gt (development version)
 
+* Fixed an issue in `fmt_number()` where `drop_trailing_dec_mark` would be ignored if `use_seps = FALSE` (@olivroy, #1961).
+
 * Fixed an issue where `fmt_markdown()` could create strange output in Quarto (html and Typst formats) (@olivroy, #1957, [quarto-dev/quarto-cli#11932](https://github.com/quarto-dev/quarto-cli/issues/11932), [quarto-dev/quarto-cli#11610](https://github.com/quarto-dev/quarto-cli/issues/11610)).
 
 * The default table position in LaTeX is now "t" instead of "!t" (@AaronGullickson, #1935).

R/fmt.R

@@ -610,6 +610,10 @@ format_num_to_str <- function(
   if (!drop_trailing_dec_mark) {
     x_str_no_dec <- !grepl(dec_mark, x_str, fixed = TRUE)
     x_str[x_str_no_dec] <- paste_right(x_str[x_str_no_dec], dec_mark)
+  } else if (nzchar(dec_mark) && !nzchar(sep_mark)) {
+    # drop the trailing dec mark if sep mark is the empty ""
+    # needed in some cases https://github.com/rstudio/gt/issues/1961
+    x_str[endsWith(x_str, dec_mark)] <- sub(dec_mark, "", x_str[endsWith(x_str, dec_mark)], fixed = TRUE)
   }
 
   # Perform modifications to `x_str` values if formatting values to

tests/testthat/test-fmt_number.R

@@ -1092,3 +1092,10 @@ test_that("fmt_number() can render values in the Indian numbering system", {
     render_formats_test(expected_tab, context = "html")[["num"]]
   )
 })
+
+test_that("fmt_number() works with n_sigfig, drop_trailing_dec_mark = TRUE (#1961)", {
+  expect_equal(
+    format_num_to_str(1335.3, "html",  n_sigfig = 4, sep_mark = "", dec_mark = ".", drop_trailing_dec_mark = T,format = "fg"),
+    "1335"
+  )
+})