Skip to content

Commit 1662d9c

Browse files
Romburaprokop
authored andcommitted
Reenable MLS tests on HIP
1 parent 466efb7 commit 1662d9c

File tree

2 files changed

+0
-46
lines changed

2 files changed

+0
-46
lines changed

test/tstInterpDetailsMLSCoefficients.cpp

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -45,17 +45,6 @@ interpolate(ExecutionSpace const &space, SourceValues const &source_values,
4545

4646
BOOST_AUTO_TEST_CASE_TEMPLATE(mls_coefficients, DeviceType, ARBORX_DEVICE_TYPES)
4747
{
48-
// FIXME_HIP: the CI fails with:
49-
// fatal error: in "mls_coefficients_edge_cases<Kokkos__Device<Kokkos__HIP_
50-
// Kokkos__HIPSpace>>": std::runtime_error: Kokkos::Impl::ParallelFor/Reduce<
51-
// HIP > could not find a valid team size.
52-
// The error seems similar to https://github.com/kokkos/kokkos/issues/6743
53-
#ifdef KOKKOS_ENABLE_HIP
54-
if (std::is_same_v<typename DeviceType::execution_space, Kokkos::HIP>)
55-
{
56-
return;
57-
}
58-
#endif
5948
using ExecutionSpace = typename DeviceType::execution_space;
6049
using MemorySpace = typename DeviceType::memory_space;
6150
ExecutionSpace space{};
@@ -137,17 +126,6 @@ BOOST_AUTO_TEST_CASE_TEMPLATE(mls_coefficients, DeviceType, ARBORX_DEVICE_TYPES)
137126
BOOST_AUTO_TEST_CASE_TEMPLATE(mls_coefficients_edge_cases, DeviceType,
138127
ARBORX_DEVICE_TYPES)
139128
{
140-
// FIXME_HIP: the CI fails with:
141-
// fatal error: in "mls_coefficients_edge_cases<Kokkos__Device<Kokkos__HIP_
142-
// Kokkos__HIPSpace>>": std::runtime_error: Kokkos::Impl::ParallelFor/Reduce<
143-
// HIP > could not find a valid team size.
144-
// The error seems similar to https://github.com/kokkos/kokkos/issues/6743
145-
#ifdef KOKKOS_ENABLE_HIP
146-
if (std::is_same_v<typename DeviceType::execution_space, Kokkos::HIP>)
147-
{
148-
return;
149-
}
150-
#endif
151129
using ExecutionSpace = typename DeviceType::execution_space;
152130
using MemorySpace = typename DeviceType::memory_space;
153131
ExecutionSpace space{};

test/tstInterpMovingLeastSquares.cpp

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -21,18 +21,6 @@
2121
BOOST_AUTO_TEST_CASE_TEMPLATE(moving_least_squares, DeviceType,
2222
ARBORX_DEVICE_TYPES)
2323
{
24-
// FIXME_HIP: the CI fails with:
25-
// fatal error: in "mls_coefficients_edge_cases<Kokkos__Device<Kokkos__HIP_
26-
// Kokkos__HIPSpace>>": std::runtime_error: Kokkos::Impl::ParallelFor/Reduce<
27-
// HIP > could not find a valid team size.
28-
// The error seems similar to https://github.com/kokkos/kokkos/issues/6743
29-
#ifdef KOKKOS_ENABLE_HIP
30-
if (std::is_same_v<typename DeviceType::execution_space, Kokkos::HIP>)
31-
{
32-
return;
33-
}
34-
#endif
35-
3624
using ExecutionSpace = typename DeviceType::execution_space;
3725
using MemorySpace = typename DeviceType::memory_space;
3826
ExecutionSpace space{};
@@ -111,18 +99,6 @@ BOOST_AUTO_TEST_CASE_TEMPLATE(moving_least_squares, DeviceType,
11199
BOOST_AUTO_TEST_CASE_TEMPLATE(moving_least_squares_edge_cases, DeviceType,
112100
ARBORX_DEVICE_TYPES)
113101
{
114-
// FIXME_HIP: the CI fails with:
115-
// fatal error: in "mls_coefficients_edge_cases<Kokkos__Device<Kokkos__HIP_
116-
// Kokkos__HIPSpace>>": std::runtime_error: Kokkos::Impl::ParallelFor/Reduce<
117-
// HIP > could not find a valid team size.
118-
// The error seems similar to https://github.com/kokkos/kokkos/issues/6743
119-
#ifdef KOKKOS_ENABLE_HIP
120-
if (std::is_same_v<typename DeviceType::execution_space, Kokkos::HIP>)
121-
{
122-
return;
123-
}
124-
#endif
125-
126102
using ExecutionSpace = typename DeviceType::execution_space;
127103
using MemorySpace = typename DeviceType::memory_space;
128104
ExecutionSpace space{};

0 commit comments

Comments
 (0)