ci: fix zip command

Author: ledif

.github/workflows/package-release.yml

@@ -38,9 +38,21 @@ jobs:
       - name: Create package
         id: create_package
         run: |
-          OUTPUT=$(.github/workflows/scripts/create-package.sh "${{ steps.version.outputs.version }}" "${{ steps.current_time.outputs.timestamp }}")
-          echo "PACKAGE_PATH=$OUTPUT" >> $GITHUB_ENV
-          echo "package_path=$OUTPUT" >> $GITHUB_OUTPUT
+          # Capture output in a variable
+          RESULT=$(.github/workflows/scripts/create-package.sh "${{ steps.version.outputs.version }}" "${{ steps.current_time.outputs.timestamp }}")
+          # Check if script succeeded
+          if [ $? -ne 0 ]; then
+            echo "Error creating package"
+            exit 1
+          fi
+          # Check if file exists
+          if [ ! -f "$RESULT" ]; then
+            echo "Package file not found: $RESULT"
+            exit 1
+          fi
+          # Set outputs
+          echo "PACKAGE_PATH=$RESULT" >> $GITHUB_ENV
+          echo "package_path=$RESULT" >> $GITHUB_OUTPUT
 
       - name: Create Release
         id: create_release
@@ -62,4 +74,5 @@ jobs:
             - Build Date: ${{ steps.current_time.outputs.timestamp }}
             - Created by: ${{ github.actor }}
         env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+

.github/workflows/scripts/create-package.sh

@@ -10,21 +10,8 @@ if [ -z "$VERSION" ]; then
   exit 1
 fi
 
-# Format the package name similar to common software package conventions
-# You can choose one of these formats by uncommenting the preferred one:
-
-# Option 1: Simple format with version only
+# Format the package name
 PACKAGE_NAME="rider-waite-smith-${VERSION}"
-
-# Option 2: RPM-like format with version and build date
-# PACKAGE_NAME="rider-waite-smith-${VERSION}-${TIMESTAMP}"
-
-# Option 3: Debian-like format
-# PACKAGE_NAME="rider-waite-smith_${VERSION}_all"
-
-# Option a standard format
-# PACKAGE_NAME="rider-waite-smith-v${VERSION}"
-
 ZIP_FILE="${PACKAGE_NAME}.zip"
 
 # Create a temporary directory for packaging
@@ -36,7 +23,7 @@ mkdir -p "${DECK_DIR}"
 cp -r rider-waite-smith/* "${DECK_DIR}/"
 
 # Include metadata file with package info
-cat > "${DECK_DIR}/PACKAGE-INFO.txt" << EOL
+cat >"${DECK_DIR}/PACKAGE-INFO.txt" <<EOL
 Package: Rider-Waite-Smith Tarot Deck
 Version: ${VERSION}
 Build Date: $(date -u +"%Y-%m-%d %H:%M:%S UTC")
@@ -46,14 +33,22 @@ Repository: ${GITHUB_REPOSITORY:-"arcanaland/specifications"}
 This package follows the Tarot Deck Specification v1.0.
 EOL
 
-# Create the zip file
-(cd "${TEMP_DIR}" && zip -r "${ZIP_FILE}" "${PACKAGE_NAME}")
+# Create the zip file and suppress the output
+(cd "${TEMP_DIR}" && zip -r "${ZIP_FILE}" "${PACKAGE_NAME}" >/dev/null)
+
+# Check if zip command was successful
+if [ $? -ne 0 ]; then
+  echo "ERROR: Failed to create zip file" >&2
+  rm -rf "${TEMP_DIR}"
+  exit 1
+fi
 
 # Move the zip file to the current directory
 mv "${TEMP_DIR}/${ZIP_FILE}" .
 
 # Clean up the temporary directory
 rm -rf "${TEMP_DIR}"
 
-# Output the path to the zip file
-echo "${ZIP_FILE}"
+# Output just the filename, no other text
+echo "${ZIP_FILE}"
+