ci: the vibes are off

Author: ledif

.github/workflows/package-release.yml

@@ -38,35 +38,21 @@ jobs:
       - name: Create package
         id: create_package
         run: |
-          # Create the package and capture only the filename
-          FILENAME=$(.github/workflows/scripts/create-package.sh "${{ steps.version.outputs.version }}" "${{ steps.current_time.outputs.timestamp }}")
+          # Run the script and capture the output (which should be just the filename)
+          OUTPUT_FILE=$(.github/workflows/scripts/create-package.sh "${{ steps.version.outputs.version }}" "${{ steps.current_time.outputs.timestamp }}")
           
-          # Debug output
-          echo "Package script returned: '$FILENAME'"
+          # Trim any whitespace
+          OUTPUT_FILE=$(echo "$OUTPUT_FILE" | xargs)
           
-          # Validate that the file exists
-          if [ -f "$FILENAME" ]; then
-            echo "Found package file: $FILENAME"
-            echo "package_path=$FILENAME" >> $GITHUB_OUTPUT
+          echo "Generated package file: $OUTPUT_FILE"
+          
+          # Verify the file exists
+          if [ -f "$OUTPUT_FILE" ]; then
+            echo "File exists and is readable"
+            ls -la "$OUTPUT_FILE"
+            echo "package_path=$OUTPUT_FILE" >> $GITHUB_OUTPUT
           else
-            echo "ERROR: Package file not found: $FILENAME"
-            exit 1
-          fi
-
-      - name: Debug outputs
-        run: |
-          echo "Version: ${{ steps.version.outputs.version }}"
-          echo "Package path: ${{ steps.create_package.outputs.package_path }}"
-          ls -la
-
-      - name: Create Release
-        id: create_release
-        uses: softprops/action-gh-release@v1
-        # Run this step in all cases where we have a package
-        if: steps.create_package.outputs.package_path != ''
-        with:
-          files: ${{ steps.create_package.outputs.package_path }}
-          name: Rider-Waite-Smith Tarot Deck v${{ steps.version.outputs.version }}
+            echo "ERROR
           tag_name: ${{ startsWith(github.ref, 'refs/tags/') && github.ref_name || format('v{0}', steps.version.outputs.version) }}
           draft: false
           prerelease: false

.github/workflows/scripts/create-package.sh

@@ -1,5 +1,5 @@
 #!/bin/bash
-set -euo pipefail
+set -e
 
 # Get the version from the first parameter
 VERSION=$1
@@ -15,7 +15,8 @@ fi
 PACKAGE_NAME="rider-waite-smith-${VERSION}"
 ZIP_FILE="${PACKAGE_NAME}.zip"
 
-echo "Creating package: ${ZIP_FILE}..."
+# Status messages go to stderr
+echo "Creating package: ${ZIP_FILE}..." >&2
 
 # Create a temporary directory for packaging
 TEMP_DIR=$(mktemp -d)
@@ -36,14 +37,17 @@ Repository: ${GITHUB_REPOSITORY:-"arcanaland/specifications"}
 This package follows the Tarot Deck Specification v1.0.
 EOL
 
-# Create the zip file and redirect output to stderr so it doesn't affect the function output
-(cd "${TEMP_DIR}" && zip -r "${ZIP_FILE}" "${PACKAGE_NAME}" 1>&2)
+# Create the zip file and redirect output to stderr
+(cd "${TEMP_DIR}" && zip -r "${ZIP_FILE}" "${PACKAGE_NAME}" >&2)
 
 # Move the zip file to the current directory
 mv "${TEMP_DIR}/${ZIP_FILE}" .
 
 # Clean up the temporary directory
 rm -rf "${TEMP_DIR}"
 
-echo "Package created: ${ZIP_FILE}" >&2
-printf "%s" "${ZIP_FILE}" # Print the filename without newline
+# Inform about success on stderr
+echo "Package created successfully: ${ZIP_FILE}" >&2
+
+# ONLY output the filename to stdout - nothing else!
+echo "${ZIP_FILE}"