fix AXVISOR_VM_CONFIGS separator (#308) #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix AXVISOR_VM_CONFIGS separator * fix: use std::env::join_paths for AXVISOR_VM_CONFIGS
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the AXVISOR_VM_CONFIGS environment variable construction to use platform-specific path separators instead of a hardcoded semicolon separator.
Key Changes:
- Replaces manual string joining with semicolons with
std::env::join_paths(), which uses the correct platform-specific path separator (:on Unix,;on Windows) - Adds proper error handling for the path joining operation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix AXVISOR_VM_CONFIGS separator
fix: use std::env::join_paths for AXVISOR_VM_CONFIGS