chore: cleanup #10
Open
chore: cleanup #10
+49
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses clippy warnings and errors across the workspace, focusing on code quality improvements and version management restructuring. The changes transition from workspace-level version management to individual crate versions (0.4.0) for memory_set and memory_addr crates.
Key Changes:
- Refactored test loops to use iterator patterns instead of indexing to satisfy clippy lints
- Implemented
Defaulttrait forMemorySetto address clippy'snew_without_defaultwarning - Flattened nested if-else chains to improve code readability
- Separated crate versions from workspace configuration
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Removed workspace-level version specification to allow individual crate version management |
| memory_set/Cargo.toml | Added explicit version 0.4.0, removing workspace version dependency |
| memory_addr/Cargo.toml | Added explicit version 0.4.0, removing workspace version dependency |
| memory_set/src/set.rs | Added Default trait implementation for MemorySet to address clippy warning |
| memory_set/src/tests.rs | Refactored loops from index-based to iterator-based patterns and flattened nested conditionals |
| memory_addr/src/range.rs | Added #[allow(clippy::reversed_empty_ranges)] to suppress clippy warning for intentional test case |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some workspace cleanup.
The reason for managing the two crate versions separately was explained at arceos-org/page_table_multiarch#25 (comment).