[refactor] strictly follow RAII, standardize ownership & cleanup redundant initializers

Author: demonkillerr

src/core/alpm_wrapper.cpp

@@ -10,8 +10,8 @@ AlpmWrapper& AlpmWrapper::instance() {
     return instance;
 }
 
-AlpmWrapper::AlpmWrapper()
-    : m_handle(nullptr), m_syncDbs(nullptr), m_initialized(false) {
+AlpmWrapper::AlpmWrapper() {
+    // Member initialization is done in header file
 }
 
 AlpmWrapper::~AlpmWrapper() {

src/core/alpm_wrapper.h

@@ -9,6 +9,17 @@
 #include <mutex>
 #include "../utils/types.h"
 
+/**
+ * @brief Singleton wrapper for libalpm (Arch Linux Package Manager library).
+ * 
+ * Memory Management:
+ * - m_handle: Raw pointer to libalpm handle, manually managed via initialize()/release()
+ * - m_syncDbs: Raw pointer to libalpm list, managed by libalpm internally
+ * - Thread-safe via m_mutex
+ * 
+ * Note: libalpm uses C-style memory management, so smart pointers are not
+ * directly applicable to the alpm types.
+ */
 class AlpmWrapper {
 public:
     static AlpmWrapper& instance();
@@ -34,10 +45,10 @@ class AlpmWrapper {
 private:
     AlpmWrapper();
 
-    alpm_handle_t* m_handle;
-    alpm_list_t* m_syncDbs;
+    alpm_handle_t* m_handle = nullptr;
+    alpm_list_t* m_syncDbs = nullptr;
     std::mutex m_mutex;
-    bool m_initialized;
+    bool m_initialized = false;
 
     QStringList convertDependList(alpm_list_t* deps);
     void searchInDatabase(alpm_db_t* db, const QString& query, 

src/core/aur_helper.h

@@ -9,6 +9,13 @@
 #include <memory>
 #include "../utils/types.h"
 
+/**
+ * @brief Helper class for interacting with the Arch User Repository (AUR).
+ * 
+ * Memory Management:
+ * - m_networkManager: Owned by std::unique_ptr for RAII-style cleanup
+ * - Network replies are managed via Qt parent-child and deleteLater()
+ */
 class AurHelper : public QObject {
     Q_OBJECT
 

src/core/package_manager.cpp

@@ -10,7 +10,6 @@ PackageManager& PackageManager::instance() {
 
 PackageManager::PackageManager()
     : QObject(nullptr)
-    , m_helper(Helper::Pacman)
     , m_process(std::make_unique<QProcess>()) {
 
     detectHelper();

src/core/package_manager.h

@@ -7,6 +7,13 @@
 #include <memory>
 #include <mutex>
 
+/**
+ * @brief Singleton class for managing package operations (install, uninstall, update).
+ * 
+ * Memory Management:
+ * - m_process: Owned by std::unique_ptr for RAII-style cleanup and clear ownership
+ * - Thread-safe via m_mutex for operation serialization
+ */
 class PackageManager : public QObject {
     Q_OBJECT
 
@@ -49,9 +56,9 @@ class PackageManager : public QObject {
     void detectHelper();
     void executeCommand(const QString& command, const QStringList& args);
 
-    Helper m_helper;
+    Helper m_helper = Helper::Pacman;
     std::unique_ptr<QProcess> m_process;
-    std::mutex m_mutex;
+    mutable std::mutex m_mutex;
 
 private slots:
     void onProcessFinished(int exitCode, QProcess::ExitStatus exitStatus);

src/gui/home_widget.h

@@ -10,6 +10,13 @@
 
 class PackageCard;
 
+/**
+ * @brief Widget displaying featured packages on the home screen.
+ * 
+ * Memory Management:
+ * - All Qt widget members use Qt parent-child ownership (raw pointers are non-owning)
+ * - m_packageCards contains non-owning pointers to cards owned by m_contentWidget
+ */
 class HomeWidget : public QWidget {
     Q_OBJECT
 
@@ -24,11 +31,13 @@ class HomeWidget : public QWidget {
     void checkInstalledPackages();
 
     QVector<PackageInfo> m_featuredPackages;
-    QVector<PackageCard*> m_packageCards;
-    QScrollArea* m_scrollArea;
-    QWidget* m_contentWidget;
-    QGridLayout* m_gridLayout;
-    QTimer* m_updateTimer;
+    QVector<PackageCard*> m_packageCards;  // Non-owning pointers, owned by m_contentWidget
+    
+    // Qt parent-child managed widgets (non-owning pointers)
+    QScrollArea* m_scrollArea = nullptr;
+    QWidget* m_contentWidget = nullptr;
+    QGridLayout* m_gridLayout = nullptr;
+    QTimer* m_updateTimer = nullptr;
 
 private slots:
     void onPackageClicked(const PackageInfo& info);

src/gui/installed_widget.h

@@ -9,6 +9,13 @@
 #include <QVector>
 #include "../utils/types.h"
 
+/**
+ * @brief Widget displaying installed packages.
+ * 
+ * Memory Management:
+ * - All Qt widget members use Qt parent-child ownership (raw pointers are non-owning)
+ * - Package cards are dynamically created/destroyed in displayPackages/clearResults
+ */
 class InstalledWidget : public QWidget {
     Q_OBJECT
 
@@ -25,12 +32,13 @@ class InstalledWidget : public QWidget {
     void filterPackages(const QString& query);
     void clearResults();
 
-    QLineEdit* m_filterInput;
-    QScrollArea* m_scrollArea;
-    QWidget* m_contentWidget;
-    QGridLayout* m_gridLayout;
-    QLabel* m_statusLabel;
-    QLabel* m_countLabel;
+    // Qt parent-child managed widgets (non-owning pointers)
+    QLineEdit* m_filterInput = nullptr;
+    QScrollArea* m_scrollArea = nullptr;
+    QWidget* m_contentWidget = nullptr;
+    QGridLayout* m_gridLayout = nullptr;
+    QLabel* m_statusLabel = nullptr;
+    QLabel* m_countLabel = nullptr;
 
     QVector<PackageInfo> m_allPackages;
     QVector<PackageInfo> m_filteredPackages;

src/gui/mainwindow.h

@@ -12,6 +12,14 @@ class InstalledWidget;
 class UpdatesWidget;
 class SettingsWidget;
 
+/**
+ * @brief Main application window for ALG App Store.
+ * 
+ * Memory Management:
+ * - m_tabWidget: Owned by std::unique_ptr (central widget)
+ * - Child widgets (m_homeWidget, etc.): Owned by Qt parent-child hierarchy
+ *   through m_tabWidget. Raw pointers are used as non-owning references.
+ */
 class MainWindow : public QMainWindow {
     Q_OBJECT
 
@@ -25,11 +33,13 @@ class MainWindow : public QMainWindow {
     void loadStyleSheet();
 
     std::unique_ptr<QTabWidget> m_tabWidget;
-    HomeWidget* m_homeWidget;
-    SearchWidget* m_searchWidget;
-    InstalledWidget* m_installedWidget;
-    UpdatesWidget* m_updatesWidget;
-    SettingsWidget* m_settingsWidget;
+    
+    // Non-owning pointers - owned by m_tabWidget via Qt parent-child hierarchy
+    HomeWidget* m_homeWidget = nullptr;
+    SearchWidget* m_searchWidget = nullptr;
+    InstalledWidget* m_installedWidget = nullptr;
+    UpdatesWidget* m_updatesWidget = nullptr;
+    SettingsWidget* m_settingsWidget = nullptr;
 };
 
 #endif // MAINWINDOW_H

src/gui/package_card.cpp

@@ -12,8 +12,7 @@ PackageCard::PackageCard(const PackageInfo& info, QWidget* parent)
     , m_descriptionLabel(new QLabel(this))
     , m_versionLabel(new QLabel(this))
     , m_repositoryLabel(new QLabel(this))
-    , m_statusLabel(new QLabel(this))
-    , m_isInstalled(false) {
+    , m_statusLabel(new QLabel(this)) {
 
     setupUi();
     checkInstallStatus();

src/gui/package_card.h

@@ -6,6 +6,12 @@
 #include <QPushButton>
 #include "../utils/types.h"
 
+/**
+ * @brief A clickable card widget displaying package information.
+ * 
+ * Memory Management:
+ * - All Qt widget members use Qt parent-child ownership (raw pointers are non-owning)
+ */
 class PackageCard : public QWidget {
     Q_OBJECT
 
@@ -29,12 +35,15 @@ class PackageCard : public QWidget {
     void setupUi();
 
     PackageInfo m_info;
-    QLabel* m_nameLabel;
-    QLabel* m_descriptionLabel;
-    QLabel* m_versionLabel;
-    QLabel* m_repositoryLabel;
-    QLabel* m_statusLabel;
-    bool m_isInstalled;
+    
+    // Qt parent-child managed widgets (non-owning pointers)
+    QLabel* m_nameLabel = nullptr;
+    QLabel* m_descriptionLabel = nullptr;
+    QLabel* m_versionLabel = nullptr;
+    QLabel* m_repositoryLabel = nullptr;
+    QLabel* m_statusLabel = nullptr;
+    
+    bool m_isInstalled = false;
 };
 
 #endif // PACKAGE_CARD_H