fix: add missing verb for pods/exec (#3166)

Author: brojd

platform/backend/src/websocket.ts

@@ -508,13 +508,21 @@ class WebSocketService {
       stdin.destroy();
       stdout.destroy();
       stderr.destroy();
+
+      let errorMsg = "Failed to exec into pod";
+      if (error instanceof Error) {
+        errorMsg = error.message;
+      } else if (
+        typeof error === "object" &&
+        error !== null &&
+        "message" in error
+      ) {
+        errorMsg = String((error as { message: unknown }).message);
+      }
+
       this.sendToClient(ws, {
         type: "mcp_exec_error",
-        payload: {
-          serverId,
-          error:
-            error instanceof Error ? error.message : "Failed to exec into pod",
-        },
+        payload: { serverId, error: errorMsg },
       });
     }
   }

platform/frontend/src/app/mcp/registry/_parts/mcp-exec-terminal.tsx

@@ -109,7 +109,7 @@ export function McpExecTerminal({ serverId, isActive }: McpExecTerminalProps) {
 
           // Send initial resize
           const dims = fitAddon.proposeDimensions();
-          if (dims) {
+          if (dims?.cols != null && dims?.rows != null) {
             websocketService.send({
               type: "mcp_exec_resize",
               payload: { serverId, cols: dims.cols, rows: dims.rows },
@@ -163,7 +163,7 @@ export function McpExecTerminal({ serverId, isActive }: McpExecTerminalProps) {
         try {
           fitAddon.fit();
           const dims = fitAddon.proposeDimensions();
-          if (dims) {
+          if (dims?.cols != null && dims?.rows != null) {
             websocketService.send({
               type: "mcp_exec_resize",
               payload: { serverId, cols: dims.cols, rows: dims.rows },

platform/helm/archestra/templates/serviceaccount.yaml

@@ -30,7 +30,7 @@ rules:
   verbs: ["get", "list", "create", "update", "patch", "delete", "watch"]
 - apiGroups: [""]
   resources: ["pods/exec"]
-  verbs: ["create"]
+  verbs: ["get", "create"]
 - apiGroups: [""]
   resources: ["pods/log"]
   verbs: ["get", "list"]

platform/helm/archestra/tests/archestra_platform_service_account_test.yaml

@@ -97,7 +97,7 @@ tests:
           content:
             apiGroups: [""]
             resources: ["pods/exec"]
-            verbs: ["create"]
+            verbs: ["get", "create"]
 
   - it: should have pod/log permissions in Role
     documentIndex: 1