Merge pull request #334 from herschel666/gracefully-handle-missing-fingerprinted-file

Gracefully handle missing fingerprinted file

Author: brianleroux

src/static/index.js

@@ -25,7 +25,7 @@ module.exports = function _static (asset, options = {}) {
     let pkg = JSON.parse(read(manifest))
     let asset = pkg[key]
     if (!asset)
-      throw ReferenceError(`Could not find asset in static.json (asset fingerprint manifest): ${key}`)
+      return `${path}/${key}`
     return `${path}/${asset}`
   }
   return `${path}/${isIndex ? '' : key}`

test/unit/src/static/index-test.js

@@ -51,7 +51,7 @@ test('Staging env returns non-fingerprinted path if static manifest is not prese
   t.equal(asset, '/_static/foo.png', 'Returned non-fingerprinted path')
 })
 
-test('Staging env returns non-fingerprinted path if static manifest is present', t => {
+test('Staging env returns fingerprinted path if static manifest is present', t => {
   t.plan(1)
   reset()
   manifestExists = true
@@ -60,14 +60,13 @@ test('Staging env returns non-fingerprinted path if static manifest is present',
   t.equal(asset, '/_static/foo-1a2b3d.png', 'Returned fingerprinted path')
 })
 
-test('Staging env returns non-fingerprinted path if static manifest is present', t => {
+test('Staging env returns non-fingerprinted path if file is not present in static manifest mapping', t => {
   t.plan(1)
   reset()
   manifestExists = true
   process.env.ARC_ENV = 'staging'
-  t.throws(() => {
-    arcStatic('bar.png')
-  }, 'Static helper throws error if asset is not found')
+  let asset = arcStatic('bar.png')
+  t.equal(asset, '/_static/bar.png', 'Returned non-fingerprinted path')
 })
 
 test('Passing stagePath option adds API Gateway /staging or /production to path', t => {