Skip to content
This repository was archived by the owner on Dec 3, 2020. It is now read-only.

Commit e7a36f7

Browse files
author
Daniel Reigada
committed
Show parsers used on error message
1 parent 0cef252 commit e7a36f7

File tree

4 files changed

+9
-2
lines changed

4 files changed

+9
-2
lines changed

src/main/scala/com/codacy/parsers/CoverageParser.scala

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ trait CoverageParser {
1919

2020
def generateReport(): CoverageReport
2121

22+
def name: String
2223
}
2324

2425
trait XMLCoverageParser extends CoverageParser {
@@ -48,7 +49,9 @@ object CoverageParserFactory {
4849
} else {
4950
parserFactory.fold[Either[String, A]] {
5051
val parsers = allParsers(language, rootProject, reportFile)
51-
withReport(parsers)(s"could not parse report, unrecognized report format")(block)
52+
val parsersNames = parsers.map(_.name).mkString(", ")
53+
54+
withReport(parsers)(s"could not parse report, unrecognized report format (tried: $parsersNames)")(block)
5255
} { parserFactory =>
5356
val parser = parserFactory(language, rootProject, reportFile)
5457
withReport(Seq(parser))("could not parse report with the provided parser")(block)

src/main/scala/com/codacy/parsers/implementation/CoberturaParser.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ object CoberturaParser extends CoverageParserFactory {
1818

1919
class CoberturaParser(val language: Language.Value, val rootProject: File, val coverageReport: File) extends XMLCoverageParser {
2020

21+
override val name = "Cobertura"
22+
2123
val rootProjectDir = sanitiseFilename(rootProject.getAbsolutePath + File.separator)
2224

2325
lazy val allFiles = recursiveListFiles(rootProject) { file =>

src/main/scala/com/codacy/parsers/implementation/JacocoParser.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ object JacocoParser extends CoverageParserFactory {
1616

1717
class JacocoParser(val language: Language.Value, val rootProject: File, val coverageReport: File) extends XMLCoverageParser {
1818

19+
override val name = "Jacoco"
20+
1921
val rootProjectDir = rootProject.getAbsolutePath + File.separator
2022

2123
override def isValidReport: Boolean = {

src/test/scala/com/codacy/parsers/CoverageParserFactoryTest.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class CoverageParserFactoryTest extends WordSpec with BeforeAndAfterAll with Mat
3030

3131
"fail to get invalid report" in {
3232
runForFile("invalid_report.xml", None) shouldEqual
33-
Left("could not parse report, unrecognized report format")
33+
Left("could not parse report, unrecognized report format (tried: Cobertura, Jacoco)")
3434
}
3535

3636
"fail to get report with wrong parser" in {

0 commit comments

Comments
 (0)