Fix PHPUnit notices

Author: pierres

api/tests/Command/UpdateFeedsCommandTest.php

@@ -31,7 +31,7 @@ public function testCommand(): void
 
         /** @var FeedRepository|MockObject $feedRepository */
         $feedRepository = $this->createMock(FeedRepository::class);
-        $feedRepository->method('findAllExceptByUrls')->willReturn([$oldFeed]);
+        $feedRepository->expects($this->once())->method('findAllExceptByUrls')->willReturn([$oldFeed]);
 
         /** @var EntityManager|MockObject $entityManager */
         $entityManager = $this->createMock(EntityManager::class);
@@ -48,7 +48,7 @@ function (callable $callable) use ($entityManager): void {
 
         /** @var FeedFetcher|MockObject $feedFetcher */
         $feedFetcher = $this->createMock(FeedFetcher::class);
-        $feedFetcher->method('getIterator')->willReturn(new \ArrayIterator([$newFeed]));
+        $feedFetcher->expects($this->once())->method('getIterator')->willReturn(new \ArrayIterator([$newFeed]));
 
         /** @var ValidatorInterface|MockObject $validator */
         $validator = $this->createMock(ValidatorInterface::class);
@@ -86,7 +86,7 @@ public function testInvalidFeedIsSkipped(): void
 
         /** @var FeedRepository|MockObject $feedRepository */
         $feedRepository = $this->createMock(FeedRepository::class);
-        $feedRepository->method('findAllExceptByUrls')->willReturn([]);
+        $feedRepository->expects($this->once())->method('findAllExceptByUrls')->willReturn([]);
 
         /** @var EntityManager|MockObject $entityManager */
         $entityManager = $this->createMock(EntityManager::class);
@@ -103,14 +103,14 @@ function (callable $callable) use ($entityManager): void {
 
         /** @var FeedFetcher|MockObject $feedFetcher */
         $feedFetcher = $this->createMock(FeedFetcher::class);
-        $feedFetcher->method('getIterator')->willReturn(new \ArrayIterator([$newFeed]));
+        $feedFetcher->expects($this->once())->method('getIterator')->willReturn(new \ArrayIterator([$newFeed]));
 
         /** @var ValidatorInterface|MockObject $validator */
         $validator = $this->createMock(ValidatorInterface::class);
         $validator
             ->expects($this->once())
             ->method('validate')
-            ->willReturn(new ConstraintViolationList([$this->createMock(ConstraintViolation::class)]));
+            ->willReturn(new ConstraintViolationList([$this->createStub(ConstraintViolation::class)]));
 
         /** @var LoggerInterface|MockObject $logger */
         $logger = $this->createMock(LoggerInterface::class);
@@ -144,7 +144,7 @@ public function testUpdateFeed(): void
 
         /** @var FeedRepository|MockObject $feedRepository */
         $feedRepository = $this->createMock(FeedRepository::class);
-        $feedRepository->method('find')->willReturn($feed);
+        $feedRepository->expects($this->once())->method('find')->willReturn($feed);
 
         /** @var EntityManager|MockObject $entityManager */
         $entityManager = $this->createMock(EntityManager::class);
@@ -161,7 +161,7 @@ function (callable $callable) use ($entityManager): void {
 
         /** @var FeedFetcher|MockObject $feedFetcher */
         $feedFetcher = $this->createMock(FeedFetcher::class);
-        $feedFetcher->method('getIterator')->willReturn(new \ArrayIterator([$feed]));
+        $feedFetcher->expects($this->once())->method('getIterator')->willReturn(new \ArrayIterator([$feed]));
 
         /** @var ValidatorInterface|MockObject $validator */
         $validator = $this->createMock(ValidatorInterface::class);

api/tests/Entity/FeedTest.php

@@ -4,15 +4,13 @@
 
 use App\Entity\Feed;
 use App\Entity\Item;
-use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
 class FeedTest extends TestCase
 {
     public function testEntity(): void
     {
-        /** @var Item|MockObject $item */
-        $item = $this->createMock(Item::class);
+        $item = $this->createStub(Item::class);
         $feed = new Feed('https://www.archlinux.de/news/feed')
             ->setDescription('Arch Linux News')
             ->setLink('https://www.archlinux.de/news')

api/tests/Entity/ItemTest.php

@@ -5,17 +5,14 @@
 use App\Entity\Author;
 use App\Entity\Feed;
 use App\Entity\Item;
-use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
 class ItemTest extends TestCase
 {
     public function testEntity(): void
     {
-        /** @var Author|MockObject $author */
-        $author = $this->createMock(Author::class);
-        /** @var Feed|MockObject $feed */
-        $feed = $this->createMock(Feed::class);
+        $author = $this->createStub(Author::class);
+        $feed = $this->createStub(Feed::class);
         $item = new Item('https://www.archlinux.de/news/item')
             ->setLastModified(new \DateTime('2019-01-01'))
             ->setTitle('Item Title')

api/tests/Service/FeedFetcherTest.php

@@ -74,8 +74,7 @@ public function testGetIterator(): void
 
     public function testGetFeedUrls(): void
     {
-        /** @var FeedReaderFactory|MockObject $feedReaderFactory */
-        $feedReaderFactory = $this->createMock(FeedReaderFactory::class);
+        $feedReaderFactory = $this->createStub(FeedReaderFactory::class);
         $feedFetcher = new FeedFetcher(
             ['https://www.archlinux.de/news/feed'],
             $feedReaderFactory

api/tests/Twig/AppExtensionTest.php

@@ -13,7 +13,7 @@ class AppExtensionTest extends TestCase
     public function testHtmlEntityDecodeFilter(): void
     {
         $callable = $this->getFilterCallableFromExtension(
-            new AppExtension($this->createMock(HtmlSanitizerInterface::class)),
+            new AppExtension($this->createStub(HtmlSanitizerInterface::class)),
             'html_entity_decode'
         );
         if (is_callable($callable)) {