Introduce rector

Author: pierres

api/composer.json

@@ -17,7 +17,7 @@
         "ext-pdo_mysql": "*",
         "ext-xml": "*",
         "ext-xmlreader": "*",
-        "doctrine/doctrine-bundle": "^2.16.2",
+        "doctrine/doctrine-bundle": "^2.17.2",
         "doctrine/doctrine-migrations-bundle": "^3.4.2",
         "doctrine/orm": "^3.5.2",
         "simplepie/simplepie": "^1.9.0",
@@ -45,14 +45,15 @@
         "fakerphp/faker": "^1.24.1",
         "malukenho/mcbumpface": "^1.2.0",
         "phpstan/extension-installer": "^1.4.3",
-        "phpstan/phpstan": "^2.1.30",
+        "phpstan/phpstan": "^2.1.31",
         "phpstan/phpstan-deprecation-rules": "^2.0.3",
         "phpstan/phpstan-doctrine": "^2.0.10",
         "phpstan/phpstan-phpunit": "^2.0.7",
         "phpstan/phpstan-symfony": "^2.0.8",
-        "phpunit/phpunit": "^12.4.0",
+        "phpunit/phpunit": "^12.4.1",
         "pierres/doctrine-migrations-test": "^2.4.0",
         "pierres/symfony-database-test": "^2.3.0",
+        "rector/rector": "^2.2.2",
         "squizlabs/php_codesniffer": "^3.13.4",
         "symfony/phpunit-bridge": "^7.3.4"
     },

api/composer.lock

@@ -19,13 +19,15 @@ public function up(Schema $schema): void
         $this->addSql('ALTER TABLE item ADD CONSTRAINT FK_1F1B251E6FAD93B FOREIGN KEY (feed_url) REFERENCES feed (url) ON DELETE CASCADE');
     }
 
+    #[\Override]
     public function down(Schema $schema): void
     {
         $this->addSql('ALTER TABLE item DROP FOREIGN KEY FK_1F1B251E6FAD93B');
         $this->addSql('DROP TABLE item');
         $this->addSql('DROP TABLE feed');
     }
 
+    #[\Override]
     public function isTransactional(): bool
     {
         return false;

api/migrations/Version20190101125607.php

@@ -16,6 +16,7 @@ public function up(Schema $schema): void
         $this->addSql('ALTER TABLE item ADD PRIMARY KEY (link)');
     }
 
+    #[\Override]
     public function down(Schema $schema): void
     {
         $this->addSql('ALTER TABLE item DROP PRIMARY KEY');
@@ -25,6 +26,7 @@ public function down(Schema $schema): void
         $this->addSql('ALTER TABLE item ADD PRIMARY KEY (public_id, feed_url)');
     }
 
+    #[\Override]
     public function isTransactional(): bool
     {
         return false;

api/migrations/Version20191217125634.php

@@ -14,6 +14,7 @@ public function up(Schema $schema): void
         $this->addSql('ALTER TABLE item CHANGE feed_url feed_url VARCHAR(191) NOT NULL');
     }
 
+    #[\Override]
     public function down(Schema $schema): void
     {
         $this->addSql('ALTER TABLE item DROP FOREIGN KEY FK_1F1B251E6FAD93B');
@@ -23,6 +24,7 @@ public function down(Schema $schema): void
         $this->addSql('ALTER TABLE item ADD CONSTRAINT FK_1F1B251E6FAD93B FOREIGN KEY (feed_url) REFERENCES feed (url) ON DELETE CASCADE');
     }
 
+    #[\Override]
     public function isTransactional(): bool
     {
         return false;

api/migrations/Version20220122121022.php

@@ -0,0 +1,41 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\CodeQuality\Rector\Empty_\SimplifyEmptyCheckOnEmptyArrayRector;
+use Rector\CodeQuality\Rector\FuncCall\SimplifyRegexPatternRector;
+use Rector\CodeQuality\Rector\If_\ExplicitBoolCompareRector;
+use Rector\Config\RectorConfig;
+use Rector\DeadCode\Rector\FunctionLike\NarrowTooWideReturnTypeRector;
+use Rector\Php80\Rector\Class_\ClassPropertyAssignToConstructorPromotionRector;
+use Rector\Renaming\Rector\Name\RenameClassRector;
+use Rector\Strict\Rector\Empty_\DisallowedEmptyRuleFixerRector;
+use Rector\Symfony\Bridge\Symfony\Routing\SymfonyRoutesProvider;
+use Rector\Symfony\Contract\Bridge\Symfony\Routing\SymfonyRoutesProviderInterface;
+
+return RectorConfig::configure()
+    ->withPaths([
+        __DIR__ . '/migrations',
+        __DIR__ . '/src',
+        __DIR__ . '/tests',
+    ])
+    ->withRootFiles()
+    ->withPhpSets()
+    ->withComposerBased(twig: true, doctrine: true, phpunit: true, symfony: true)
+    ->withAttributesSets()
+    ->withSymfonyContainerPhp(__DIR__ . '/tests/symfony-container.php')
+    ->registerService(SymfonyRoutesProvider::class, SymfonyRoutesProviderInterface::class)
+    ->withPreparedSets(deadCode: true, codeQuality: true, typeDeclarations: true)
+    ->withImportNames(importShortClasses: false, removeUnusedImports: true)
+    ->withSkip([
+        ClassPropertyAssignToConstructorPromotionRector::class,
+        RenameClassRector::class,
+        ExplicitBoolCompareRector::class,
+        DisallowedEmptyRuleFixerRector::class,
+        SimplifyEmptyCheckOnEmptyArrayRector::class,
+        // want to replace [0-9]  with \d which is not the same though
+        SimplifyRegexPatternRector::class,
+        NarrowTooWideReturnTypeRector::class => [
+            __DIR__ . '/tests/Entity/Packages/Relations/LibraryRelationTraitTest.php',
+        ],
+    ]);