-
Notifications
You must be signed in to change notification settings - Fork 675
fix(hardware): bring nvidia driver installation in line with packaging changes #4053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| if gfx_driver == 'Nvidia (proprietary)': | ||
| _gfx_driver = GfxDriver.NvidiaOpenSource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I understand the "why".
But I'm not sure it's a great idea to let the user be un-informed when they chose "proprietary" but got "nouveau" :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you propose then? I'm not sure how we could clearly communicate this unless there is some pop up when the installer is first ran telling them what is going to happen and that they should probably update their config (and read the announcement regarding packaging changes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think one option is to not show the nvidia prop driver at all, if it's not supported?
But not sure how to do that based on hardware ID's and stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request removes the proprietary driver from the menus, but if you read the previous pull request (#4019) @svartkanin was worried about backwards compatibility with older configs, hence why this is here.
As of driver release 590.48.01, they are no longer supporting the proprietary driver hence it was removed from the repositories which only leaves the open kernel module available and it only supports Turing+ hardware (GTX 1650/RTX 2000 and newer)
If we fall back to the open kernel module for these older configs and the user happens to have pre-Turing hardware, they're going to be met with a black screen when they boot after installation, which I find undesirable in my opinion. I'd rather someone end up getting the 'incorrect' but working graphics driver that they can fix themselves after the installation than them be met with a broken install that may leave a new user confused with a system they can't use.
|
Bumping this as I'd like to hopefully get this merged in time for the February .iso release since it didn't make it in time for the January one. |
|
I think the issue of #4053 (comment) is valid tho and needs to be addressed. |
Title.
I ended up going with the simpler solution proposed in the earlier pull request (#4019)