mirrors: convert to pytest

Author: jelly

mirrors/tests/test_mirrorcheck.py

@@ -6,150 +6,132 @@
 from ssl import CertificateError
 from socket import timeout, error
 
+import pytest
 
 from django.utils.timezone import now
 from datetime import timedelta
 
-
-from django.test import TestCase
 from django.core.management import call_command
 
-
-from mirrors.tests import create_mirror_url
-from mirrors.models import MirrorLog, CheckLocation
-
-
-class MirrorCheckTest(TestCase):
-    def setUp(self):
-        self.mirror_url = create_mirror_url()
-
-    def tearDown(self):
-        self.mirror_url.delete()
-
-    @mock.patch('urllib.request.Request')
-    @mock.patch('urllib.request.urlopen')
-    def test_invalid(self, urlopen, Request):
-        urlopen.return_value.read.return_value = 'data'
-        Request.get_host.return_value = 'archlinux.org'
-        Request.type.return_value = 'https'
-
-        call_command('mirrorcheck')
-        mirrorlog = MirrorLog.objects.first()
-        self.assertNotEqual(mirrorlog.error, '')
-        self.assertEqual(mirrorlog.is_success, False)
-
-    @mock.patch('urllib.request.Request')
-    @mock.patch('urllib.request.urlopen')
-    def test_valid(self, urlopen, Request):
-        urlopen.return_value.read.return_value = str(int(time.time()))
-        Request.get_host.return_value = 'archlinux.org'
-        Request.type.return_value = 'https'
-
-        call_command('mirrorcheck')
-        mirrorlog = MirrorLog.objects.first()
-        self.assertEqual(mirrorlog.error, '')
-        self.assertEqual(mirrorlog.is_success, True)
-
-    @mock.patch('urllib.request.Request')
-    @mock.patch('urllib.request.urlopen')
-    def test_valid_olddate(self, urlopen, Request):
-        urlopen.return_value.read.return_value = str(int(time.time()))
-        Request.get_host.return_value = 'archlinux.org'
-        Request.type.return_value = 'https'
-
-        date = now() - timedelta(days=600)
-        MirrorLog.objects.create(url=self.mirror_url, check_time=date)
-        call_command('mirrorcheck')
-        self.assertEqual(len(MirrorLog.objects.all()), 1)
-
-    @mock.patch('urllib.request.Request')
-    @mock.patch('urllib.request.urlopen')
-    def test_not_found(self, urlopen, Request):
-        excp = HTTPError('https://archlinux.org/404.txt', 404, 'Not Found', '', None)
-        urlopen.return_value.read.side_effect = excp
-        Request.get_host.return_value = 'archlinux.org'
-        Request.type.return_value = 'https'
-
-        call_command('mirrorcheck')
-        mirrorlog = MirrorLog.objects.first()
-        self.assertEqual(mirrorlog.error, str(excp))
-        self.assertEqual(mirrorlog.is_success, False)
-
-    @mock.patch('urllib.request.Request')
-    @mock.patch('urllib.request.urlopen')
-    def test_not_found_variant(self, urlopen, Request):
-        excp = BadStatusLine('')
-        urlopen.return_value.read.side_effect = excp
-        Request.get_host.return_value = 'archlinux.org'
-        Request.type.return_value = 'https'
-
-        call_command('mirrorcheck')
-        mirrorlog = MirrorLog.objects.first()
-        self.assertIn('Exception in processing', mirrorlog.error)
-        self.assertEqual(mirrorlog.is_success, False)
-
-    @mock.patch('urllib.request.Request')
-    @mock.patch('urllib.request.urlopen')
-    def test_cert_error(self, urlopen, Request):
-        excp = CertificateError('certificate error')
-        urlopen.return_value.read.side_effect = excp
-        Request.get_host.return_value = 'archlinux.org'
-        Request.type.return_value = 'https'
-
-        call_command('mirrorcheck')
-        mirrorlog = MirrorLog.objects.first()
-        self.assertIn('certificate error', mirrorlog.error)
-        self.assertEqual(mirrorlog.is_success, False)
-
-    @mock.patch('urllib.request.Request')
-    @mock.patch('urllib.request.urlopen')
-    def test_general_httpexception(self, urlopen, Request):
-        excp = URLError('550 No such file', '550.txt')
-        urlopen.return_value.read.side_effect = excp
-        Request.get_host.return_value = 'archlinux.org'
-        Request.type.return_value = 'https'
-
-        call_command('mirrorcheck')
-        mirrorlog = MirrorLog.objects.first()
-        self.assertIn(excp.reason, mirrorlog.error)
-        self.assertEqual(mirrorlog.is_success, False)
-
-    @mock.patch('urllib.request.Request')
-    @mock.patch('urllib.request.urlopen')
-    def test_socket_timeout(self, urlopen, Request):
-        excp = timeout('timeout')
-        urlopen.return_value.read.side_effect = excp
-        Request.get_host.return_value = 'archlinux.org'
-        Request.type.return_value = 'https'
-
-        call_command('mirrorcheck')
-        mirrorlog = MirrorLog.objects.first()
-        self.assertEqual('Connection timed out.', mirrorlog.error)
-        self.assertEqual(mirrorlog.is_success, False)
-
-    @mock.patch('urllib.request.Request')
-    @mock.patch('urllib.request.urlopen')
-    def test_socket_error(self, urlopen, Request):
-        excp = error('error')
-        urlopen.return_value.read.side_effect = excp
-        Request.get_host.return_value = 'archlinux.org'
-        Request.type.return_value = 'https'
-
-        call_command('mirrorcheck')
-        mirrorlog = MirrorLog.objects.first()
-        self.assertEqual(str(excp), mirrorlog.error)
-        self.assertEqual(mirrorlog.is_success, False)
-
-    def test_checklocation(self):
-        with self.assertRaises(CheckLocation.DoesNotExist) as e:
-            call_command('mirrorcheck', '-l', '1')
-        self.assertEqual('CheckLocation matching query does not exist.', str(e.exception))
-
-    def test_checklocation_model(self):
-        checkloc = CheckLocation.objects.create(hostname='archlinux.org',
-                                                     source_ip='1.1.1.1')
-        with mock.patch('mirrors.management.commands.mirrorcheck.logger') as logger:
-            call_command('mirrorcheck', '-l', '1')
-        logger.info.assert_called()
-
-        checkloc.delete()
+from mirrors.models import CheckLocation, MirrorLog
+from mirrors.tests.conftest import HOSTNAME, PROTOCOL
+
+
+def mocked_request(urlopen, Request, return_value):
+    urlopen.return_value.read.return_value = return_value
+    Request.get_host.return_value = HOSTNAME
+    Request.type.return_value = PROTOCOL
+
+
+def mocked_request_exception(urlopen, Request, excp):
+    urlopen.return_value.read.side_effect = excp
+    Request.get_host.return_value = HOSTNAME
+    Request.type.return_value = PROTOCOL
+
+
+@mock.patch('urllib.request.Request')
+@mock.patch('urllib.request.urlopen')
+def test_invalid(urlopen, Request, mirrorurl):
+    mocked_request(urlopen, Request, 'data')
+    call_command('mirrorcheck')
+    mirrorlog = MirrorLog.objects.first()
+    assert mirrorlog.error != ''
+    assert mirrorlog.is_success == False
+
+@mock.patch('urllib.request.Request')
+@mock.patch('urllib.request.urlopen')
+def test_valid(urlopen, Request, mirrorurl):
+    mocked_request(urlopen, Request, str(int(time.time())))
+    call_command('mirrorcheck')
+    mirrorlog = MirrorLog.objects.first()
+    assert mirrorlog.error == ''
+    assert mirrorlog.is_success == True
+
+
+@mock.patch('urllib.request.Request')
+@mock.patch('urllib.request.urlopen')
+def test_valid_olddate(urlopen, Request, mirrorurl):
+    mocked_request(urlopen, Request, str(int(time.time())))
+    date = now() - timedelta(days=600)
+    MirrorLog.objects.create(url=mirrorurl, check_time=date)
+    call_command('mirrorcheck')
+    assert len(MirrorLog.objects.all()) == 1
+
+
+@mock.patch('urllib.request.Request')
+@mock.patch('urllib.request.urlopen')
+def test_not_found(urlopen, Request, mirrorurl):
+    excp = HTTPError('https://archlinux.org/404.txt', 404, 'Not Found', '', None)
+    mocked_request_exception(urlopen, Request, excp)
+    call_command('mirrorcheck')
+    mirrorlog = MirrorLog.objects.first()
+    assert mirrorlog.error == str(excp)
+    assert mirrorlog.is_success == False
+
+
+@mock.patch('urllib.request.Request')
+@mock.patch('urllib.request.urlopen')
+def test_not_found_variant(urlopen, Request, mirrorurl):
+    excp = BadStatusLine('')
+    mocked_request_exception(urlopen, Request, excp)
+    call_command('mirrorcheck')
+    mirrorlog = MirrorLog.objects.first()
+    assert 'Exception in processing' in mirrorlog.error
+    assert mirrorlog.is_success == False
+
+
+@mock.patch('urllib.request.Request')
+@mock.patch('urllib.request.urlopen')
+def test_cert_error(urlopen, Request, mirrorurl):
+    excp = CertificateError('certificate error')
+    mocked_request_exception(urlopen, Request, excp)
+    call_command('mirrorcheck')
+    mirrorlog = MirrorLog.objects.first()
+    assert 'certificate error' in mirrorlog.error
+    assert mirrorlog.is_success == False
+
+
+@mock.patch('urllib.request.Request')
+@mock.patch('urllib.request.urlopen')
+def test_general_httpexception(urlopen, Request, mirrorurl):
+    excp = URLError('550 No such file', '550.txt')
+    mocked_request_exception(urlopen, Request, excp)
+    call_command('mirrorcheck')
+    mirrorlog = MirrorLog.objects.first()
+    assert excp.reason in mirrorlog.error
+    assert mirrorlog.is_success == False
+
+
+@mock.patch('urllib.request.Request')
+@mock.patch('urllib.request.urlopen')
+def test_socket_timeout(urlopen, Request, mirrorurl):
+    excp = timeout('timeout')
+    mocked_request_exception(urlopen, Request, excp)
+
+    call_command('mirrorcheck')
+    mirrorlog = MirrorLog.objects.first()
+    assert 'Connection timed out.' in mirrorlog.error
+    assert mirrorlog.is_success == False
+
+
+@mock.patch('urllib.request.Request')
+@mock.patch('urllib.request.urlopen')
+def test_socket_error(urlopen, Request, mirrorurl):
+    excp = error('error')
+    mocked_request_exception(urlopen, Request, excp)
+
+    call_command('mirrorcheck')
+    mirrorlog = MirrorLog.objects.first()
+    assert str(excp) in mirrorlog.error
+    assert mirrorlog.is_success == False
+
+
+def test_checklocation_fail(db):
+    with pytest.raises(CheckLocation.DoesNotExist) as e:
+        call_command('mirrorcheck', '-l', '1')
+    assert 'CheckLocation matching query does not exist.' == str(e.value)
+
+def test_checklocation_model(checklocation):
+    with mock.patch('mirrors.management.commands.mirrorcheck.logger') as logger:
+        call_command('mirrorcheck', '-l', '1')
+    logger.info.assert_called()