main: convert tests to pytest

Author: jelly

main/tests/test_donor_import.py

@@ -1,80 +1,82 @@
 # -*- coding: utf-8 -*-
 
-import sys
 from email.header import Header
 from email.message import Message
-from io import StringIO
-from tempfile import mkdtemp
+from mailbox import Maildir
+
+import pytest
 
-from django.test import TransactionTestCase
 from django.core.management import call_command
 from django.core.management.base import CommandError
 
 from main.models import Donor
 from main.management.commands.donor_import import Command
 
 
-class DonorImportTest(TransactionTestCase):
-
-    def setUp(self):
-        self.command = Command()
-
-    def test_parse_subject(self):
-        self.assertIsNone(self.command.parse_subject('garbage'))
-
-        # Valid
-        valid = u'Receipt [$25.00] By: John Doe [[email protected]]'
-        output = self.command.parse_subject(valid)
-        self.assertEqual(output, u'John Doe')
-
-    def test_parse_name(self):
-        self.assertEqual(self.command.sanitize_name(u'1244'), u'')
-        self.assertEqual(self.command.sanitize_name(u'John Doe'), u'John Doe')
-        self.assertEqual(self.command.sanitize_name(u' John Doe '), u'John Doe')
-        self.assertEqual(self.command.sanitize_name(u'John Doe 23'), u'John Doe')
-
-    def test_decode_subject(self):
-        text = u'メイル'
-        subject = Header(text, 'utf-8')
-        self.assertEqual(self.command.decode_subject(subject), text)
-
-    def test_invalid_args(self):
-        stdin = sys.stdin
-        with self.assertRaises(CommandError) as e:
-            sys.stdin = StringIO('')
-            call_command('donor_import')
-        self.assertIn('Failed to read from STDIN', str(e.exception))
-        sys.stdin = stdin
-
-    def test_invalid_path(self):
-        with self.assertRaises(CommandError) as e:
-            call_command('donor_import', '/tmp/non-existant')
-        self.assertIn('argument input: can\'t open', str(e.exception))
-
-    def test_import(self):
-        tmpmail = mkdtemp('archweb') + "/mail"
-
-        msg = Message()
-        msg['subject'] = 'John Doe'
-        msg['to'] = 'John Doe <[email protected]>'
-        with open(tmpmail, 'wb') as fp:
-            fp.write(msg.as_bytes())
-
-        # Invalid
-        with self.assertRaises(SystemExit):
-            call_command('donor_import', tmpmail)
-        self.assertEqual(len(Donor.objects.all()), 0)
-
-        # Valid
-        msg = Message()
-        msg['subject'] = 'Receipt [$25.00] By: David Doe [[email protected]]'
-        msg['to'] = 'John Doe <[email protected]>'
-        with open(tmpmail, 'wb') as fp:
-            fp.write(msg.as_bytes())
-
-        call_command('donor_import', tmpmail)
-        self.assertEqual(len(Donor.objects.all()), 1)
-
-        # Re-running should result in no new donor
-        call_command('donor_import', tmpmail)
-        self.assertEqual(len(Donor.objects.all()), 1)
+command = Command()
+
+
+def gen_parse_subject(data):
+    return command.parse_subject(data)
+
+
+def test_parse_subject(self):
+    assert self.command.parse_subject('garbage') is None
+
+    # Valid
+    valid = 'Receipt [$25.00] By: John Doe [[email protected]]'
+    output = command.parse_subject(valid)
+    assert output == 'John Doe'
+
+
+def test_parse_name():
+    assert command.sanitize_name('1244') == ''
+    assert command.sanitize_name('John Doe') == 'John Doe'
+    assert command.sanitize_name(' John Doe ') == 'John Doe'
+    assert command.sanitize_name('John Doe 23') == 'John Doe'
+
+
+def test_decode_subject():
+    text = u'メイル'
+    subject = Header(text, 'utf-8')
+    assert command.decode_subject(subject) == text
+
+
+def test_invalid_args():
+    with pytest.raises(CommandError) as e:
+        call_command('donor_import')
+    assert 'Error: the following arguments are required' in str(e.value)
+
+
+def test_invalid_path():
+    with pytest.raises(CommandError) as e:
+        call_command('donor_import', '/tmp/non-existant')
+    assert 'Failed to open maildir' in str(e.value)
+
+
+def test_maildir(db, tmp_path):
+    tmpdir = tmp_path / 'archweb'
+    tmpdir.mkdir()
+    mdir = tmpdir / 'maildir'
+
+    maildir = Maildir(mdir)
+    msg = Message()
+    msg['subject'] = 'John Doe'
+    msg['to'] = 'John Doe <[email protected]>'
+    maildir.add(msg)
+
+    # Invalid
+    call_command('donor_import', mdir)
+    assert len(Donor.objects.all()) == 0
+
+    # Valid
+    msg = Message()
+    msg['subject'] = 'Receipt [$25.00] By: David Doe [[email protected]]'
+    msg['to'] = 'John Doe <[email protected]>'
+    maildir.add(msg)
+    call_command('donor_import', mdir)
+    assert len(Donor.objects.all()) == 1
+
+    # Re-running should result in no new donor
+    call_command('donor_import', mdir)
+    assert len(Donor.objects.all()) == 1

main/tests/test_templatetags_flags.py

@@ -1,22 +1,10 @@
-from django.test import TestCase
-
-
 from main.templatetags.flags import country_flag
-from mirrors.models import CheckLocation
-
-
-class FlagsTemplateTest(TestCase):
 
-    def setUp(self):
-        self.checkloc = CheckLocation.objects.create(hostname='arch.org',
-                                                     source_ip='127.0.0.1',
-                                                     country='US')
+from mirrors.tests.conftest import checklocation
 
-    def tearDown(self):
-        self.checkloc.delete()
 
-    def test_country_flag(self):
-        flag = country_flag(self.checkloc.country)
-        self.assertIn(self.checkloc.country.name, flag)
-        self.assertIn(self.checkloc.country.code.lower(), flag)
-        self.assertEqual(country_flag(None), '')
+def test_country_flag(checklocation):
+    flag = country_flag(checklocation.country)
+    assert checklocation.country.name in flag
+    assert checklocation.country.code.lower() in flag
+    assert country_flag(None) == ''